Skip to content
Snippets Groups Projects
  1. Aug 08, 2016
    • Weiqing Yang's avatar
      [SPARK-16945] Fix Java Lint errors · e10ca8de
      Weiqing Yang authored
      ## What changes were proposed in this pull request?
      This PR is to fix the minor Java linter errors as following:
      [ERROR] src/main/java/org/apache/spark/sql/catalyst/expressions/VariableLengthRowBasedKeyValueBatch.java:[42,10] (modifier) RedundantModifier: Redundant 'final' modifier.
      [ERROR] src/main/java/org/apache/spark/sql/catalyst/expressions/VariableLengthRowBasedKeyValueBatch.java:[97,10] (modifier) RedundantModifier: Redundant 'final' modifier.
      
      ## How was this patch tested?
      Manual test.
      dev/lint-java
      Using `mvn` from path: /usr/local/bin/mvn
      Checkstyle checks passed.
      
      Author: Weiqing Yang <yangweiqing001@gmail.com>
      
      Closes #14532 from Sherry302/master.
      e10ca8de
  2. Aug 05, 2016
    • Bryan Cutler's avatar
      [SPARK-16421][EXAMPLES][ML] Improve ML Example Outputs · 180fd3e0
      Bryan Cutler authored
      ## What changes were proposed in this pull request?
      Improve example outputs to better reflect the functionality that is being presented.  This mostly consisted of modifying what was printed at the end of the example, such as calling show() with truncate=False, but sometimes required minor tweaks in the example data to get relevant output.  Explicitly set parameters when they are used as part of the example.  Fixed Java examples that failed to run because of using old-style MLlib Vectors or problem with schema.  Synced examples between different APIs.
      
      ## How was this patch tested?
      Ran each example for Scala, Python, and Java and made sure output was legible on a terminal of width 100.
      
      Author: Bryan Cutler <cutlerb@gmail.com>
      
      Closes #14308 from BryanCutler/ml-examples-improve-output-SPARK-16260.
      180fd3e0
  3. Aug 02, 2016
    • sandy's avatar
      [SPARK-16816] Modify java example which is also reflect in documentation exmaple · cbdff493
      sandy authored
      ## What changes were proposed in this pull request?
      
      Modify java example which is also reflect in document.
      
      ## How was this patch tested?
      
      run test cases.
      
      Author: sandy <phalodi@gmail.com>
      
      Closes #14436 from phalodi/SPARK-16816.
      cbdff493
    • Xusen Yin's avatar
      [SPARK-16558][EXAMPLES][MLLIB] examples/mllib/LDAExample should use MLVector... · dd8514fa
      Xusen Yin authored
      [SPARK-16558][EXAMPLES][MLLIB] examples/mllib/LDAExample should use MLVector instead of MLlib Vector
      
      ## What changes were proposed in this pull request?
      
      mllib.LDAExample uses ML pipeline and MLlib LDA algorithm. The former transforms original data into MLVector format, while the latter uses MLlibVector format.
      
      ## How was this patch tested?
      
      Test manually.
      
      Author: Xusen Yin <yinxusen@gmail.com>
      
      Closes #14212 from yinxusen/SPARK-16558.
      dd8514fa
    • Cheng Lian's avatar
      [SPARK-16734][EXAMPLES][SQL] Revise examples of all language bindings · 10e1c0e6
      Cheng Lian authored
      ## What changes were proposed in this pull request?
      
      This PR makes various minor updates to examples of all language bindings to make sure they are consistent with each other. Some typos and missing parts (JDBC example in Scala/Java/Python) are also fixed.
      
      ## How was this patch tested?
      
      Manually tested.
      
      Author: Cheng Lian <lian@databricks.com>
      
      Closes #14368 from liancheng/revise-examples.
      10e1c0e6
  4. Jul 30, 2016
    • Bryan Cutler's avatar
      [SPARK-16800][EXAMPLES][ML] Fix Java examples that fail to run due to exception · a6290e51
      Bryan Cutler authored
      ## What changes were proposed in this pull request?
      Some Java examples are using mllib.linalg.Vectors instead of ml.linalg.Vectors and causes an exception when run.  Also there are some Java examples that incorrectly specify data types in the schema, also causing an exception.
      
      ## How was this patch tested?
      Ran corrected examples locally
      
      Author: Bryan Cutler <cutlerb@gmail.com>
      
      Closes #14405 from BryanCutler/java-examples-ml.Vectors-fix-SPARK-16800.
      a6290e51
    • Sean Owen's avatar
      [SPARK-16694][CORE] Use for/foreach rather than map for Unit expressions whose... · 0dc4310b
      Sean Owen authored
      [SPARK-16694][CORE] Use for/foreach rather than map for Unit expressions whose side effects are required
      
      ## What changes were proposed in this pull request?
      
      Use foreach/for instead of map where operation requires execution of body, not actually defining a transformation
      
      ## How was this patch tested?
      
      Jenkins
      
      Author: Sean Owen <sowen@cloudera.com>
      
      Closes #14332 from srowen/SPARK-16694.
      0dc4310b
  5. Jul 23, 2016
    • Cheng Lian's avatar
      [SPARK-16380][EXAMPLES] Update SQL examples and programming guide for Python language binding · 53b2456d
      Cheng Lian authored
      This PR is based on PR #14098 authored by wangmiao1981.
      
      ## What changes were proposed in this pull request?
      
      This PR replaces the original Python Spark SQL example file with the following three files:
      
      - `sql/basic.py`
      
        Demonstrates basic Spark SQL features.
      
      - `sql/datasource.py`
      
        Demonstrates various Spark SQL data sources.
      
      - `sql/hive.py`
      
        Demonstrates Spark SQL Hive interaction.
      
      This PR also removes hard-coded Python example snippets in the SQL programming guide by extracting snippets from the above files using the `include_example` Liquid template tag.
      
      ## How was this patch tested?
      
      Manually tested.
      
      Author: wm624@hotmail.com <wm624@hotmail.com>
      Author: Cheng Lian <lian@databricks.com>
      
      Closes #14317 from liancheng/py-examples-update.
      53b2456d
  6. Jul 19, 2016
    • Xin Ren's avatar
      [SPARK-16535][BUILD] In pom.xml, remove groupId which is redundant definition... · 21a6dd2a
      Xin Ren authored
      [SPARK-16535][BUILD] In pom.xml, remove groupId which is redundant definition and inherited from the parent
      
      https://issues.apache.org/jira/browse/SPARK-16535
      
      ## What changes were proposed in this pull request?
      
      When I scan through the pom.xml of sub projects, I found this warning as below and attached screenshot
      ```
      Definition of groupId is redundant, because it's inherited from the parent
      ```
      ![screen shot 2016-07-13 at 3 13 11 pm](https://cloud.githubusercontent.com/assets/3925641/16823121/744f893e-4916-11e6-8a52-042f83b9db4e.png)
      
      I've tried to remove some of the lines with groupId definition, and the build on my local machine is still ok.
      ```
      <groupId>org.apache.spark</groupId>
      ```
      As I just find now `<maven.version>3.3.9</maven.version>` is being used in Spark 2.x, and Maven-3 supports versionless parent elements: Maven 3 will remove the need to specify the parent version in sub modules. THIS is great (in Maven 3.1).
      
      ref: http://stackoverflow.com/questions/3157240/maven-3-worth-it/3166762#3166762
      
      ## How was this patch tested?
      
      I've tested by re-building the project, and build succeeded.
      
      Author: Xin Ren <iamshrek@126.com>
      
      Closes #14189 from keypointt/SPARK-16535.
      21a6dd2a
    • Dongjoon Hyun's avatar
      [MINOR][BUILD] Fix Java Linter `LineLength` errors · 556a9437
      Dongjoon Hyun authored
      ## What changes were proposed in this pull request?
      
      This PR fixes four java linter `LineLength` errors. Those are all `LineLength` errors, but we had better remove all java linter errors before release.
      
      ## How was this patch tested?
      
      After pass the Jenkins, `./dev/lint-java`.
      
      Author: Dongjoon Hyun <dongjoon@apache.org>
      
      Closes #14255 from dongjoon-hyun/minor_java_linter.
      556a9437
    • Cheng Lian's avatar
      [SPARK-16303][DOCS][EXAMPLES] Minor Scala/Java example update · 1426a080
      Cheng Lian authored
      ## What changes were proposed in this pull request?
      
      This PR moves one and the last hard-coded Scala example snippet from the SQL programming guide into `SparkSqlExample.scala`. It also renames all Scala/Java example files so that all "Sql" in the file names are updated to "SQL".
      
      ## How was this patch tested?
      
      Manually verified the generated HTML page.
      
      Author: Cheng Lian <lian@databricks.com>
      
      Closes #14245 from liancheng/minor-scala-example-update.
      1426a080
    • Zheng RuiFeng's avatar
      [MINOR] Remove unused arg in als.py · e5fbb182
      Zheng RuiFeng authored
      ## What changes were proposed in this pull request?
      The second arg in method `update()` is never used. So I delete it.
      
      ## How was this patch tested?
      local run with `./bin/spark-submit examples/src/main/python/als.py`
      
      Author: Zheng RuiFeng <ruifengz@foxmail.com>
      
      Closes #14247 from zhengruifeng/als_refine.
      e5fbb182
  7. Jul 18, 2016
  8. Jul 14, 2016
    • Bryan Cutler's avatar
      [SPARK-16403][EXAMPLES] Cleanup to remove unused imports, consistent style, minor fixes · e3f8a033
      Bryan Cutler authored
      ## What changes were proposed in this pull request?
      
      Cleanup of examples, mostly from PySpark-ML to fix minor issues:  unused imports, style consistency, pipeline_example is a duplicate, use future print funciton, and a spelling error.
      
      * The "Pipeline Example" is duplicated by "Simple Text Classification Pipeline" in Scala, Python, and Java.
      
      * "Estimator Transformer Param Example" is duplicated by "Simple Params Example" in Scala, Python and Java
      
      * Synced random_forest_classifier_example.py with Scala by adding IndexToString label converted
      
      * Synced train_validation_split.py (in Scala ModelSelectionViaTrainValidationExample) by adjusting data split, adding grid for intercept.
      
      * RegexTokenizer was doing nothing in tokenizer_example.py and JavaTokenizerExample.java, synced with Scala version
      
      ## How was this patch tested?
      local tests and run modified examples
      
      Author: Bryan Cutler <cutlerb@gmail.com>
      
      Closes #14081 from BryanCutler/examples-cleanup-SPARK-16403.
      e3f8a033
  9. Jul 13, 2016
  10. Jul 11, 2016
  11. Jul 04, 2016
    • wm624@hotmail.com's avatar
      [SPARK-16260][ML][EXAMPLE] PySpark ML Example Improvements and Cleanup · a539b724
      wm624@hotmail.com authored
      ## What changes were proposed in this pull request?
      1). Remove unused import in Scala example;
      
      2). Move spark session import outside example off;
      
      3). Change parameter setting the same as Scala;
      
      4). Change comment to be consistent;
      
      5). Make sure that Scala and python using the same data set;
      
      I did one pass and fixed the above issues. There are missing examples in python, which might be added later.
      
      TODO: For some examples, there are comments on how to run examples; But there are many missing. We can add them later.
      
      ## How was this patch tested?
      
      (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
      
      Manually test them
      
      Author: wm624@hotmail.com <wm624@hotmail.com>
      
      Closes #14021 from wangmiao1981/ann.
      a539b724
  12. Jul 02, 2016
    • WeichenXu's avatar
      [SPARK-16345][DOCUMENTATION][EXAMPLES][GRAPHX] Extract graphx programming... · 0bd7cd18
      WeichenXu authored
      [SPARK-16345][DOCUMENTATION][EXAMPLES][GRAPHX] Extract graphx programming guide example snippets from source files instead of hard code them
      
      ## What changes were proposed in this pull request?
      
      I extract 6 example programs from GraphX programming guide and replace them with
      `include_example` label.
      
      The 6 example programs are:
      - AggregateMessagesExample.scala
      - SSSPExample.scala
      - TriangleCountingExample.scala
      - ConnectedComponentsExample.scala
      - ComprehensiveExample.scala
      - PageRankExample.scala
      
      All the example code can run using
      `bin/run-example graphx.EXAMPLE_NAME`
      
      ## How was this patch tested?
      
      Manual.
      
      Author: WeichenXu <WeichenXu123@outlook.com>
      
      Closes #14015 from WeichenXu123/graphx_example_plugin.
      0bd7cd18
  13. Jun 30, 2016
  14. Jun 29, 2016
    • Bryan Cutler's avatar
      [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNames in ML Examples · 21385d02
      Bryan Cutler authored
      ## What changes were proposed in this pull request?
      
      Some appNames in ML examples are incorrect, mostly in PySpark but one in Scala.  This corrects the names.
      
      ## How was this patch tested?
      Style, local tests
      
      Author: Bryan Cutler <cutlerb@gmail.com>
      
      Closes #13949 from BryanCutler/pyspark-example-appNames-fix-SPARK-16261.
      21385d02
  15. Jun 28, 2016
    • James Thomas's avatar
      [SPARK-16114][SQL] structured streaming network word count examples · 3554713a
      James Thomas authored
      ## What changes were proposed in this pull request?
      
      Network word count example for structured streaming
      
      ## How was this patch tested?
      
      Run locally
      
      Author: James Thomas <jamesjoethomas@gmail.com>
      Author: James Thomas <jamesthomas@Jamess-MacBook-Pro.local>
      
      Closes #13816 from jjthomas/master.
      3554713a
  16. Jun 27, 2016
  17. Jun 24, 2016
  18. Jun 20, 2016
  19. Jun 17, 2016
    • GayathriMurali's avatar
      [SPARK-15129][R][DOC] R API changes in ML · af2a4b08
      GayathriMurali authored
      ## What changes were proposed in this pull request?
      
      Make user guide changes to SparkR documentation for all changes that happened in 2.0 to Machine Learning APIs
      
      Author: GayathriMurali <gayathri.m@intel.com>
      
      Closes #13285 from GayathriMurali/SPARK-15129.
      af2a4b08
  20. Jun 16, 2016
    • WeichenXu's avatar
      [SPARK-15608][ML][EXAMPLES][DOC] add examples and documents of ml.isotonic regression · 9040d83b
      WeichenXu authored
      ## What changes were proposed in this pull request?
      
      add ml doc for ml isotonic regression
      add scala example for ml isotonic regression
      add java example for ml isotonic regression
      add python example for ml isotonic regression
      
      modify scala example for mllib isotonic regression
      modify java example for mllib isotonic regression
      modify python example for mllib isotonic regression
      
      add data/mllib/sample_isotonic_regression_libsvm_data.txt
      delete data/mllib/sample_isotonic_regression_data.txt
      ## How was this patch tested?
      
      N/A
      
      Author: WeichenXu <WeichenXu123@outlook.com>
      
      Closes #13381 from WeichenXu123/add_isotonic_regression_doc.
      9040d83b
    • Dongjoon Hyun's avatar
      [SPARK-15996][R] Fix R examples by removing deprecated functions · a865f6e0
      Dongjoon Hyun authored
      ## What changes were proposed in this pull request?
      
      Currently, R examples(`dataframe.R` and `data-manipulation.R`) fail like the following. We had better update them before releasing 2.0 RC. This PR updates them to use up-to-date APIs.
      
      ```bash
      $ bin/spark-submit examples/src/main/r/dataframe.R
      ...
      Warning message:
      'createDataFrame(sqlContext...)' is deprecated.
      Use 'createDataFrame(data, schema = NULL, samplingRatio = 1.0)' instead.
      See help("Deprecated")
      ...
      Warning message:
      'read.json(sqlContext...)' is deprecated.
      Use 'read.json(path)' instead.
      See help("Deprecated")
      ...
      Error: could not find function "registerTempTable"
      Execution halted
      ```
      
      ## How was this patch tested?
      
      Manual.
      ```
      curl -LO http://s3-us-west-2.amazonaws.com/sparkr-data/flights.csv
      bin/spark-submit examples/src/main/r/dataframe.R
      bin/spark-submit examples/src/main/r/data-manipulation.R flights.csv
      ```
      
      Author: Dongjoon Hyun <dongjoon@apache.org>
      
      Closes #13714 from dongjoon-hyun/SPARK-15996.
      a865f6e0
  21. Jun 12, 2016
  22. Jun 10, 2016
    • hyukjinkwon's avatar
      [SPARK-14615][ML][FOLLOWUP] Fix Python examples to use the new ML Vector and... · 99f3c827
      hyukjinkwon authored
      [SPARK-14615][ML][FOLLOWUP] Fix Python examples to use the new ML Vector and Matrix APIs in the ML pipeline based algorithms
      
      ## What changes were proposed in this pull request?
      
      This PR fixes Python examples to use the new ML Vector and Matrix APIs in the ML pipeline based algorithms.
      
      I firstly executed this shell command, `grep -r "from pyspark.mllib" .` and then executed them all.
      Some of tests in `ml` produced the error messages as below:
      
      ```
      pyspark.sql.utils.IllegalArgumentException: u'requirement failed: Input type must be VectorUDT but got org.apache.spark.mllib.linalg.VectorUDTf71b0bce.'
      ```
      
      So, I fixed them to use new ones just identically with some Python tests fixed in https://github.com/apache/spark/pull/12627
      
      ## How was this patch tested?
      
      Manually tested for all the examples listed by `grep -r "from pyspark.mllib" .`.
      
      Author: hyukjinkwon <gurwls223@gmail.com>
      
      Closes #13393 from HyukjinKwon/SPARK-14615.
      99f3c827
    • Dongjoon Hyun's avatar
      [SPARK-15773][CORE][EXAMPLE] Avoid creating local variable `sc` in examples if possible · 2022afe5
      Dongjoon Hyun authored
      ## What changes were proposed in this pull request?
      
      Instead of using local variable `sc` like the following example, this PR uses `spark.sparkContext`. This makes examples more concise, and also fixes some misleading, i.e., creating SparkContext from SparkSession.
      ```
      -    println("Creating SparkContext")
      -    val sc = spark.sparkContext
      -
           println("Writing local file to DFS")
           val dfsFilename = dfsDirPath + "/dfs_read_write_test"
      -    val fileRDD = sc.parallelize(fileContents)
      +    val fileRDD = spark.sparkContext.parallelize(fileContents)
      ```
      
      This will change 12 files (+30 lines, -52 lines).
      
      ## How was this patch tested?
      
      Manual.
      
      Author: Dongjoon Hyun <dongjoon@apache.org>
      
      Closes #13520 from dongjoon-hyun/SPARK-15773.
      2022afe5
  23. Jun 06, 2016
    • Joseph K. Bradley's avatar
      [SPARK-15721][ML] Make DefaultParamsReadable, DefaultParamsWritable public · 4c74ee8d
      Joseph K. Bradley authored
      ## What changes were proposed in this pull request?
      
      Made DefaultParamsReadable, DefaultParamsWritable public.  Also added relevant doc and annotations.  Added UnaryTransformerExample to demonstrate use of UnaryTransformer and DefaultParamsReadable,Writable.
      
      ## How was this patch tested?
      
      Wrote example making use of the now-public APIs.  Compiled and ran locally
      
      Author: Joseph K. Bradley <joseph@databricks.com>
      
      Closes #13461 from jkbradley/defaultparamswritable.
      4c74ee8d
    • Yanbo Liang's avatar
      [SPARK-15771][ML][EXAMPLES] Use 'accuracy' rather than 'precision' in many ML examples · a9525282
      Yanbo Liang authored
      ## What changes were proposed in this pull request?
      Since [SPARK-15617](https://issues.apache.org/jira/browse/SPARK-15617) deprecated ```precision``` in ```MulticlassClassificationEvaluator```, many ML examples broken.
      ```python
      pyspark.sql.utils.IllegalArgumentException: u'MulticlassClassificationEvaluator_4c3bb1d73d8cc0cedae6 parameter metricName given invalid value precision.'
      ```
      We should use ```accuracy``` to replace ```precision``` in these examples.
      
      ## How was this patch tested?
      Offline tests.
      
      Author: Yanbo Liang <ybliang8@gmail.com>
      
      Closes #13519 from yanboliang/spark-15771.
      a9525282
  24. Jun 02, 2016
    • Yanbo Liang's avatar
      [SPARK-15605][ML][EXAMPLES] Fix broken ML JavaDeveloperApiExample. · 4fe7c7bd
      Yanbo Liang authored
      ## What changes were proposed in this pull request?
      See [SPARK-15605](https://issues.apache.org/jira/browse/SPARK-15605) for the detail of this bug. This PR fix 2 major bugs in this example:
      * The java example class use Param ```maxIter```, it will fail when calling ```Param.shouldOwn```. We need add a public method which return the ```maxIter``` Object. Because ```Params.params``` use java reflection to list all public method whose return type is ```Param```, and invoke them to get all defined param objects in the instance.
      * The ```uid``` member defined in Java class will be initialized after Scala traits such as ```HasFeaturesCol```. So when ```HasFeaturesCol``` being constructed, they get ```uid``` with null, which will cause ```Param.shouldOwn``` check fail.
      
      so, here is my changes:
      * Add public method:
      ```public IntParam getMaxIterParam() {return maxIter;}```
      
      * Use Java anonymous class overriding ```uid()``` to defined the ```uid```, and it solve the second problem described above.
      * To make the ```getMaxIterParam ``` can be invoked using java reflection, we must make the two class (MyJavaLogisticRegression and MyJavaLogisticRegressionModel) public. so I make them become inner public static class.
      
      ## How was this patch tested?
      Offline tests.
      
      Author: Yanbo Liang <ybliang8@gmail.com>
      
      Closes #13353 from yanboliang/spark-15605.
      4fe7c7bd
    • Liwei Lin's avatar
      [SPARK-15208][WIP][CORE][STREAMING][DOCS] Update Spark examples with AccumulatorV2 · a0eec8e8
      Liwei Lin authored
      ## What changes were proposed in this pull request?
      
      The patch updates the codes & docs in the example module as well as the related doc module:
      
      - [ ] [docs] `streaming-programming-guide.md`
        - [x] scala code part
        - [ ] java code part
        - [ ] python code part
      - [x] [examples] `RecoverableNetworkWordCount.scala`
      - [ ] [examples] `JavaRecoverableNetworkWordCount.java`
      - [ ] [examples] `recoverable_network_wordcount.py`
      
      ## How was this patch tested?
      
      Ran the examples and verified results manually.
      
      Author: Liwei Lin <lwlin7@gmail.com>
      
      Closes #12981 from lw-lin/accumulatorV2-examples.
      a0eec8e8
Loading