Skip to content
Snippets Groups Projects
  1. Dec 05, 2016
    • Michael Allman's avatar
      [SPARK-18572][SQL] Add a method `listPartitionNames` to `ExternalCatalog` · 772ddbea
      Michael Allman authored
      (Link to Jira issue: https://issues.apache.org/jira/browse/SPARK-18572)
      
      ## What changes were proposed in this pull request?
      
      Currently Spark answers the `SHOW PARTITIONS` command by fetching all of the table's partition metadata from the external catalog and constructing partition names therefrom. The Hive client has a `getPartitionNames` method which is many times faster for this purpose, with the performance improvement scaling with the number of partitions in a table.
      
      To test the performance impact of this PR, I ran the `SHOW PARTITIONS` command on two Hive tables with large numbers of partitions. One table has ~17,800 partitions, and the other has ~95,000 partitions. For the purposes of this PR, I'll call the former table `table1` and the latter table `table2`. I ran 5 trials for each table with before-and-after versions of this PR. The results are as follows:
      
      Spark at bdc8153e, `SHOW PARTITIONS table1`, times in seconds:
      7.901
      3.983
      4.018
      4.331
      4.261
      
      Spark at bdc8153e, `SHOW PARTITIONS table2`
      (Timed out after 10 minutes with a `SocketTimeoutException`.)
      
      Spark at this PR, `SHOW PARTITIONS table1`, times in seconds:
      3.801
      0.449
      0.395
      0.348
      0.336
      
      Spark at this PR, `SHOW PARTITIONS table2`, times in seconds:
      5.184
      1.63
      1.474
      1.519
      1.41
      
      Taking the best times from each trial, we get a 12x performance improvement for a table with ~17,800 partitions and at least a 426x improvement for a table with ~95,000 partitions. More significantly, the latter command doesn't even complete with the current code in master.
      
      This is actually a patch we've been using in-house at VideoAmp since Spark 1.1. It's made all the difference in the practical usability of our largest tables. Even with tables with about 1,000 partitions there's a performance improvement of about 2-3x.
      
      ## How was this patch tested?
      
      I added a unit test to `VersionsSuite` which tests that the Hive client's `getPartitionNames` method returns the correct number of partitions.
      
      Author: Michael Allman <michael@videoamp.com>
      
      Closes #15998 from mallman/spark-18572-list_partition_names.
      772ddbea
    • Shixiong Zhu's avatar
      [SPARK-18722][SS] Move no data rate limit from StreamExecution to ProgressReporter · 4af142f5
      Shixiong Zhu authored
      ## What changes were proposed in this pull request?
      
      Move no data rate limit from StreamExecution to ProgressReporter to make `recentProgresses` and listener events consistent.
      
      ## How was this patch tested?
      
      Jenkins
      
      Author: Shixiong Zhu <shixiong@databricks.com>
      
      Closes #16155 from zsxwing/SPARK-18722.
      4af142f5
    • root's avatar
      [SPARK-18555][SQL] DataFrameNaFunctions.fill miss up original values in long integers · 508de38c
      root authored
      ## What changes were proposed in this pull request?
      
         DataSet.na.fill(0) used on a DataSet which has a long value column, it will change the original long value.
      
         The reason is that the type of the function fill's param is Double, and the numeric columns are always cast to double(`fillCol[Double](f, value)`) .
      ```
        def fill(value: Double, cols: Seq[String]): DataFrame = {
          val columnEquals = df.sparkSession.sessionState.analyzer.resolver
          val projections = df.schema.fields.map { f =>
            // Only fill if the column is part of the cols list.
            if (f.dataType.isInstanceOf[NumericType] && cols.exists(col => columnEquals(f.name, col))) {
              fillCol[Double](f, value)
            } else {
              df.col(f.name)
            }
          }
          df.select(projections : _*)
        }
      ```
      
       For example:
      ```
      scala> val df = Seq[(Long, Long)]((1, 2), (-1, -2), (9123146099426677101L, 9123146560113991650L)).toDF("a", "b")
      df: org.apache.spark.sql.DataFrame = [a: bigint, b: bigint]
      
      scala> df.show
      +-------------------+-------------------+
      |                  a|                  b|
      +-------------------+-------------------+
      |                  1|                  2|
      |                 -1|                 -2|
      |9123146099426677101|9123146560113991650|
      +-------------------+-------------------+
      
      scala> df.na.fill(0).show
      +-------------------+-------------------+
      |                  a|                  b|
      +-------------------+-------------------+
      |                  1|                  2|
      |                 -1|                 -2|
      |9123146099426676736|9123146560113991680|
      +-------------------+-------------------+
       ```
      
      the original values changed [which is not we expected result]:
      ```
       9123146099426677101 -> 9123146099426676736
       9123146560113991650 -> 9123146560113991680
      ```
      
      ## How was this patch tested?
      
      unit test added.
      
      Author: root <root@iZbp1gsnrlfzjxh82cz80vZ.(none)>
      
      Closes #15994 from windpiger/nafillMissupOriginalValue.
      508de38c
    • gatorsmile's avatar
      [SPARK-18720][SQL][MINOR] Code Refactoring of withColumn · 2398fde4
      gatorsmile authored
      ### What changes were proposed in this pull request?
      Our existing withColumn for adding metadata can simply use the existing public withColumn API.
      
      ### How was this patch tested?
      The existing test cases cover it.
      
      Author: gatorsmile <gatorsmile@gmail.com>
      
      Closes #16152 from gatorsmile/withColumnRefactoring.
      2398fde4
    • Tathagata Das's avatar
      [SPARK-18657][SPARK-18668] Make StreamingQuery.id persists across restart and... · bb57bfe9
      Tathagata Das authored
      [SPARK-18657][SPARK-18668] Make StreamingQuery.id persists across restart and not auto-generate StreamingQuery.name
      
      ## What changes were proposed in this pull request?
      Here are the major changes in this PR.
      - Added the ability to recover `StreamingQuery.id` from checkpoint location, by writing the id to `checkpointLoc/metadata`.
      - Added `StreamingQuery.runId` which is unique for every query started and does not persist across restarts. This is to identify each restart of a query separately (same as earlier behavior of `id`).
      - Removed auto-generation of `StreamingQuery.name`. The purpose of name was to have the ability to define an identifier across restarts, but since id is precisely that, there is no need for a auto-generated name. This means name becomes purely cosmetic, and is null by default.
      - Added `runId` to `StreamingQueryListener` events and `StreamingQueryProgress`.
      
      Implementation details
      - Renamed existing `StreamExecutionMetadata` to `OffsetSeqMetadata`, and moved it to the file `OffsetSeq.scala`, because that is what this metadata is tied to. Also did some refactoring to make the code cleaner (got rid of a lot of `.json` and `.getOrElse("{}")`).
      - Added the `id` as the new `StreamMetadata`.
      - When a StreamingQuery is created it gets or writes the `StreamMetadata` from `checkpointLoc/metadata`.
      - All internal logging in `StreamExecution` uses `(name, id, runId)` instead of just `name`
      
      TODO
      - [x] Test handling of name=null in json generation of StreamingQueryProgress
      - [x] Test handling of name=null in json generation of StreamingQueryListener events
      - [x] Test python API of runId
      
      ## How was this patch tested?
      Updated unit tests and new unit tests
      
      Author: Tathagata Das <tathagata.das1565@gmail.com>
      
      Closes #16113 from tdas/SPARK-18657.
      bb57bfe9
    • Shixiong Zhu's avatar
      [SPARK-18729][SS] Move DataFrame.collect out of synchronized block in MemorySink · 1b2785c3
      Shixiong Zhu authored
      ## What changes were proposed in this pull request?
      
      Move DataFrame.collect out of synchronized block so that we can query content in MemorySink when `DataFrame.collect` is running.
      
      ## How was this patch tested?
      
      Jenkins
      
      Author: Shixiong Zhu <shixiong@databricks.com>
      
      Closes #16162 from zsxwing/SPARK-18729.
      1b2785c3
    • Liang-Chi Hsieh's avatar
      [SPARK-18634][PYSPARK][SQL] Corruption and Correctness issues with exploding Python UDFs · 3ba69b64
      Liang-Chi Hsieh authored
      ## What changes were proposed in this pull request?
      
      As reported in the Jira, there are some weird issues with exploding Python UDFs in SparkSQL.
      
      The following test code can reproduce it. Notice: the following test code is reported to return wrong results in the Jira. However, as I tested on master branch, it causes exception and so can't return any result.
      
          >>> from pyspark.sql.functions import *
          >>> from pyspark.sql.types import *
          >>>
          >>> df = spark.range(10)
          >>>
          >>> def return_range(value):
          ...   return [(i, str(i)) for i in range(value - 1, value + 1)]
          ...
          >>> range_udf = udf(return_range, ArrayType(StructType([StructField("integer_val", IntegerType()),
          ...                                                     StructField("string_val", StringType())])))
          >>>
          >>> df.select("id", explode(range_udf(df.id))).show()
          Traceback (most recent call last):
            File "<stdin>", line 1, in <module>
            File "/spark/python/pyspark/sql/dataframe.py", line 318, in show
              print(self._jdf.showString(n, 20))
            File "/spark/python/lib/py4j-0.10.4-src.zip/py4j/java_gateway.py", line 1133, in __call__
            File "/spark/python/pyspark/sql/utils.py", line 63, in deco
              return f(*a, **kw)
            File "/spark/python/lib/py4j-0.10.4-src.zip/py4j/protocol.py", line 319, in get_return_value py4j.protocol.Py4JJavaError: An error occurred while calling o126.showString.: java.lang.AssertionError: assertion failed
              at scala.Predef$.assert(Predef.scala:156)
              at org.apache.spark.sql.execution.CodegenSupport$class.consume(WholeStageCodegenExec.scala:120)
              at org.apache.spark.sql.execution.GenerateExec.consume(GenerateExec.scala:57)
      
      The cause of this issue is, in `ExtractPythonUDFs` we insert `BatchEvalPythonExec` to run PythonUDFs in batch. `BatchEvalPythonExec` will add extra outputs (e.g., `pythonUDF0`) to original plan. In above case, the original `Range` only has one output `id`. After `ExtractPythonUDFs`, the added `BatchEvalPythonExec` has two outputs `id` and `pythonUDF0`.
      
      Because the output of `GenerateExec` is given after analysis phase, in above case, it is the combination of `id`, i.e., the output of `Range`, and `col`. But in planning phase, we change `GenerateExec`'s child plan to `BatchEvalPythonExec` with additional output attributes.
      
      It will cause no problem in non wholestage codegen. Because when evaluating the additional attributes are projected out the final output of `GenerateExec`.
      
      However, as `GenerateExec` now supports wholestage codegen, the framework will input all the outputs of the child plan to `GenerateExec`. Then when consuming `GenerateExec`'s output data (i.e., calling `consume`), the number of output attributes is different to the output variables in wholestage codegen.
      
      To solve this issue, this patch only gives the generator's output to `GenerateExec` after analysis phase. `GenerateExec`'s output is the combination of its child plan's output and the generator's output. So when we change `GenerateExec`'s child, its output is still correct.
      
      ## How was this patch tested?
      
      Added test cases to PySpark.
      
      Please review http://spark.apache.org/contributing.html before opening a pull request.
      
      Author: Liang-Chi Hsieh <viirya@gmail.com>
      
      Closes #16120 from viirya/fix-py-udf-with-generator.
      3ba69b64
    • Nicholas Chammas's avatar
      [SPARK-18719] Add spark.ui.showConsoleProgress to configuration docs · 18eaabb7
      Nicholas Chammas authored
      This PR adds `spark.ui.showConsoleProgress` to the configuration docs.
      
      I tested this PR by building the docs locally and confirming that this change shows up as expected.
      
      Relates to #3029.
      
      Author: Nicholas Chammas <nicholas.chammas@gmail.com>
      
      Closes #16151 from nchammas/ui-progressbar-doc.
      18eaabb7
    • Nicholas Chammas's avatar
      [DOCS][MINOR] Update location of Spark YARN shuffle jar · 5a92dc76
      Nicholas Chammas authored
      Looking at the distributions provided on spark.apache.org, I see that the Spark YARN shuffle jar is under `yarn/` and not `lib/`.
      
      This change is so minor I'm not sure it needs a JIRA. But let me know if so and I'll create one.
      
      Author: Nicholas Chammas <nicholas.chammas@gmail.com>
      
      Closes #16130 from nchammas/yarn-doc-fix.
      5a92dc76
    • Wenchen Fan's avatar
      [SPARK-18711][SQL] should disable subexpression elimination for LambdaVariable · 01a7d33d
      Wenchen Fan authored
      ## What changes were proposed in this pull request?
      
      This is kind of a long-standing bug, it's hidden until https://github.com/apache/spark/pull/15780 , which may add `AssertNotNull` on top of `LambdaVariable` and thus enables subexpression elimination.
      
      However, subexpression elimination will evaluate the common expressions at the beginning, which is invalid for `LambdaVariable`. `LambdaVariable` usually represents loop variable, which can't be evaluated ahead of the loop.
      
      This PR skips expressions containing `LambdaVariable` when doing subexpression elimination.
      
      ## How was this patch tested?
      
      updated test in `DatasetAggregatorSuite`
      
      Author: Wenchen Fan <wenchen@databricks.com>
      
      Closes #16143 from cloud-fan/aggregator.
      01a7d33d
    • Shixiong Zhu's avatar
      [SPARK-18694][SS] Add StreamingQuery.explain and exception to Python and fix... · 24601285
      Shixiong Zhu authored
      [SPARK-18694][SS] Add StreamingQuery.explain and exception to Python and fix StreamingQueryException
      
      ## What changes were proposed in this pull request?
      
      - Add StreamingQuery.explain and exception to Python.
      - Fix StreamingQueryException to not expose `OffsetSeq`.
      
      ## How was this patch tested?
      
      Jenkins
      
      Author: Shixiong Zhu <shixiong@databricks.com>
      
      Closes #16125 from zsxwing/py-streaming-explain.
      24601285
    • Dongjoon Hyun's avatar
      [MINOR][DOC] Use SparkR `TRUE` value and add default values for `StructField` in SQL Guide. · 410b7898
      Dongjoon Hyun authored
      ## What changes were proposed in this pull request?
      
      In `SQL Programming Guide`, this PR uses `TRUE` instead of `True` in SparkR and adds default values of `nullable` for `StructField` in Scala/Python/R (i.e., "Note: The default value of nullable is true."). In Java API, `nullable` is not optional.
      
      **BEFORE**
      * SPARK 2.1.0 RC1
      http://people.apache.org/~pwendell/spark-releases/spark-2.1.0-rc1-docs/sql-programming-guide.html#data-types
      
      **AFTER**
      
      * R
      <img width="916" alt="screen shot 2016-12-04 at 11 58 19 pm" src="https://cloud.githubusercontent.com/assets/9700541/20877443/abba19a6-ba7d-11e6-8984-afbe00333fb0.png">
      
      * Scala
      <img width="914" alt="screen shot 2016-12-04 at 11 57 37 pm" src="https://cloud.githubusercontent.com/assets/9700541/20877433/99ce734a-ba7d-11e6-8bb5-e8619041b09b.png">
      
      * Python
      <img width="914" alt="screen shot 2016-12-04 at 11 58 04 pm" src="https://cloud.githubusercontent.com/assets/9700541/20877440/a5c89338-ba7d-11e6-8f92-6c0ae9388d7e.png">
      
      ## How was this patch tested?
      
      Manual.
      
      ```
      cd docs
      SKIP_API=1 jekyll build
      open _site/index.html
      ```
      
      Author: Dongjoon Hyun <dongjoon@apache.org>
      
      Closes #16141 from dongjoon-hyun/SPARK-SQL-GUIDE.
      410b7898
    • Yanbo Liang's avatar
      [SPARK-18279][DOC][ML][SPARKR] Add R examples to ML programming guide. · eb8dd681
      Yanbo Liang authored
      ## What changes were proposed in this pull request?
      Add R examples to ML programming guide for the following algorithms as POC:
      * spark.glm
      * spark.survreg
      * spark.naiveBayes
      * spark.kmeans
      
      The four algorithms were added to SparkR since 2.0.0, more docs for algorithms added during 2.1 release cycle will be addressed in a separate follow-up PR.
      
      ## How was this patch tested?
      This is the screenshots of generated ML programming guide for ```GeneralizedLinearRegression```:
      ![image](https://cloud.githubusercontent.com/assets/1962026/20866403/babad856-b9e1-11e6-9984-62747801e8c4.png)
      
      Author: Yanbo Liang <ybliang8@gmail.com>
      
      Closes #16136 from yanboliang/spark-18279.
      eb8dd681
    • Zheng RuiFeng's avatar
      [SPARK-18625][ML] OneVsRestModel should support setFeaturesCol and setPredictionCol · bdfe7f67
      Zheng RuiFeng authored
      ## What changes were proposed in this pull request?
      add `setFeaturesCol` and `setPredictionCol` for `OneVsRestModel`
      
      ## How was this patch tested?
      added tests
      
      Author: Zheng RuiFeng <ruifengz@foxmail.com>
      
      Closes #16059 from zhengruifeng/ovrm_setCol.
      bdfe7f67
  2. Dec 04, 2016
    • Reynold Xin's avatar
      [SPARK-18702][SQL] input_file_block_start and input_file_block_length · e9730b70
      Reynold Xin authored
      ## What changes were proposed in this pull request?
      We currently have function input_file_name to get the path of the input file, but don't have functions to get the block start offset and length. This patch introduces two functions:
      
      1. input_file_block_start: returns the file block start offset, or -1 if not available.
      
      2. input_file_block_length: returns the file block length, or -1 if not available.
      
      ## How was this patch tested?
      Updated existing test cases in ColumnExpressionSuite that covered input_file_name to also cover the two new functions.
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #16133 from rxin/SPARK-18702.
      e9730b70
    • Felix Cheung's avatar
      [SPARK-18643][SPARKR] SparkR hangs at session start when installed as a package without Spark · b019b3a8
      Felix Cheung authored
      ## What changes were proposed in this pull request?
      
      If SparkR is running as a package and it has previously downloaded Spark Jar it should be able to run as before without having to set SPARK_HOME. Basically with this bug the auto install Spark will only work in the first session.
      
      This seems to be a regression on the earlier behavior.
      
      Fix is to always try to install or check for the cached Spark if running in an interactive session.
      As discussed before, we should probably only install Spark iff running in an interactive session (R shell, RStudio etc)
      
      ## How was this patch tested?
      
      Manually
      
      Author: Felix Cheung <felixcheung_m@hotmail.com>
      
      Closes #16077 from felixcheung/rsessioninteractive.
      b019b3a8
    • Eric Liang's avatar
      [SPARK-18661][SQL] Creating a partitioned datasource table should not scan all files for table · d9eb4c72
      Eric Liang authored
      ## What changes were proposed in this pull request?
      
      Even though in 2.1 creating a partitioned datasource table will not populate the partition data by default (until the user issues MSCK REPAIR TABLE), it seems we still scan the filesystem for no good reason.
      
      We should avoid doing this when the user specifies a schema.
      
      ## How was this patch tested?
      
      Perf stat tests.
      
      Author: Eric Liang <ekl@databricks.com>
      
      Closes #16090 from ericl/spark-18661.
      d9eb4c72
    • Kapil Singh's avatar
      [SPARK-18091][SQL] Deep if expressions cause Generated... · e463678b
      Kapil Singh authored
      [SPARK-18091][SQL] Deep if expressions cause Generated SpecificUnsafeProjection code to exceed JVM code size limit
      
      ## What changes were proposed in this pull request?
      
      Fix for SPARK-18091 which is a bug related to large if expressions causing generated SpecificUnsafeProjection code to exceed JVM code size limit.
      
      This PR changes if expression's code generation to place its predicate, true value and false value expressions' generated code in separate methods in context so as to never generate too long combined code.
      ## How was this patch tested?
      
      Added a unit test and also tested manually with the application (having transformations similar to the unit test) which caused the issue to be identified in the first place.
      
      Author: Kapil Singh <kapsingh@adobe.com>
      
      Closes #15620 from kapilsingh5050/SPARK-18091-IfCodegenFix.
      e463678b
  3. Dec 03, 2016
    • linbojin's avatar
      [MINOR][README] Correct Markdown link inside readme · edb0ad9d
      linbojin authored
      ## What changes were proposed in this pull request?
      
      "Useful Developer Tools" link inside [README.md](https://github.com/apache/spark/blob/master/README.md#building-spark) doesn't work on master branch. This pr corrects this Markdown link.
      
      ## How was this patch tested?
      
      [README.md](https://github.com/linbojin/spark/blob/fix-markdown-link-in-readme/README.md#building-spark) on this branch
      ![image](https://cloud.githubusercontent.com/assets/5894707/20864124/4c83499e-ba1e-11e6-9948-07b4627f516f.png)
      
      srowen
      
      Author: linbojin <linbojin203@gmail.com>
      
      Closes #16132 from linbojin/fix-markdown-link-in-readme.
      edb0ad9d
    • Yunni's avatar
      [SPARK-18081][ML][DOCS] Add user guide for Locality Sensitive Hashing(LSH) · 34777184
      Yunni authored
      ## What changes were proposed in this pull request?
      The user guide for LSH is added to ml-features.md, with several scala/java examples in spark-examples.
      
      ## How was this patch tested?
      Doc has been generated through Jekyll, and checked through manual inspection.
      
      Author: Yunni <Euler57721@gmail.com>
      Author: Yun Ni <yunn@uber.com>
      Author: Joseph K. Bradley <joseph@databricks.com>
      Author: Yun Ni <Euler57721@gmail.com>
      
      Closes #15795 from Yunni/SPARK-18081-lsh-guide.
      34777184
    • Nattavut Sutyanyong's avatar
      [SPARK-18582][SQL] Whitelist LogicalPlan operators allowed in correlated subqueries · 4a3c0960
      Nattavut Sutyanyong authored
      ## What changes were proposed in this pull request?
      
      This fix puts an explicit list of operators that Spark supports for correlated subqueries.
      
      ## How was this patch tested?
      
      Run sql/test, catalyst/test and add a new test case on Generate.
      
      Author: Nattavut Sutyanyong <nsy.can@gmail.com>
      
      Closes #16046 from nsyca/spark18455.0.
      4a3c0960
    • Weiqing Yang's avatar
      [SPARK-18638][BUILD] Upgrade sbt, Zinc, and Maven plugins · 57619732
      Weiqing Yang authored
      ## What changes were proposed in this pull request?
      This PR is to upgrade:
      ```
         sbt: 0.13.11 -> 0.13.13,
         zinc: 0.3.9 -> 0.3.11,
         maven-assembly-plugin: 2.6 -> 3.0.0
         maven-compiler-plugin: 3.5.1 -> 3.6.
         maven-jar-plugin: 2.6 -> 3.0.2
         maven-javadoc-plugin: 2.10.3 -> 2.10.4
         maven-source-plugin: 2.4 -> 3.0.1
         org.codehaus.mojo:build-helper-maven-plugin: 1.10 -> 1.12
         org.codehaus.mojo:exec-maven-plugin: 1.4.0 -> 1.5.0
      ```
      
      The sbt release notes since the last version we used are: [v0.13.12](https://github.com/sbt/sbt/releases/tag/v0.13.12)  and [v0.13.13 ](https://github.com/sbt/sbt/releases/tag/v0.13.13).
      
      ## How was this patch tested?
      Pass build and the existing tests.
      
      Author: Weiqing Yang <yangweiqing001@gmail.com>
      
      Closes #16069 from weiqingy/SPARK-18638.
      Unverified
      57619732
    • hyukjinkwon's avatar
      [SPARK-18685][TESTS] Fix URI and release resources after opening in tests at... · d1312fb7
      hyukjinkwon authored
      [SPARK-18685][TESTS] Fix URI and release resources after opening in tests at ExecutorClassLoaderSuite
      
      ## What changes were proposed in this pull request?
      
      This PR fixes two problems as below:
      
      - Close `BufferedSource` after `Source.fromInputStream(...)` to release resource and make the tests pass on Windows in `ExecutorClassLoaderSuite`
      
        ```
        [info] Exception encountered when attempting to run a suite with class name: org.apache.spark.repl.ExecutorClassLoaderSuite *** ABORTED *** (7 seconds, 333 milliseconds)
        [info]   java.io.IOException: Failed to delete: C:\projects\spark\target\tmp\spark-77b2f37b-6405-47c4-af1c-4a6a206511f2
        [info]   at org.apache.spark.util.Utils$.deleteRecursively(Utils.scala:1010)
        [info]   at org.apache.spark.repl.ExecutorClassLoaderSuite.afterAll(ExecutorClassLoaderSuite.scala:76)
        [info]   at org.scalatest.BeforeAndAfterAll$class.afterAll(BeforeAndAfterAll.scala:213)
        ...
        ```
      
      - Fix URI correctly so that related tests can be passed on Windows.
      
        ```
        [info] - child first *** FAILED *** (78 milliseconds)
        [info]   java.net.URISyntaxException: Illegal character in authority at index 7: file://C:\projects\spark\target\tmp\spark-00b66070-0548-463c-b6f3-8965d173da9b
        [info]   at java.net.URI$Parser.fail(URI.java:2848)
        [info]   at java.net.URI$Parser.parseAuthority(URI.java:3186)
        ...
        [info] - parent first *** FAILED *** (15 milliseconds)
        [info]   java.net.URISyntaxException: Illegal character in authority at index 7: file://C:\projects\spark\target\tmp\spark-00b66070-0548-463c-b6f3-8965d173da9b
        [info]   at java.net.URI$Parser.fail(URI.java:2848)
        [info]   at java.net.URI$Parser.parseAuthority(URI.java:3186)
        ...
        [info] - child first can fall back *** FAILED *** (0 milliseconds)
        [info]   java.net.URISyntaxException: Illegal character in authority at index 7: file://C:\projects\spark\target\tmp\spark-00b66070-0548-463c-b6f3-8965d173da9b
        [info]   at java.net.URI$Parser.fail(URI.java:2848)
        [info]   at java.net.URI$Parser.parseAuthority(URI.java:3186)
        ...
        [info] - child first can fail *** FAILED *** (0 milliseconds)
        [info]   java.net.URISyntaxException: Illegal character in authority at index 7: file://C:\projects\spark\target\tmp\spark-00b66070-0548-463c-b6f3-8965d173da9b
        [info]   at java.net.URI$Parser.fail(URI.java:2848)
        [info]   at java.net.URI$Parser.parseAuthority(URI.java:3186)
        ...
        [info] - resource from parent *** FAILED *** (0 milliseconds)
        [info]   java.net.URISyntaxException: Illegal character in authority at index 7: file://C:\projects\spark\target\tmp\spark-00b66070-0548-463c-b6f3-8965d173da9b
        [info]   at java.net.URI$Parser.fail(URI.java:2848)
        [info]   at java.net.URI$Parser.parseAuthority(URI.java:3186)
        ...
        [info] - resources from parent *** FAILED *** (0 milliseconds)
        [info]   java.net.URISyntaxException: Illegal character in authority at index 7: file://C:\projects\spark\target\tmp\spark-00b66070-0548-463c-b6f3-8965d173da9b
        [info]   at java.net.URI$Parser.fail(URI.java:2848)
        [info]   at java.net.URI$Parser.parseAuthority(URI.java:3186)
        ```
      
      ## How was this patch tested?
      
      Manually tested via AppVeyor.
      
      **Before**
      https://ci.appveyor.com/project/spark-test/spark/build/102-rpel-ExecutorClassLoaderSuite
      
      **After**
      https://ci.appveyor.com/project/spark-test/spark/build/108-rpel-ExecutorClassLoaderSuite
      
      Author: hyukjinkwon <gurwls223@gmail.com>
      
      Closes #16116 from HyukjinKwon/close-after-open.
      Unverified
      d1312fb7
    • Sean Owen's avatar
      [SPARK-18586][BUILD] netty-3.8.0.Final.jar has vulnerability CVE-2014-3488 and CVE-2014-0193 · 553aac56
      Sean Owen authored
      ## What changes were proposed in this pull request?
      
      Force update to latest Netty 3.9.x, for dependencies like Flume, to resolve two CVEs. 3.9.2 is the first version that resolves both, and, this is the latest in the 3.9.x line.
      
      ## How was this patch tested?
      
      Existing tests
      
      Author: Sean Owen <sowen@cloudera.com>
      
      Closes #16102 from srowen/SPARK-18586.
      Unverified
      553aac56
  4. Dec 02, 2016
    • Josh Rosen's avatar
      [SPARK-18362][SQL] Use TextFileFormat in implementation of CSVFileFormat · 7c33b0fd
      Josh Rosen authored
      ## What changes were proposed in this pull request?
      
      This patch significantly improves the IO / file listing performance of schema inference in Spark's built-in CSV data source.
      
      Previously, this data source used the legacy `SparkContext.hadoopFile` and `SparkContext.hadoopRDD` methods to read files during its schema inference step, causing huge file-listing bottlenecks on the driver.
      
      This patch refactors this logic to use Spark SQL's `text` data source to read files during this step. The text data source still performs some unnecessary file listing (since in theory we already have resolved the table prior to schema inference and therefore should be able to scan without performing _any_ extra listing), but that listing is much faster and takes place in parallel. In one production workload operating over tens of thousands of files, this change managed to reduce schema inference time from 7 minutes to 2 minutes.
      
      A similar problem also affects the JSON file format and this patch originally fixed that as well, but I've decided to split that change into a separate patch so as not to conflict with changes in another JSON PR.
      
      ## How was this patch tested?
      
      Existing unit tests, plus manual benchmarking on a production workload.
      
      Author: Josh Rosen <joshrosen@databricks.com>
      
      Closes #15813 from JoshRosen/use-text-data-source-in-csv-and-json.
      7c33b0fd
    • Reynold Xin's avatar
      [SPARK-18695] Bump master branch version to 2.2.0-SNAPSHOT · c7c72659
      Reynold Xin authored
      ## What changes were proposed in this pull request?
      This patch bumps master branch version to 2.2.0-SNAPSHOT.
      
      ## How was this patch tested?
      N/A
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #16126 from rxin/SPARK-18695.
      c7c72659
    • zero323's avatar
      [SPARK-18690][PYTHON][SQL] Backward compatibility of unbounded frames · a9cbfc4f
      zero323 authored
      ## What changes were proposed in this pull request?
      
      Makes `Window.unboundedPreceding` and `Window.unboundedFollowing` backward compatible.
      
      ## How was this patch tested?
      
      Pyspark SQL unittests.
      
      Please review http://spark.apache.org/contributing.html before opening a pull request.
      
      Author: zero323 <zero323@users.noreply.github.com>
      
      Closes #16123 from zero323/SPARK-17845-follow-up.
      a9cbfc4f
    • Yanbo Liang's avatar
      [SPARK-18324][ML][DOC] Update ML programming and migration guide for 2.1 release · 2dc0d7ef
      Yanbo Liang authored
      ## What changes were proposed in this pull request?
      Update ML programming and migration guide for 2.1 release.
      
      ## How was this patch tested?
      Doc change, no test.
      
      Author: Yanbo Liang <ybliang8@gmail.com>
      
      Closes #16076 from yanboliang/spark-18324.
      2dc0d7ef
    • Shixiong Zhu's avatar
      [SPARK-18670][SS] Limit the number of... · 56a503df
      Shixiong Zhu authored
      [SPARK-18670][SS] Limit the number of StreamingQueryListener.StreamProgressEvent when there is no data
      
      ## What changes were proposed in this pull request?
      
      This PR adds a sql conf `spark.sql.streaming.noDataReportInterval` to control how long to wait before outputing the next StreamProgressEvent when there is no data.
      
      ## How was this patch tested?
      
      The added unit test.
      
      Author: Shixiong Zhu <shixiong@databricks.com>
      
      Closes #16108 from zsxwing/SPARK-18670.
      56a503df
    • Yanbo Liang's avatar
      [SPARK-18291][SPARKR][ML] Revert "[SPARK-18291][SPARKR][ML] SparkR glm predict... · a985dd8e
      Yanbo Liang authored
      [SPARK-18291][SPARKR][ML] Revert "[SPARK-18291][SPARKR][ML] SparkR glm predict should output original label when family = binomial."
      
      ## What changes were proposed in this pull request?
      It's better we can fix this issue by providing an option ```type``` for users to change the ```predict``` output schema, then they could output probabilities, log-space predictions, or original labels. In order to not involve breaking API change for 2.1, so revert this change firstly and will add it back after [SPARK-18618](https://issues.apache.org/jira/browse/SPARK-18618) resolved.
      
      ## How was this patch tested?
      Existing unit tests.
      
      This reverts commit daa975f4.
      
      Author: Yanbo Liang <ybliang8@gmail.com>
      
      Closes #16118 from yanboliang/spark-18291-revert.
      a985dd8e
    • Ryan Blue's avatar
      [SPARK-18677] Fix parsing ['key'] in JSON path expressions. · 48778976
      Ryan Blue authored
      ## What changes were proposed in this pull request?
      
      This fixes the parser rule to match named expressions, which doesn't work for two reasons:
      1. The name match is not coerced to a regular expression (missing .r)
      2. The surrounding literals are incorrect and attempt to escape a single quote, which is unnecessary
      
      ## How was this patch tested?
      
      This adds test cases for named expressions using the bracket syntax, including one with quoted spaces.
      
      Author: Ryan Blue <blue@apache.org>
      
      Closes #16107 from rdblue/SPARK-18677-fix-json-path.
      48778976
    • gatorsmile's avatar
      [SPARK-18674][SQL][FOLLOW-UP] improve the error message of using join · 2f8776cc
      gatorsmile authored
      ### What changes were proposed in this pull request?
      Added a test case for using joins with nested fields.
      
      ### How was this patch tested?
      N/A
      
      Author: gatorsmile <gatorsmile@gmail.com>
      
      Closes #16110 from gatorsmile/followup-18674.
      2f8776cc
    • Eric Liang's avatar
      [SPARK-18659][SQL] Incorrect behaviors in overwrite table for datasource tables · 7935c847
      Eric Liang authored
      ## What changes were proposed in this pull request?
      
      Two bugs are addressed here
      1. INSERT OVERWRITE TABLE sometime crashed when catalog partition management was enabled. This was because when dropping partitions after an overwrite operation, the Hive client will attempt to delete the partition files. If the entire partition directory was dropped, this would fail. The PR fixes this by adding a flag to control whether the Hive client should attempt to delete files.
      2. The static partition spec for OVERWRITE TABLE was not correctly resolved to the case-sensitive original partition names. This resulted in the entire table being overwritten if you did not correctly capitalize your partition names.
      
      cc yhuai cloud-fan
      
      ## How was this patch tested?
      
      Unit tests. Surprisingly, the existing overwrite table tests did not catch these edge cases.
      
      Author: Eric Liang <ekl@databricks.com>
      
      Closes #16088 from ericl/spark-18659.
      7935c847
    • Dongjoon Hyun's avatar
      [SPARK-18419][SQL] `JDBCRelation.insert` should not remove Spark options · 55d528f2
      Dongjoon Hyun authored
      ## What changes were proposed in this pull request?
      
      Currently, `JDBCRelation.insert` removes Spark options too early by mistakenly using `asConnectionProperties`. Spark options like `numPartitions` should be passed into `DataFrameWriter.jdbc` correctly. This bug have been **hidden** because `JDBCOptions.asConnectionProperties` fails to filter out the mixed-case options. This PR aims to fix both.
      
      **JDBCRelation.insert**
      ```scala
      override def insert(data: DataFrame, overwrite: Boolean): Unit = {
        val url = jdbcOptions.url
        val table = jdbcOptions.table
      - val properties = jdbcOptions.asConnectionProperties
      + val properties = jdbcOptions.asProperties
        data.write
          .mode(if (overwrite) SaveMode.Overwrite else SaveMode.Append)
          .jdbc(url, table, properties)
      ```
      
      **JDBCOptions.asConnectionProperties**
      ```scala
      scala> import org.apache.spark.sql.execution.datasources.jdbc.JDBCOptions
      scala> import org.apache.spark.sql.catalyst.util.CaseInsensitiveMap
      scala> new JDBCOptions(Map("url" -> "jdbc:mysql://localhost:3306/temp", "dbtable" -> "t1", "numPartitions" -> "10")).asConnectionProperties
      res0: java.util.Properties = {numpartitions=10}
      scala> new JDBCOptions(new CaseInsensitiveMap(Map("url" -> "jdbc:mysql://localhost:3306/temp", "dbtable" -> "t1", "numPartitions" -> "10"))).asConnectionProperties
      res1: java.util.Properties = {numpartitions=10}
      ```
      
      ## How was this patch tested?
      
      Pass the Jenkins with a new testcase.
      
      Author: Dongjoon Hyun <dongjoon@apache.org>
      
      Closes #15863 from dongjoon-hyun/SPARK-18419.
      55d528f2
    • Eric Liang's avatar
      [SPARK-18679][SQL] Fix regression in file listing performance for non-catalog tables · 294163ee
      Eric Liang authored
      ## What changes were proposed in this pull request?
      
      In Spark 2.1 ListingFileCatalog was significantly refactored (and renamed to InMemoryFileIndex). This introduced a regression where parallelism could only be introduced at the very top of the tree. However, in many cases (e.g. `spark.read.parquet(topLevelDir)`), the top of the tree is only a single directory.
      
      This PR simplifies and fixes the parallel recursive listing code to allow parallelism to be introduced at any level during recursive descent (though note that once we decide to list a sub-tree in parallel, the sub-tree is listed in serial on executors).
      
      cc mallman  cloud-fan
      
      ## How was this patch tested?
      
      Checked metrics in unit tests.
      
      Author: Eric Liang <ekl@databricks.com>
      
      Closes #16112 from ericl/spark-18679.
      294163ee
    • Weiqing Yang's avatar
      [SPARK-18629][SQL] Fix numPartition of JDBCSuite Testcase · 2159bf8b
      Weiqing Yang authored
      ## What changes were proposed in this pull request?
      Fix numPartition of JDBCSuite Testcase.
      
      ## How was this patch tested?
      Before:
      Run any one of the test cases in JDBCSuite, you will get the following warning.
      ```
      10:34:26.389 WARN org.apache.spark.sql.execution.datasources.jdbc.JDBCRelation: The number of partitions is reduced because the specified number of partitions is less than the difference between upper bound and lower bound. Updated number of partitions: 3; Input number of partitions: 4; Lower bound: 1; Upper bound: 4.
      ```
      After: Pass tests without the warning.
      
      Author: Weiqing Yang <yangweiqing001@gmail.com>
      
      Closes #16062 from weiqingy/SPARK-18629.
      Unverified
      2159bf8b
    • Cheng Lian's avatar
      [SPARK-17213][SQL] Disable Parquet filter push-down for string and binary... · ca639163
      Cheng Lian authored
      [SPARK-17213][SQL] Disable Parquet filter push-down for string and binary columns due to PARQUET-686
      
      This PR targets to both master and branch-2.1.
      
      ## What changes were proposed in this pull request?
      
      Due to PARQUET-686, Parquet doesn't do string comparison correctly while doing filter push-down for string columns. This PR disables filter push-down for both string and binary columns to work around this issue. Binary columns are also affected because some Parquet data models (like Hive) may store string columns as a plain Parquet `binary` instead of a `binary (UTF8)`.
      
      ## How was this patch tested?
      
      New test case added in `ParquetFilterSuite`.
      
      Author: Cheng Lian <lian@databricks.com>
      
      Closes #16106 from liancheng/spark-17213-bad-string-ppd.
      ca639163
  5. Dec 01, 2016
    • Nathan Howell's avatar
      [SPARK-18658][SQL] Write text records directly to a FileOutputStream · c82f16c1
      Nathan Howell authored
      ## What changes were proposed in this pull request?
      
      This replaces uses of `TextOutputFormat` with an `OutputStream`, which will either write directly to the filesystem or indirectly via a compressor (if so configured). This avoids intermediate buffering.
      
      The inverse of this (reading directly from a stream) is necessary for streaming large JSON records (when `wholeFile` is enabled) so I wanted to keep the read and write paths symmetric.
      
      ## How was this patch tested?
      
      Existing unit tests.
      
      Author: Nathan Howell <nhowell@godaddy.com>
      
      Closes #16089 from NathanHowell/SPARK-18658.
      c82f16c1
    • Reynold Xin's avatar
      [SPARK-18663][SQL] Simplify CountMinSketch aggregate implementation · d3c90b74
      Reynold Xin authored
      ## What changes were proposed in this pull request?
      SPARK-18429 introduced count-min sketch aggregate function for SQL, but the implementation and testing is more complicated than needed. This simplifies the test cases and removes support for data types that don't have clear equality semantics:
      
      1. Removed support for floating point and decimal types.
      
      2. Removed the heavy randomized tests. The underlying CountMinSketch implementation already had pretty good test coverage through randomized tests, and the SPARK-18429 implementation is just to add an aggregate function wrapper around CountMinSketch. There is no need for randomized tests at three different levels of the implementations.
      
      ## How was this patch tested?
      A lot of the change is to simplify test cases.
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #16093 from rxin/SPARK-18663.
      d3c90b74
    • Wenchen Fan's avatar
      [SPARK-18647][SQL] do not put provider in table properties for Hive serde table · a5f02b00
      Wenchen Fan authored
      ## What changes were proposed in this pull request?
      
      In Spark 2.1, we make Hive serde tables case-preserving by putting the table metadata in table properties, like what we did for data source table. However, we should not put table provider, as it will break forward compatibility. e.g. if we create a Hive serde table with Spark 2.1, using `sql("create table test stored as parquet as select 1")`, we will fail to read it with Spark 2.0, as Spark 2.0 mistakenly treat it as data source table because there is a `provider` entry in table properties.
      
      Logically Hive serde table's provider is always hive, we don't need to store it in table properties, this PR removes it.
      
      ## How was this patch tested?
      
      manually test the forward compatibility issue.
      
      Author: Wenchen Fan <wenchen@databricks.com>
      
      Closes #16080 from cloud-fan/hive.
      a5f02b00
Loading