Skip to content
Snippets Groups Projects
  1. Dec 19, 2018
  2. Dec 05, 2018
  3. Dec 04, 2018
  4. Nov 16, 2018
  5. Nov 07, 2018
  6. Nov 01, 2018
  7. Oct 28, 2018
  8. Oct 25, 2018
    • Alex Ellis (VMware)'s avatar
      Update for scaling edge-case · f5939c9a
      Alex Ellis (VMware) authored
      
      - as reported on Slack and in issue #931 the gateway scaling code
      was scaling to zero replicas as a result of the "proportional
      scaling" added by @Templum's PR. This commit added a failing test
      which was fixed by adding boundary checking - now if the scaling
      amount is "0" we keep the current amount of replicas.
      
      Signed-off-by: default avatarAlex Ellis (VMware) <alexellis2@gmail.com>
      f5939c9a
  9. Oct 20, 2018
    • Richard Gee's avatar
      Add logging to scale from zero requests · 7df54866
      Richard Gee authored
      
      Trivial change to add logging around scale from zero events in scaling.go.
      Previously scale from zero events were not logged in the same way that normal
      scaling events are.  This change adds log writes to show when a scale from zero
      was requested and when a function successfully moved to > 0 replicas.
      
      Signed-off-by: default avatarRichard Gee <richard@technologee.co.uk>
      7df54866
  10. Oct 19, 2018
  11. Oct 03, 2018
    • Alex Ellis's avatar
      Update README files · 7db8ad1b
      Alex Ellis authored
      
      - Removes use of "our" from CONTRIBUTING guide
      - Updates/adds README.md files
      - Commnents and typo fix in watchdog
      - Adds good/bad examples of commit messages
      
      Signed-off-by: default avatarAlex Ellis (VMware) <alexellis2@gmail.com>
      7db8ad1b
    • Alex Ellis's avatar
      Update comments · bd39b926
      Alex Ellis authored
      
      - updates comments and adds where missing
      - updates locks so that unlock is done via defer instead of
      at the end of the statement
      - extracts timeout variable in two places
      - remove makeClient() unused method from metrics package
      
      No-harm changes tested via go build.
      
      Signed-off-by: default avatarAlex Ellis (VMware) <alexellis2@gmail.com>
      bd39b926
  12. Sep 23, 2018
    • Richard Gee's avatar
    • Richard Gee's avatar
      Add checking for existent function in GetReplicas · df6f4c49
      Richard Gee authored
      
      Within MakeScalingHandler() there is a call to GetReplicas() which was not returning an error when a non-200 http response was received from /system/function/.  The call would also return a populated struct, so the perception was that a function existed an had been scaled to zero.  This meant that the function would be added to the function cache and the code would continue into SetReplicas() where an attempt would be made to scale up a non-existent function.
      
      This change amends GetReplicas() so that it will return an error if the gateway returns anything other than a 200 reponse code from the /system/function/ endpoint.  This causes MakeScalingHandler() to return earlier with an error indicating that the function could not be found.  The cache.Set call is also moved to after the error check so that the cache is only updated to include existent functions.
      
      During investigations as to the cause of #876 tests were added to function_cache to check that Get() is behaving as intended when function exists and when not.  Tests are also added to plugin/external to test that GetReplicas() and SetReplicas() are following their intended modes of operation when 200 and non-200 responses are received from the gateway.
      
      Signed-off-by: default avatarRichard Gee <richard@technologee.co.uk>
      df6f4c49
  13. Sep 19, 2018
  14. Sep 15, 2018
    • Alex Ellis (VMware)'s avatar
      Fix issue with direct_functions and path behaviour · c67c9f2b
      Alex Ellis (VMware) authored
      
      - The path clipping / transforming behaviour must be turned-off
      when we are not using direct_functions as is used in
      faas-nomad and faas-ecs. This will need a change in each provider
      to strip paths, but fixes a 404 error these users will see if they
      upgrade to 0.9.2 or newer. 0.9.3 will have a this fix meaning
      the whole un-edited path is passed to the provider when
      direct_functions is set to false.
      
      Signed-off-by: default avatarAlex Ellis (VMware) <alexellis2@gmail.com>
      c67c9f2b
  15. Sep 10, 2018
  16. Sep 08, 2018
  17. Sep 06, 2018
  18. Sep 05, 2018
    • Alex Ellis (VMware)'s avatar
      Refactor #843 · ffd81afd
      Alex Ellis (VMware) authored
      
      Code-review/refactoring for #843. Closes #843.
      
      FaaSHandlers has had info and query handlers added to its list
      of types for consistency.
      
      Secrets added to queue-worker component ready for next PR.
      
      Signed-off-by: default avatarAlex Ellis (VMware) <alexellis2@gmail.com>
      ffd81afd
    • Burton Rheutan's avatar
      Pass basic auth to all system calls · fa076fb2
      Burton Rheutan authored
      
      This changeset enables passing the basic auth credentials
      to all /system/ calls to allow upstream providers to
      perform authorization checks independent of the gateway.
      
      This is essential for some providers, like Swarm, where
      the system is accessible on the same network, and not
      protected via the gateway
      
      Signed-off-by: default avatarBurton Rheutan <rheutan7@gmail.com>
      fa076fb2
  19. Sep 03, 2018
  20. Aug 29, 2018
  21. Aug 24, 2018
Loading