Skip to content
Snippets Groups Projects
Commit 3e0ed5ed authored by Stefan Prodan's avatar Stefan Prodan Committed by Alex Ellis
Browse files

Add X-Forwarded-Host test when already present

parent 3d44fa81
No related branches found
No related tags found
No related merge requests found
......@@ -103,8 +103,6 @@ func forwardRequest(w http.ResponseWriter, r *http.Request, proxyClient *http.Cl
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
log.Printf("Upstream request to: %s, %+v\n", upstreamReq.URL.Path, upstreamReq)
res, resErr := proxyClient.Do(upstreamReq.WithContext(ctx))
if resErr != nil {
badStatus := http.StatusBadGateway
......
......@@ -106,6 +106,24 @@ func Test_buildUpstreamRequest_XForwardedHostHeader_Empty_WhenNotSet(t *testing.
}
}
func Test_buildUpstreamRequest_XForwardedHostHeader_WhenAlreadyPresent(t *testing.T) {
srcBytes := []byte("hello world")
headerValue := "test.openfaas.com"
reader := bytes.NewReader(srcBytes)
request, err := http.NewRequest(http.MethodPost, "/function/test", reader)
if err != nil {
t.Fatal(err)
}
request.Header.Set("X-Forwarded-Host", headerValue)
upstream := buildUpstreamRequest(request, "/", "/")
if upstream.Header.Get("X-Forwarded-Host") != headerValue {
t.Errorf("X-Forwarded-Host - want: %s, got: %s", headerValue, upstream.Header.Get("X-Forwarded-Host"))
}
}
func Test_getServiceName(t *testing.T) {
scenarios := []struct {
name string
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment