Skip to content
Snippets Groups Projects
  1. Oct 20, 2018
  2. Oct 19, 2018
  3. Oct 15, 2018
  4. Oct 13, 2018
  5. Oct 12, 2018
  6. Oct 09, 2018
  7. Oct 04, 2018
  8. Oct 03, 2018
    • Alex Ellis's avatar
      Update README files · 7db8ad1b
      Alex Ellis authored
      
      - Removes use of "our" from CONTRIBUTING guide
      - Updates/adds README.md files
      - Commnents and typo fix in watchdog
      - Adds good/bad examples of commit messages
      
      Signed-off-by: default avatarAlex Ellis (VMware) <alexellis2@gmail.com>
      7db8ad1b
    • Alex Ellis's avatar
      Update comments · bd39b926
      Alex Ellis authored
      
      - updates comments and adds where missing
      - updates locks so that unlock is done via defer instead of
      at the end of the statement
      - extracts timeout variable in two places
      - remove makeClient() unused method from metrics package
      
      No-harm changes tested via go build.
      
      Signed-off-by: default avatarAlex Ellis (VMware) <alexellis2@gmail.com>
      bd39b926
  9. Oct 02, 2018
  10. Sep 30, 2018
  11. Sep 28, 2018
  12. Sep 26, 2018
  13. Sep 25, 2018
  14. Sep 23, 2018
    • Richard Gee's avatar
    • Richard Gee's avatar
      Add checking for existent function in GetReplicas · df6f4c49
      Richard Gee authored
      
      Within MakeScalingHandler() there is a call to GetReplicas() which was not returning an error when a non-200 http response was received from /system/function/.  The call would also return a populated struct, so the perception was that a function existed an had been scaled to zero.  This meant that the function would be added to the function cache and the code would continue into SetReplicas() where an attempt would be made to scale up a non-existent function.
      
      This change amends GetReplicas() so that it will return an error if the gateway returns anything other than a 200 reponse code from the /system/function/ endpoint.  This causes MakeScalingHandler() to return earlier with an error indicating that the function could not be found.  The cache.Set call is also moved to after the error check so that the cache is only updated to include existent functions.
      
      During investigations as to the cause of #876 tests were added to function_cache to check that Get() is behaving as intended when function exists and when not.  Tests are also added to plugin/external to test that GetReplicas() and SetReplicas() are following their intended modes of operation when 200 and non-200 responses are received from the gateway.
      
      Signed-off-by: default avatarRichard Gee <richard@technologee.co.uk>
      df6f4c49
  15. Sep 20, 2018
Loading