diff --git a/gateway/handlers/forwarding_proxy.go b/gateway/handlers/forwarding_proxy.go index 1bc13634758aaa767637ee6f50f21d9b188ab606..345fdcef642e0e85c38260b8496be9207b80b713 100644 --- a/gateway/handlers/forwarding_proxy.go +++ b/gateway/handlers/forwarding_proxy.go @@ -103,8 +103,6 @@ func forwardRequest(w http.ResponseWriter, r *http.Request, proxyClient *http.Cl ctx, cancel := context.WithTimeout(context.Background(), timeout) defer cancel() - log.Printf("Upstream request to: %s, %+v\n", upstreamReq.URL.Path, upstreamReq) - res, resErr := proxyClient.Do(upstreamReq.WithContext(ctx)) if resErr != nil { badStatus := http.StatusBadGateway diff --git a/gateway/handlers/forwarding_proxy_test.go b/gateway/handlers/forwarding_proxy_test.go index b87bcbc7fcf51655b4da8f3c3b1d89a95ac1a31b..c424d18c941ebbe57a43e41deb6422069137a996 100644 --- a/gateway/handlers/forwarding_proxy_test.go +++ b/gateway/handlers/forwarding_proxy_test.go @@ -106,6 +106,24 @@ func Test_buildUpstreamRequest_XForwardedHostHeader_Empty_WhenNotSet(t *testing. } } +func Test_buildUpstreamRequest_XForwardedHostHeader_WhenAlreadyPresent(t *testing.T) { + srcBytes := []byte("hello world") + headerValue := "test.openfaas.com" + reader := bytes.NewReader(srcBytes) + request, err := http.NewRequest(http.MethodPost, "/function/test", reader) + + if err != nil { + t.Fatal(err) + } + + request.Header.Set("X-Forwarded-Host", headerValue) + upstream := buildUpstreamRequest(request, "/", "/") + + if upstream.Header.Get("X-Forwarded-Host") != headerValue { + t.Errorf("X-Forwarded-Host - want: %s, got: %s", headerValue, upstream.Header.Get("X-Forwarded-Host")) + } +} + func Test_getServiceName(t *testing.T) { scenarios := []struct { name string