Skip to content
Snippets Groups Projects
  1. Feb 08, 2016
    • Andrew Or's avatar
      [SPARK-10620][SPARK-13054] Minor addendum to #10835 · eeaf45b9
      Andrew Or authored
      Additional changes to #10835, mainly related to style and visibility. This patch also adds back a few deprecated methods for backward compatibility.
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #10958 from andrewor14/task-metrics-to-accums-followups.
      eeaf45b9
    • Davies Liu's avatar
      [SPARK-13095] [SQL] improve performance for broadcast join with dimension table · ff0af0dd
      Davies Liu authored
      This PR improve the performance for Broadcast join with dimension tables, which is common in data warehouse.
      
      If the join key can fit in a long, we will use a special api `get(Long)` to get the rows from HashedRelation.
      
      If the HashedRelation only have unique keys, we will use a special api `getValue(Long)` or `getValue(InternalRow)`.
      
      If the keys can fit within a long, also the keys are dense, we will use a array of UnsafeRow, instead a hash map.
      
      TODO: will do cleanup
      
      Author: Davies Liu <davies@databricks.com>
      
      Closes #11065 from davies/gen_dim.
      ff0af0dd
    • Davies Liu's avatar
      [SPARK-13210][SQL] catch OOM when allocate memory and expand array · 37bc203c
      Davies Liu authored
      There is a bug when we try to grow the buffer, OOM is ignore wrongly (the assert also skipped by JVM), then we try grow the array again, this one will trigger spilling free the current page, the current record we inserted will be invalid.
      
      The root cause is that JVM has less free memory than MemoryManager thought, it will OOM when allocate a page without trigger spilling. We should catch the OOM, and acquire memory again to trigger spilling.
      
      And also, we could not grow the array in `insertRecord` of `InMemorySorter` (it was there just for easy testing).
      
      Author: Davies Liu <davies@databricks.com>
      
      Closes #11095 from davies/fix_expand.
      37bc203c
    • Wenchen Fan's avatar
      [SPARK-13101][SQL] nullability of array type element should not fail analysis of encoder · 8e4d15f7
      Wenchen Fan authored
      nullability should only be considered as an optimization rather than part of the type system, so instead of failing analysis for mismatch nullability, we should pass analysis and add runtime null check.
      
      Author: Wenchen Fan <wenchen@databricks.com>
      
      Closes #11035 from cloud-fan/ignore-nullability.
      8e4d15f7
    • Josh Rosen's avatar
      [SPARK-8964] [SQL] Use Exchange to perform shuffle in Limit · 06f0df6d
      Josh Rosen authored
      This patch changes the implementation of the physical `Limit` operator so that it relies on the `Exchange` operator to perform data movement rather than directly using `ShuffledRDD`. In addition to improving efficiency, this lays the necessary groundwork for further optimization of limit, such as limit pushdown or whole-stage codegen.
      
      At a high-level, this replaces the old physical `Limit` operator with two new operators, `LocalLimit` and `GlobalLimit`. `LocalLimit` performs per-partition limits, while `GlobalLimit` applies the final limit to a single partition; `GlobalLimit`'s declares that its `requiredInputDistribution` is `SinglePartition`, which will cause the planner to use an `Exchange` to perform the appropriate shuffles. Thus, a logical `Limit` appearing in the middle of a query plan will be expanded into `LocalLimit -> Exchange to one partition -> GlobalLimit`.
      
      In the old code, calling `someDataFrame.limit(100).collect()` or `someDataFrame.take(100)` would actually skip the shuffle and use a fast-path which used `executeTake()` in order to avoid computing all partitions in case only a small number of rows were requested. This patch preserves this optimization by treating logical `Limit` operators specially when they appear as the terminal operator in a query plan: if a `Limit` is the final operator, then we will plan a special `CollectLimit` physical operator which implements the old `take()`-based logic.
      
      In order to be able to match on operators only at the root of the query plan, this patch introduces a special `ReturnAnswer` logical operator which functions similar to `BroadcastHint`: this dummy operator is inserted at the root of the optimized logical plan before invoking the physical planner, allowing the planner to pattern-match on it.
      
      Author: Josh Rosen <joshrosen@databricks.com>
      
      Closes #7334 from JoshRosen/remove-copy-in-limit.
      06f0df6d
    • Nam Pham's avatar
      [SPARK-12986][DOC] Fix pydoc warnings in mllib/regression.py · edf4a0e6
      Nam Pham authored
      I have fixed the warnings by running "make html" under "python/docs/". They are caused by not having blank lines around indented paragraphs.
      
      Author: Nam Pham <phamducnam@gmail.com>
      
      Closes #11025 from nampham2/SPARK-12986.
      edf4a0e6
  2. Feb 07, 2016
    • cody koeninger's avatar
      [SPARK-10963][STREAMING][KAFKA] make KafkaCluster public · 140ddef3
      cody koeninger authored
      Author: cody koeninger <cody@koeninger.org>
      
      Closes #9007 from koeninger/SPARK-10963.
      140ddef3
    • Gary King's avatar
      [SPARK-13132][MLLIB] cache standardization param value in LogisticRegression · bc8890b3
      Gary King authored
      cache the value of the standardization Param in LogisticRegression, rather than re-fetching it from the ParamMap for every index and every optimization step in the quasi-newton optimizer
      
      also, fix Param#toString to cache the stringified representation, rather than re-interpolating it on every call, so any other implementations that have similar repeated access patterns will see a benefit.
      
      this change improves training times for one of my test sets from ~7m30s to ~4m30s
      
      Author: Gary King <gary@idibon.com>
      
      Closes #11027 from idigary/spark-13132-optimize-logistic-regression.
      bc8890b3
  3. Feb 06, 2016
  4. Feb 05, 2016
    • Jakob Odersky's avatar
      [SPARK-13171][CORE] Replace future calls with Future · 6883a512
      Jakob Odersky authored
      Trivial search-and-replace to eliminate deprecation warnings in Scala 2.11.
      Also works with 2.10
      
      Author: Jakob Odersky <jakob@odersky.com>
      
      Closes #11085 from jodersky/SPARK-13171.
      6883a512
    • Davies Liu's avatar
      [SPARK-13215] [SQL] remove fallback in codegen · 875f5079
      Davies Liu authored
      Since we remove the configuration for codegen, we are heavily reply on codegen (also TungstenAggregate require the generated MutableProjection to update UnsafeRow), should remove the fallback, which could make user confusing, see the discussion in SPARK-13116.
      
      Author: Davies Liu <davies@databricks.com>
      
      Closes #11097 from davies/remove_fallback.
      875f5079
    • Luc Bourlier's avatar
      [SPARK-13002][MESOS] Send initial request of executors for dyn allocation · 0bb5b733
      Luc Bourlier authored
      Fix for [SPARK-13002](https://issues.apache.org/jira/browse/SPARK-13002) about the initial number of executors when running with dynamic allocation on Mesos.
      Instead of fixing it just for the Mesos case, made the change in `ExecutorAllocationManager`. It is already driving the number of executors running on Mesos, only no the initial value.
      
      The `None` and `Some(0)` are internal details on the computation of resources to reserved, in the Mesos backend scheduler. `executorLimitOption` has to be initialized correctly, otherwise the Mesos backend scheduler will, either, create to many executors at launch, or not create any executors and not be able to recover from this state.
      
      Removed the 'special case' description in the doc. It was not totally accurate, and is not needed anymore.
      
      This doesn't fix the same problem visible with Spark standalone. There is no straightforward way to send the initial value in standalone mode.
      
      Somebody knowing this part of the yarn support should review this change.
      
      Author: Luc Bourlier <luc.bourlier@typesafe.com>
      
      Closes #11047 from skyluc/issue/initial-dyn-alloc-2.
      0bb5b733
    • Bill Chambers's avatar
      [SPARK-13214][DOCS] update dynamicAllocation documentation · 66e1383d
      Bill Chambers authored
      Author: Bill Chambers <bill@databricks.com>
      
      Closes #11094 from anabranch/dynamic-docs.
      66e1383d
    • Wenchen Fan's avatar
      [SPARK-12939][SQL] migrate encoder resolution logic to Analyzer · 1ed354a5
      Wenchen Fan authored
      https://issues.apache.org/jira/browse/SPARK-12939
      
      Now we will catch `ObjectOperator` in `Analyzer` and resolve the `fromRowExpression/deserializer` inside it.  Also update the `MapGroups` and `CoGroup` to pass in `dataAttributes`, so that we can correctly resolve value deserializer(the `child.output` contains both groupking key and values, which may mess things up if they have same-name attribtues). End-to-end tests are added.
      
      follow-ups:
      
      * remove encoders from typed aggregate expression.
      * completely remove resolve/bind in `ExpressionEncoder`
      
      Author: Wenchen Fan <wenchen@databricks.com>
      
      Closes #10852 from cloud-fan/bug.
      1ed354a5
    • Shixiong Zhu's avatar
      [SPARK-13166][SQL] Rename DataStreamReaderWriterSuite to DataFrameReaderWriterSuite · 7b73f171
      Shixiong Zhu authored
      A follow up PR for #11062 because it didn't rename the test suite.
      
      Author: Shixiong Zhu <shixiong@databricks.com>
      
      Closes #11096 from zsxwing/rename.
      7b73f171
    • Reynold Xin's avatar
      [SPARK-13187][SQL] Add boolean/long/double options in DataFrameReader/Writer · 82d84ff2
      Reynold Xin authored
      This patch adds option function for boolean, long, and double types. This makes it slightly easier for Spark users to specify options without turning them into strings. Using the JSON data source as an example.
      
      Before this patch:
      ```scala
      sqlContext.read.option("primitivesAsString", "true").json("/path/to/json")
      ```
      
      After this patch:
      Before this patch:
      ```scala
      sqlContext.read.option("primitivesAsString", true).json("/path/to/json")
      ```
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #11072 from rxin/SPARK-13187.
      82d84ff2
    • Jakob Odersky's avatar
      [SPARK-13208][CORE] Replace use of Pairs with Tuple2s · 352102ed
      Jakob Odersky authored
      Another trivial deprecation fix for Scala 2.11
      
      Author: Jakob Odersky <jakob@odersky.com>
      
      Closes #11089 from jodersky/SPARK-13208.
      352102ed
  5. Feb 04, 2016
    • gatorsmile's avatar
      [SPARK-12850][SQL] Support Bucket Pruning (Predicate Pushdown for Bucketed Tables) · e3c75c63
      gatorsmile authored
      JIRA: https://issues.apache.org/jira/browse/SPARK-12850
      
      This PR is to support bucket pruning when the predicates are `EqualTo`, `EqualNullSafe`, `IsNull`, `In`, and `InSet`.
      
      Like HIVE, in this PR, the bucket pruning works when the bucketing key has one and only one column.
      
      So far, I do not find a way to verify how many buckets are actually scanned. However, I did verify it when doing the debug. Could you provide a suggestion how to do it properly? Thank you! cloud-fan yhuai rxin marmbrus
      
      BTW, we can add more cases to support complex predicate including `Or` and `And`. Please let me know if I should do it in this PR.
      
      Maybe we also need to add test cases to verify if bucket pruning works well for each data type.
      
      Author: gatorsmile <gatorsmile@gmail.com>
      
      Closes #10942 from gatorsmile/pruningBuckets.
      e3c75c63
    • Raafat Akkad's avatar
      [SPARK-13052] waitingApps metric doesn't show the number of apps currently in the WAITING state · 6dbfc407
      Raafat Akkad authored
      Author: Raafat Akkad <raafat.akkad@gmail.com>
      
      Closes #10959 from RaafatAkkad/master.
      6dbfc407
    • Andrew Or's avatar
      7a4b37f0
    • Shixiong Zhu's avatar
      [SPARK-13195][STREAMING] Fix NoSuchElementException when a state is not set... · 8e2f2963
      Shixiong Zhu authored
      [SPARK-13195][STREAMING] Fix NoSuchElementException when a state is not set but timeoutThreshold is defined
      
      Check the state Existence before calling get.
      
      Author: Shixiong Zhu <shixiong@databricks.com>
      
      Closes #11081 from zsxwing/SPARK-13195.
      8e2f2963
    • Andrew Or's avatar
      [SPARK-13079][SQL] InMemoryCatalog follow-ups · bd38dd6f
      Andrew Or authored
      This patch incorporates review feedback from #11069, which is already merged.
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #11080 from andrewor14/catalog-follow-ups.
      bd38dd6f
    • Andrew Or's avatar
      [SPARK-12330][MESOS][HOTFIX] Rename timeout config · c756bda4
      Andrew Or authored
      The config already describes time and accepts a general format
      that is not restricted to ms. This commit renames the internal
      config to use a format that's consistent in Spark.
      c756bda4
    • Josh Rosen's avatar
      [SPARK-13168][SQL] Collapse adjacent repartition operators · 33212cb9
      Josh Rosen authored
      Spark SQL should collapse adjacent `Repartition` operators and only keep the last one.
      
      Author: Josh Rosen <joshrosen@databricks.com>
      
      Closes #11064 from JoshRosen/collapse-repartition.
      33212cb9
    • Andrew Or's avatar
      MAINTENANCE: Automated closing of pull requests. · 085f510a
      Andrew Or authored
      This commit exists to close the following pull requests on Github:
      
      Closes #7971 (requested by yhuai)
      Closes #8539 (requested by srowen)
      Closes #8746 (requested by yhuai)
      Closes #9288 (requested by andrewor14)
      Closes #9321 (requested by andrewor14)
      Closes #9935 (requested by JoshRosen)
      Closes #10442 (requested by andrewor14)
      Closes #10585 (requested by srowen)
      Closes #10785 (requested by srowen)
      Closes #10832 (requested by andrewor14)
      Closes #10941 (requested by marmbrus)
      Closes #11024 (requested by andrewor14)
      085f510a
    • Andrew Or's avatar
      [SPARK-13053][TEST] Unignore tests in InternalAccumulatorSuite · 15205da8
      Andrew Or authored
      These were ignored because they are incorrectly written; they don't actually trigger stage retries, which is what the tests are testing. These tests are now rewritten to induce stage retries through fetch failures.
      
      Note: there were 2 tests before and now there's only 1. What happened? It turns out that the case where we only resubmit a subset of of the original missing partitions is very difficult to simulate in tests without potentially introducing flakiness. This is because the `DAGScheduler` removes all map outputs associated with a given executor when this happens, and we will need multiple executors to trigger this case, and sometimes the scheduler still removes map outputs from all executors.
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #10969 from andrewor14/unignore-accum-test.
      15205da8
    • Andrew Or's avatar
      [SPARK-13162] Standalone mode does not respect initial executors · 4120bcba
      Andrew Or authored
      Currently the Master would always set an application's initial executor limit to infinity. If the user specified `spark.dynamicAllocation.initialExecutors`, the config would not take effect. This is similar to #11047 but for standalone mode.
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #11054 from andrewor14/standalone-da-initial.
      4120bcba
    • Holden Karau's avatar
      [SPARK-13164][CORE] Replace deprecated synchronized buffer in core · 62a7c283
      Holden Karau authored
      Building with scala 2.11 results in the warning trait SynchronizedBuffer in package mutable is deprecated: Synchronization via traits is deprecated as it is inherently unreliable. Consider java.util.concurrent.ConcurrentLinkedQueue as an alternative. Investigation shows we are already using ConcurrentLinkedQueue in other locations so switch our uses of SynchronizedBuffer to ConcurrentLinkedQueue.
      
      Author: Holden Karau <holden@us.ibm.com>
      
      Closes #11059 from holdenk/SPARK-13164-replace-deprecated-synchronized-buffer-in-core.
      62a7c283
    • Charles Allen's avatar
      [SPARK-12330][MESOS] Fix mesos coarse mode cleanup · 2eaeafe8
      Charles Allen authored
      In the current implementation the mesos coarse scheduler does not wait for the mesos tasks to complete before ending the driver. This causes a race where the task has to finish cleaning up before the mesos driver terminates it with a SIGINT (and SIGKILL after 3 seconds if the SIGINT doesn't work).
      
      This PR causes the mesos coarse scheduler to wait for the mesos tasks to finish (with a timeout defined by `spark.mesos.coarse.shutdown.ms`)
      
      This PR also fixes a regression caused by [SPARK-10987] whereby submitting a shutdown causes a race between the local shutdown procedure and the notification of the scheduler driver disconnection. If the scheduler driver disconnection wins the race, the coarse executor incorrectly exits with status 1 (instead of the proper status 0)
      
      With this patch the mesos coarse scheduler terminates properly, the executors clean up, and the tasks are reported as `FINISHED` in the Mesos console (as opposed to `KILLED` in < 1.6 or `FAILED` in 1.6 and later)
      
      Author: Charles Allen <charles@allen-net.com>
      
      Closes #10319 from drcrallen/SPARK-12330.
      2eaeafe8
    • Reynold Xin's avatar
      [SPARK-12828][SQL] Natural join follow-up · dee801ad
      Reynold Xin authored
      This is a small addendum to #10762 to make the code more robust again future changes.
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #11070 from rxin/SPARK-12828-natural-join.
      dee801ad
    • Liang-Chi Hsieh's avatar
      [SPARK-13113] [CORE] Remove unnecessary bit operation when decoding page number · d3908714
      Liang-Chi Hsieh authored
      JIRA: https://issues.apache.org/jira/browse/SPARK-13113
      
      As we shift bits right, looks like the bitwise AND operation is unnecessary.
      
      Author: Liang-Chi Hsieh <viirya@gmail.com>
      
      Closes #11002 from viirya/improve-decodepagenumber.
      d3908714
  6. Feb 03, 2016
    • Yuhao Yang's avatar
      [ML][DOC] fix wrong api link in ml onevsrest · c2c956bc
      Yuhao Yang authored
      minor fix for api link in ml onevsrest
      
      Author: Yuhao Yang <hhbyyh@gmail.com>
      
      Closes #11068 from hhbyyh/onevsrestDoc.
      c2c956bc
    • Daoyuan Wang's avatar
      [SPARK-12828][SQL] add natural join support · 0f81318a
      Daoyuan Wang authored
      Jira:
      https://issues.apache.org/jira/browse/SPARK-12828
      
      Author: Daoyuan Wang <daoyuan.wang@intel.com>
      
      Closes #10762 from adrian-wang/naturaljoin.
      0f81318a
    • Andrew Or's avatar
      [SPARK-13079][SQL] Extend and implement InMemoryCatalog · a6483112
      Andrew Or authored
      This is a step towards consolidating `SQLContext` and `HiveContext`.
      
      This patch extends the existing Catalog API added in #10982 to include methods for handling table partitions. In particular, a partition is identified by `PartitionSpec`, which is just a `Map[String, String]`. The Catalog is still not used by anything yet, but its API is now more or less complete and an implementation is fully tested.
      
      About 200 lines are test code.
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #11069 from andrewor14/catalog.
      a6483112
    • Holden Karau's avatar
      [SPARK-13152][CORE] Fix task metrics deprecation warning · a8e2ba77
      Holden Karau authored
      Make an internal non-deprecated version of incBytesRead and incRecordsRead so we don't have unecessary deprecation warnings in our build.
      
      Right now incBytesRead and incRecordsRead are marked as deprecated and for internal use only. We should make private[spark] versions which are not deprecated and switch to those internally so as to not clutter up the warning messages when building.
      
      cc andrewor14 who did the initial deprecation
      
      Author: Holden Karau <holden@us.ibm.com>
      
      Closes #11056 from holdenk/SPARK-13152-fix-task-metrics-deprecation-warnings.
      a8e2ba77
    • Davies Liu's avatar
      [SPARK-13131] [SQL] Use best and average time in benchmark · de091452
      Davies Liu authored
      Best time is stabler than average time, also added a column for nano seconds per row (which could be used to estimate contributions of each components in a query).
      
      Having best time and average time together for more information (we can see kind of variance).
      
      rate, time per row and relative are all calculated using best time.
      
      The result looks like this:
      ```
      Intel(R) Core(TM) i7-4558U CPU  2.80GHz
      rang/filter/sum:                    Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
      -------------------------------------------------------------------------------------------
      rang/filter/sum codegen=false          14332 / 16646         36.0          27.8       1.0X
      rang/filter/sum codegen=true              845 /  940        620.0           1.6      17.0X
      ```
      
      Author: Davies Liu <davies@databricks.com>
      
      Closes #11018 from davies/gen_bench.
      de091452
    • Reynold Xin's avatar
      [SPARK-13166][SQL] Remove DataStreamReader/Writer · 915a7539
      Reynold Xin authored
      They seem redundant and we can simply use DataFrameReader/Writer. The new usage looks like:
      
      ```scala
      val df = sqlContext.read.stream("...")
      val handle = df.write.stream("...")
      handle.stop()
      ```
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #11062 from rxin/SPARK-13166.
      915a7539
    • Alex Bozarth's avatar
      [SPARK-3611][WEB UI] Show number of cores for each executor in application web UI · 3221eddb
      Alex Bozarth authored
      Added a Cores column in the Executors UI
      
      Author: Alex Bozarth <ajbozart@us.ibm.com>
      
      Closes #11039 from ajbozarth/spark3611.
      3221eddb
    • Herman van Hovell's avatar
      [SPARK-13157] [SQL] Support any kind of input for SQL commands. · 9dd2741e
      Herman van Hovell authored
      The ```SparkSqlLexer``` currently swallows characters which have not been defined in the grammar. This causes problems with SQL commands, such as: ```add jar file:///tmp/ab/TestUDTF.jar```. In this example the `````` is swallowed.
      
      This PR adds an extra Lexer rule to handle such input, and makes a tiny modification to the ```ASTNode```.
      
      cc davies liancheng
      
      Author: Herman van Hovell <hvanhovell@questtec.nl>
      
      Closes #11052 from hvanhovell/SPARK-13157.
      9dd2741e
Loading