Skip to content
Snippets Groups Projects
Commit 0bb5b733 authored by Luc Bourlier's avatar Luc Bourlier Committed by Andrew Or
Browse files

[SPARK-13002][MESOS] Send initial request of executors for dyn allocation

Fix for [SPARK-13002](https://issues.apache.org/jira/browse/SPARK-13002) about the initial number of executors when running with dynamic allocation on Mesos.
Instead of fixing it just for the Mesos case, made the change in `ExecutorAllocationManager`. It is already driving the number of executors running on Mesos, only no the initial value.

The `None` and `Some(0)` are internal details on the computation of resources to reserved, in the Mesos backend scheduler. `executorLimitOption` has to be initialized correctly, otherwise the Mesos backend scheduler will, either, create to many executors at launch, or not create any executors and not be able to recover from this state.

Removed the 'special case' description in the doc. It was not totally accurate, and is not needed anymore.

This doesn't fix the same problem visible with Spark standalone. There is no straightforward way to send the initial value in standalone mode.

Somebody knowing this part of the yarn support should review this change.

Author: Luc Bourlier <luc.bourlier@typesafe.com>

Closes #11047 from skyluc/issue/initial-dyn-alloc-2.
parent 66e1383d
No related branches found
No related tags found
No related merge requests found
...@@ -87,10 +87,17 @@ private[spark] class CoarseMesosSchedulerBackend( ...@@ -87,10 +87,17 @@ private[spark] class CoarseMesosSchedulerBackend(
val failuresBySlaveId: HashMap[String, Int] = new HashMap[String, Int] val failuresBySlaveId: HashMap[String, Int] = new HashMap[String, Int]
/** /**
* The total number of executors we aim to have. Undefined when not using dynamic allocation * The total number of executors we aim to have. Undefined when not using dynamic allocation.
* and before the ExecutorAllocatorManager calls [[doRequestTotalExecutors]]. * Initially set to 0 when using dynamic allocation, the executor allocation manager will send
* the real initial limit later.
*/ */
private var executorLimitOption: Option[Int] = None private var executorLimitOption: Option[Int] = {
if (Utils.isDynamicAllocationEnabled(conf)) {
Some(0)
} else {
None
}
}
/** /**
* Return the current executor limit, which may be [[Int.MaxValue]] * Return the current executor limit, which may be [[Int.MaxValue]]
......
...@@ -246,18 +246,15 @@ In either case, HDFS runs separately from Hadoop MapReduce, without being schedu ...@@ -246,18 +246,15 @@ In either case, HDFS runs separately from Hadoop MapReduce, without being schedu
# Dynamic Resource Allocation with Mesos # Dynamic Resource Allocation with Mesos
Mesos supports dynamic allocation only with coarse grain mode, which can resize the number of executors based on statistics Mesos supports dynamic allocation only with coarse-grain mode, which can resize the number of
of the application. While dynamic allocation supports both scaling up and scaling down the number of executors, the coarse grain scheduler only supports scaling down executors based on statistics of the application. For general information,
since it is already designed to run one executor per slave with the configured amount of resources. However, after scaling down the number of executors the coarse grain scheduler see [Dynamic Resource Allocation](job-scheduling.html#dynamic-resource-allocation).
can scale back up to the same amount of executors when Spark signals more executors are needed.
The External Shuffle Service to use is the Mesos Shuffle Service. It provides shuffle data cleanup functionality
Users that like to utilize this feature should launch the Mesos Shuffle Service that on top of the Shuffle Service since Mesos doesn't yet support notifying another framework's
provides shuffle data cleanup functionality on top of the Shuffle Service since Mesos doesn't yet support notifying another framework's termination. To launch it, run `$SPARK_HOME/sbin/start-mesos-shuffle-service.sh` on all slave nodes, with `spark.shuffle.service.enabled` set to `true`.
termination. To launch/stop the Mesos Shuffle Service please use the provided sbin/start-mesos-shuffle-service.sh and sbin/stop-mesos-shuffle-service.sh
scripts accordingly. This can also be achieved through Marathon, using a unique host constraint, and the following command: `bin/spark-class org.apache.spark.deploy.mesos.MesosExternalShuffleService`.
The Shuffle Service is expected to be running on each slave node that will run Spark executors. One way to easily achieve this with Mesos
is to launch the Shuffle Service with Marathon with a unique host constraint.
# Configuration # Configuration
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment