Skip to content
Snippets Groups Projects
  1. Jul 15, 2015
    • Feynman Liang's avatar
      [SPARK-9005] [MLLIB] Fix RegressionMetrics computation of explainedVariance · 536533ca
      Feynman Liang authored
      Fixes implementation of `explainedVariance` and `r2` to be consistent with their definitions as described in [SPARK-9005](https://issues.apache.org/jira/browse/SPARK-9005).
      
      Author: Feynman Liang <fliang@databricks.com>
      
      Closes #7361 from feynmanliang/SPARK-9005-RegressionMetrics-bugs and squashes the following commits:
      
      f1112fc [Feynman Liang] Add explainedVariance formula
      1a3d098 [Feynman Liang] SROwen code review comments
      08a0e1b [Feynman Liang] Fix pyspark tests
      db8605a [Feynman Liang] Style fix
      bde9761 [Feynman Liang] Fix RegressionMetrics tests, relax assumption predictor is unbiased
      c235de0 [Feynman Liang] Fix RegressionMetrics tests
      4c4e56f [Feynman Liang] Fix RegressionMetrics computation of explainedVariance and r2
      536533ca
    • Steve Loughran's avatar
      SPARK-9070 JavaDataFrameSuite teardown NPEs if setup failed · ec9b6216
      Steve Loughran authored
      fix teardown to skip table delete if hive context is null
      
      Author: Steve Loughran <stevel@hortonworks.com>
      
      Closes #7425 from steveloughran/stevel/patches/SPARK-9070-JavaDataFrameSuite-NPE and squashes the following commits:
      
      1982d38 [Steve Loughran] SPARK-9070 JavaDataFrameSuite teardown NPEs if setup failed
      ec9b6216
    • Shuo Xiang's avatar
      [SPARK-7555] [DOCS] Add doc for elastic net in ml-guide and mllib-guide · 303c1201
      Shuo Xiang authored
      jkbradley I put the elastic net under the **Algorithm guide** section. Also add the formula of elastic net in mllib-linear `mllib-linear-methods#regularizers`.
      
      dbtsai I left the code tab for you to add example code. Do you think it is the right place?
      
      Author: Shuo Xiang <shuoxiangpub@gmail.com>
      
      Closes #6504 from coderxiang/elasticnet and squashes the following commits:
      
      f6061ee [Shuo Xiang] typo
      90a7c88 [Shuo Xiang] Merge remote-tracking branch 'upstream/master' into elasticnet
      0610a36 [Shuo Xiang] move out the elastic net to ml-linear-methods
      8747190 [Shuo Xiang] merge master
      706d3f7 [Shuo Xiang] add python code
      9bc2b4c [Shuo Xiang] typo
      db32a60 [Shuo Xiang] java code sample
      aab3b3a [Shuo Xiang] Merge remote-tracking branch 'upstream/master' into elasticnet
      a0dae07 [Shuo Xiang] simplify code
      d8616fd [Shuo Xiang] Update the definition of elastic net. Add scala code; Mention Lasso and Ridge
      df5bd14 [Shuo Xiang] use wikipeida page in ml-linear-methods.md
      78d9366 [Shuo Xiang] address comments
      8ce37c2 [Shuo Xiang] Merge branch 'elasticnet' of github.com:coderxiang/spark into elasticnet
      8f24848 [Shuo Xiang] Merge branch 'elastic-net-doc' of github.com:coderxiang/spark into elastic-net-doc
      998d766 [Shuo Xiang] Merge branch 'elastic-net-doc' of github.com:coderxiang/spark into elastic-net-doc
      89f10e4 [Shuo Xiang] Merge remote-tracking branch 'upstream/master' into elastic-net-doc
      9262a72 [Shuo Xiang] update
      7e07d12 [Shuo Xiang] update
      b32f21a [Shuo Xiang] add doc for elastic net in sparkml
      937eef1 [Shuo Xiang] Merge remote-tracking branch 'upstream/master' into elastic-net-doc
      180b496 [Shuo Xiang] Merge remote-tracking branch 'upstream/master'
      aa0717d [Shuo Xiang] Merge remote-tracking branch 'upstream/master'
      5f109b4 [Shuo Xiang] Merge remote-tracking branch 'upstream/master'
      c5c5bfe [Shuo Xiang] Merge remote-tracking branch 'upstream/master'
      98804c9 [Shuo Xiang] fix bug in topBykey and update test
      303c1201
    • Liang-Chi Hsieh's avatar
      [Minor][SQL] Allow spaces in the beginning and ending of string for Interval · 9716a727
      Liang-Chi Hsieh authored
      This is a minor fixing for #7355 to allow spaces in the beginning and ending of string parsed to `Interval`.
      
      Author: Liang-Chi Hsieh <viirya@appier.com>
      
      Closes #7390 from viirya/fix_interval_string and squashes the following commits:
      
      9eb6831 [Liang-Chi Hsieh] Use trim instead of modifying regex.
      57861f7 [Liang-Chi Hsieh] Fix scala style.
      815a9cb [Liang-Chi Hsieh] Slightly modify regex to allow spaces in the beginning and ending of string.
      9716a727
    • zhichao.li's avatar
      [SPARK-8221][SQL]Add pmod function · a9385271
      zhichao.li authored
      https://issues.apache.org/jira/browse/SPARK-8221
      
      One concern is the result would be negative if the divisor is not positive( i.e pmod(7, -3) ), but the behavior is the same as hive.
      
      Author: zhichao.li <zhichao.li@intel.com>
      
      Closes #6783 from zhichao-li/pmod2 and squashes the following commits:
      
      7083eb9 [zhichao.li] update to the latest type checking
      d26dba7 [zhichao.li] add pmod
      a9385271
    • Wenchen Fan's avatar
      [SPARK-9020][SQL] Support mutable state in code gen expressions · fa4ec360
      Wenchen Fan authored
      We can keep expressions' mutable states in generated class(like `SpecificProjection`) as member variables, so that we can read and modify them inside codegened expressions.
      
      Author: Wenchen Fan <cloud0fan@outlook.com>
      
      Closes #7392 from cloud-fan/mutable-state and squashes the following commits:
      
      eb3a221 [Wenchen Fan] fix order
      73144d8 [Wenchen Fan] naming improvement
      318f41d [Wenchen Fan] address more comments
      d43b65d [Wenchen Fan] address comments
      fd45c7a [Wenchen Fan] Support mutable state in code gen expressions
      fa4ec360
    • Liang-Chi Hsieh's avatar
      [SPARK-8840] [SPARKR] Add float coercion on SparkR · 6f690259
      Liang-Chi Hsieh authored
      JIRA: https://issues.apache.org/jira/browse/SPARK-8840
      
      Currently the type coercion rules don't include float type. This PR simply adds it.
      
      Author: Liang-Chi Hsieh <viirya@appier.com>
      
      Closes #7280 from viirya/add_r_float_coercion and squashes the following commits:
      
      c86dc0e [Liang-Chi Hsieh] For comments.
      dbf0c1b [Liang-Chi Hsieh] Implicitly convert Double to Float based on provided schema.
      733015a [Liang-Chi Hsieh] Add test case for DataFrame with float type.
      30c2a40 [Liang-Chi Hsieh] Update test case.
      52b5294 [Liang-Chi Hsieh] Merge remote-tracking branch 'upstream/master' into add_r_float_coercion
      6f9159d [Liang-Chi Hsieh] Add another test case.
      8db3244 [Liang-Chi Hsieh] schema also needs to support float. add test case.
      0dcc992 [Liang-Chi Hsieh] Add float coercion on SparkR.
      6f690259
    • MechCoder's avatar
      [SPARK-8706] [PYSPARK] [PROJECT INFRA] Add pylint checks to PySpark · 20bb10f8
      MechCoder authored
      This adds Pylint checks to PySpark.
      
      For now this lazy installs using easy_install to /dev/pylint (similar to the pep8 script).
      We still need to figure out what rules to be allowed.
      
      Author: MechCoder <manojkumarsivaraj334@gmail.com>
      
      Closes #7241 from MechCoder/pylint and squashes the following commits:
      
      2fc7291 [MechCoder] Remove pylint test fail
      6d883a2 [MechCoder] Silence warnings and make pylint tests fail to check if it works in jenkins
      f3a5e17 [MechCoder] undefined-variable
      ca8b749 [MechCoder] Minor changes
      71629f8 [MechCoder] remove trailing whitespace
      8498ff9 [MechCoder] Remove blacklisted arguments and pointless statements check
      1dbd094 [MechCoder] Disable all checks for now
      8b8aa8a [MechCoder] Add pylint configuration file
      7871bb1 [MechCoder] [SPARK-8706] [PySpark] [Project infra] Add pylint checks to PySpark
      20bb10f8
    • zsxwing's avatar
      [SPARK-9012] [WEBUI] Escape Accumulators in the task table · adb33d36
      zsxwing authored
      If running the following codes, the task table will be broken because accumulators aren't escaped.
      ```
      val a = sc.accumulator(1, "<table>")
      sc.parallelize(1 to 10).foreach(i => a += i)
      ```
      
      Before this fix,
      
      <img width="1348" alt="screen shot 2015-07-13 at 8 02 44 pm" src="https://cloud.githubusercontent.com/assets/1000778/8649295/b17c491e-299b-11e5-97ee-4e6a64074c4f.png">
      
      After this fix,
      
      <img width="1355" alt="screen shot 2015-07-13 at 8 14 32 pm" src="https://cloud.githubusercontent.com/assets/1000778/8649337/f9e9c9ec-299b-11e5-927e-35c0a2f897f5.png">
      
      Author: zsxwing <zsxwing@gmail.com>
      
      Closes #7369 from zsxwing/SPARK-9012 and squashes the following commits:
      
      a83c9b6 [zsxwing] Escape Accumulators in the task table
      adb33d36
    • Reynold Xin's avatar
      [HOTFIX][SQL] Unit test breaking. · 14935d84
      Reynold Xin authored
      14935d84
    • Feynman Liang's avatar
      [SPARK-8997] [MLLIB] Performance improvements in LocalPrefixSpan · 1bb8accb
      Feynman Liang authored
      Improves the performance of LocalPrefixSpan by implementing optimizations proposed in [SPARK-8997](https://issues.apache.org/jira/browse/SPARK-8997)
      
      Author: Feynman Liang <fliang@databricks.com>
      Author: Feynman Liang <feynman.liang@gmail.com>
      Author: Xiangrui Meng <meng@databricks.com>
      
      Closes #7360 from feynmanliang/SPARK-8997-improve-prefixspan and squashes the following commits:
      
      59db2f5 [Feynman Liang] Merge pull request #1 from mengxr/SPARK-8997
      91e4357 [Xiangrui Meng] update LocalPrefixSpan impl
      9212256 [Feynman Liang] MengXR code review comments
      f055d82 [Feynman Liang] Fix failing scalatest
      2e00cba [Feynman Liang] Depth first projections
      70b93e3 [Feynman Liang] Performance improvements in LocalPrefixSpan, fix tests
      1bb8accb
    • Yijie Shen's avatar
      [SPARK-8279][SQL]Add math function round · f0e12974
      Yijie Shen authored
      JIRA: https://issues.apache.org/jira/browse/SPARK-8279
      
      Author: Yijie Shen <henry.yijieshen@gmail.com>
      
      Closes #6938 from yijieshen/udf_round_3 and squashes the following commits:
      
      07a124c [Yijie Shen] remove useless def children
      392b65b [Yijie Shen] add negative scale test in DecimalSuite
      61760ee [Yijie Shen] address reviews
      302a78a [Yijie Shen] Add dataframe function test
      31dfe7c [Yijie Shen] refactor round to make it readable
      8c7a949 [Yijie Shen] rebase & inputTypes update
      9555e35 [Yijie Shen] tiny style fix
      d10be4a [Yijie Shen] use TypeCollection to specify wanted input and implicit cast
      c3b9839 [Yijie Shen] rely on implict cast to handle string input
      b0bff79 [Yijie Shen] make round's inner method's name more meaningful
      9bd6930 [Yijie Shen] revert accidental change
      e6f44c4 [Yijie Shen] refactor eval and genCode
      1b87540 [Yijie Shen] modify checkInputDataTypes using foldable
      5486b2d [Yijie Shen] DataFrame API modification
      2077888 [Yijie Shen] codegen versioned eval
      6cd9a64 [Yijie Shen] refactor Round's constructor
      9be894e [Yijie Shen] add round functions in o.a.s.sql.functions
      7c83e13 [Yijie Shen] more tests on round
      56db4bb [Yijie Shen] Add decimal support to Round
      7e163ae [Yijie Shen] style fix
      653d047 [Yijie Shen] Add math function round
      f0e12974
    • FlytxtRnD's avatar
      [SPARK-8018] [MLLIB] KMeans should accept initial cluster centers as param · 3f6296fe
      FlytxtRnD authored
       This allows Kmeans to be initialized using an existing set of cluster centers provided as  a KMeansModel object. This mode of initialization performs a single run.
      
      Author: FlytxtRnD <meethu.mathew@flytxt.com>
      
      Closes #6737 from FlytxtRnD/Kmeans-8018 and squashes the following commits:
      
      94b56df [FlytxtRnD] style correction
      ef95ee2 [FlytxtRnD] style correction
      c446c58 [FlytxtRnD] documentation and numRuns warning change
      06d13ef [FlytxtRnD] numRuns corrected
      d12336e [FlytxtRnD] numRuns variable modifications
      07f8554 [FlytxtRnD] remove setRuns from setIntialModel
      e721dfe [FlytxtRnD] Merge remote-tracking branch 'upstream/master' into Kmeans-8018
      242ead1 [FlytxtRnD] corrected == to === in assert
      714acb5 [FlytxtRnD] added numRuns
      60c8ce2 [FlytxtRnD] ignore runs parameter and initialModel test suite changed
      582e6d9 [FlytxtRnD] Merge remote-tracking branch 'upstream/master' into Kmeans-8018
      3f5fc8e [FlytxtRnD] test case modified and one runs condition added
      cd5dc5c [FlytxtRnD] Merge remote-tracking branch 'upstream/master' into Kmeans-8018
      16f1b53 [FlytxtRnD] Merge branch 'Kmeans-8018', remote-tracking branch 'upstream/master' into Kmeans-8018
      e9c35d7 [FlytxtRnD] Remove getInitialModel and match cluster count criteria
      6959861 [FlytxtRnD] Accept initial cluster centers in KMeans
      3f6296fe
    • Yu ISHIKAWA's avatar
      [SPARK-6259] [MLLIB] Python API for LDA · 46927696
      Yu ISHIKAWA authored
      I implemented the Python API for LDA. But I didn't implemented a method for `LDAModel.describeTopics()`, beause it's a little hard to implement it now. And adding document about that and an example code would fit for another issue.
      
      TODO: LDAModel.describeTopics() in Python must be also implemented. But it would be nice to fit for another issue. Implementing it is a little hard, since the return value of `describeTopics` in Scala consists of Tuple classes.
      
      Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com>
      
      Closes #6791 from yu-iskw/SPARK-6259 and squashes the following commits:
      
      6855f59 [Yu ISHIKAWA] LDA inherits object
      28bd165 [Yu ISHIKAWA] Change the place of testing code
      d7a332a [Yu ISHIKAWA] Remove the doc comment about the optimizer's default value
      083e226 [Yu ISHIKAWA] Add the comment about the supported values and the default value of `optimizer`
      9f8bed8 [Yu ISHIKAWA] Simplify casting
      faa9764 [Yu ISHIKAWA] Add some comments for the LDA paramters
      98f645a [Yu ISHIKAWA] Remove the interface for `describeTopics`. Because it is not implemented.
      57ac03d [Yu ISHIKAWA] Remove the unnecessary import in Python unit testing
      73412c3 [Yu ISHIKAWA] Fix the typo
      2278829 [Yu ISHIKAWA] Fix the indentation
      39514ec [Yu ISHIKAWA] Modify how to cast the input data
      8117e18 [Yu ISHIKAWA] Fix the validation problems by `lint-scala`
      77fd1b7 [Yu ISHIKAWA] Not use LabeledPoint
      68f0653 [Yu ISHIKAWA] Support some parameters for `ALS.train()` in Python
      25ef2ac [Yu ISHIKAWA] Resolve conflicts with rebasing
      46927696
    • Michael Armbrust's avatar
      Revert SPARK-6910 and SPARK-9027 · c6b1a9e7
      Michael Armbrust authored
      Revert #7216 and #7386.  These patch seems to be causing quite a few test failures:
      
      ```
      Caused by: java.lang.reflect.InvocationTargetException
      	at sun.reflect.GeneratedMethodAccessor322.invoke(Unknown Source)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:606)
      	at org.apache.spark.sql.hive.client.Shim_v0_13.getPartitionsByFilter(HiveShim.scala:351)
      	at org.apache.spark.sql.hive.client.ClientWrapper$$anonfun$getPartitionsByFilter$1.apply(ClientWrapper.scala:320)
      	at org.apache.spark.sql.hive.client.ClientWrapper$$anonfun$getPartitionsByFilter$1.apply(ClientWrapper.scala:318)
      	at org.apache.spark.sql.hive.client.ClientWrapper$$anonfun$withHiveState$1.apply(ClientWrapper.scala:180)
      	at org.apache.spark.sql.hive.client.ClientWrapper.retryLocked(ClientWrapper.scala:135)
      	at org.apache.spark.sql.hive.client.ClientWrapper.withHiveState(ClientWrapper.scala:172)
      	at org.apache.spark.sql.hive.client.ClientWrapper.getPartitionsByFilter(ClientWrapper.scala:318)
      	at org.apache.spark.sql.hive.client.HiveTable.getPartitions(ClientInterface.scala:78)
      	at org.apache.spark.sql.hive.MetastoreRelation.getHiveQlPartitions(HiveMetastoreCatalog.scala:670)
      	at org.apache.spark.sql.hive.execution.HiveTableScan.doExecute(HiveTableScan.scala:137)
      	at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:90)
      	at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:90)
      	at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:147)
      	at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:89)
      	at org.apache.spark.sql.execution.Exchange$$anonfun$doExecute$1.apply(Exchange.scala:164)
      	at org.apache.spark.sql.execution.Exchange$$anonfun$doExecute$1.apply(Exchange.scala:151)
      	at org.apache.spark.sql.catalyst.errors.package$.attachTree(package.scala:48)
      	... 85 more
      Caused by: MetaException(message:Filtering is supported only on partition keys of type string)
      	at org.apache.hadoop.hive.metastore.parser.ExpressionTree$FilterBuilder.setError(ExpressionTree.java:185)
      	at org.apache.hadoop.hive.metastore.parser.ExpressionTree$LeafNode.getJdoFilterPushdownParam(ExpressionTree.java:452)
      	at org.apache.hadoop.hive.metastore.parser.ExpressionTree$LeafNode.generateJDOFilterOverPartitions(ExpressionTree.java:357)
      	at org.apache.hadoop.hive.metastore.parser.ExpressionTree$LeafNode.generateJDOFilter(ExpressionTree.java:279)
      	at org.apache.hadoop.hive.metastore.parser.ExpressionTree$TreeNode.generateJDOFilter(ExpressionTree.java:243)
      	at org.apache.hadoop.hive.metastore.parser.ExpressionTree.generateJDOFilterFragment(ExpressionTree.java:590)
      	at org.apache.hadoop.hive.metastore.ObjectStore.makeQueryFilterString(ObjectStore.java:2417)
      	at org.apache.hadoop.hive.metastore.ObjectStore.getPartitionsViaOrmFilter(ObjectStore.java:2029)
      	at org.apache.hadoop.hive.metastore.ObjectStore.access$500(ObjectStore.java:146)
      	at org.apache.hadoop.hive.metastore.ObjectStore$4.getJdoResult(ObjectStore.java:2332)
      ```
      https://amplab.cs.berkeley.edu/jenkins/view/Spark-QA-Test/job/Spark-Master-Maven-with-YARN/2945/HADOOP_PROFILE=hadoop-2.4,label=centos/testReport/junit/org.apache.spark.sql.hive.execution/SortMergeCompatibilitySuite/auto_sortmerge_join_16/
      
      Author: Michael Armbrust <michael@databricks.com>
      
      Closes #7409 from marmbrus/revertMetastorePushdown and squashes the following commits:
      
      92fabd3 [Michael Armbrust] Revert SPARK-6910 and SPARK-9027
      5d3bdf2 [Michael Armbrust] Revert "[SPARK-9027] [SQL] Generalize metastore predicate pushdown"
      c6b1a9e7
    • Reynold Xin's avatar
      [SPARK-8993][SQL] More comprehensive type checking in expressions. · f23a721c
      Reynold Xin authored
      This patch makes the following changes:
      
      1. ExpectsInputTypes only defines expected input types, but does not perform any implicit type casting.
      2. ImplicitCastInputTypes is a new trait that defines both expected input types, as well as performs implicit type casting.
      3. BinaryOperator has a new abstract function "inputType", which defines the expected input type for both left/right. Concrete BinaryOperator expressions no longer perform any implicit type casting.
      4. For BinaryOperators, convert NullType (i.e. null literals) into some accepted type so BinaryOperators don't need to handle NullTypes.
      
      TODOs needed: fix unit tests for error reporting.
      
      I'm intentionally not changing anything in aggregate expressions because yhuai is doing a big refactoring on that right now.
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #7348 from rxin/typecheck and squashes the following commits:
      
      8fcf814 [Reynold Xin] Fixed ordering of cases.
      3bb63e7 [Reynold Xin] Style fix.
      f45408f [Reynold Xin] Comment update.
      aa7790e [Reynold Xin] Moved RemoveNullTypes into ImplicitTypeCasts.
      438ea07 [Reynold Xin] space
      d55c9e5 [Reynold Xin] Removes NullTypes.
      360d124 [Reynold Xin] Fixed the rule.
      fb66657 [Reynold Xin] Convert NullType into some accepted type for BinaryOperators.
      2e22330 [Reynold Xin] Fixed unit tests.
      4932d57 [Reynold Xin] Style fix.
      d061691 [Reynold Xin] Rename existing ExpectsInputTypes -> ImplicitCastInputTypes.
      e4727cc [Reynold Xin] BinaryOperator should not be doing implicit cast.
      d017861 [Reynold Xin] Improve expression type checking.
      f23a721c
    • Sun Rui's avatar
      [SPARK-8808] [SPARKR] Fix assignments in SparkR. · f650a005
      Sun Rui authored
      Author: Sun Rui <rui.sun@intel.com>
      
      Closes #7395 from sun-rui/SPARK-8808 and squashes the following commits:
      
      ce603bc [Sun Rui] Use '<-' instead of '='.
      88590b1 [Sun Rui] Use '<-' instead of '='.
      f650a005
  2. Jul 14, 2015
    • Patrick Wendell's avatar
      5572fd0c
    • jerryshao's avatar
      [SPARK-5523] [CORE] [STREAMING] Add a cache for hostname in TaskMetrics to... · bb870e72
      jerryshao authored
      [SPARK-5523] [CORE] [STREAMING] Add a cache for hostname in TaskMetrics to decrease the memory usage and GC overhead
      
      Hostname in TaskMetrics will be created through deserialization, mostly the number of hostname is only the order of number of cluster node, so adding a cache layer to dedup the object could reduce the memory usage and alleviate GC overhead, especially for long-running and fast job generation applications like Spark Streaming.
      
      Author: jerryshao <saisai.shao@intel.com>
      Author: Saisai Shao <saisai.shao@intel.com>
      
      Closes #5064 from jerryshao/SPARK-5523 and squashes the following commits:
      
      3e2412a [jerryshao] Address the comments
      b092a81 [Saisai Shao] Add a pool to cache the hostname
      bb870e72
    • huangzhaowei's avatar
      [SPARK-8820] [STREAMING] Add a configuration to set checkpoint dir. · f957796c
      huangzhaowei authored
      Add a configuration to set checkpoint directory  for convenience to user.
      [Jira Address](https://issues.apache.org/jira/browse/SPARK-8820)
      
      Author: huangzhaowei <carlmartinmax@gmail.com>
      
      Closes #7218 from SaintBacchus/SPARK-8820 and squashes the following commits:
      
      d49fe4b [huangzhaowei] Rename the configuration name
      66ea47c [huangzhaowei] Add the unit test.
      dd0acc1 [huangzhaowei] [SPARK-8820][Streaming] Add a configuration to set checkpoint dir.
      f957796c
    • Josh Rosen's avatar
      [SPARK-9050] [SQL] Remove unused newOrdering argument from Exchange (cleanup after SPARK-8317) · cc57d705
      Josh Rosen authored
      SPARK-8317 changed the SQL Exchange operator so that it no longer pushed sorting into Spark's shuffle layer, a change which allowed more efficient SQL-specific sorters to be used.
      
      This patch performs some leftover cleanup based on those changes:
      
      - Exchange's constructor should no longer accept a `newOrdering` since it's no longer used and no longer works as expected.
      - `addOperatorsIfNecessary` looked at shuffle input's output ordering to decide whether to sort, but this is the wrong node to be examining: it needs to look at whether the post-shuffle node has the right ordering, since shuffling will not preserve row orderings.  Thanks to davies for spotting this.
      
      Author: Josh Rosen <joshrosen@databricks.com>
      
      Closes #7407 from JoshRosen/SPARK-9050 and squashes the following commits:
      
      e70be50 [Josh Rosen] No need to wrap line
      e866494 [Josh Rosen] Refactor addOperatorsIfNecessary to make code clearer
      2e467da [Josh Rosen] Remove `newOrdering` from Exchange.
      cc57d705
    • Josh Rosen's avatar
      [SPARK-9045] Fix Scala 2.11 build break in UnsafeExternalRowSorter · e965a798
      Josh Rosen authored
      This fixes a compilation break in under Scala 2.11:
      
      ```
      [error] /home/jenkins/workspace/Spark-Master-Scala211-Compile/sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java:135: error: <anonymous org.apache.spark.sql.execution.UnsafeExternalRowSorter$1> is not abstract and does not override abstract method <B>minBy(Function1<InternalRow,B>,Ordering<B>) in TraversableOnce
      [error]       return new AbstractScalaRowIterator() {
      [error]                                             ^
      [error]   where B,A are type-variables:
      [error]     B extends Object declared in method <B>minBy(Function1<A,B>,Ordering<B>)
      [error]     A extends Object declared in interface TraversableOnce
      [error] 1 error
      ```
      
      The workaround for this is to make `AbstractScalaRowIterator` into a concrete class.
      
      Author: Josh Rosen <joshrosen@databricks.com>
      
      Closes #7405 from JoshRosen/SPARK-9045 and squashes the following commits:
      
      cbcbb4c [Josh Rosen] Forgot that we can't use the ??? operator anymore
      577ba60 [Josh Rosen] [SPARK-9045] Fix Scala 2.11 build break in UnsafeExternalRowSorter.
      e965a798
    • Josh Rosen's avatar
      [SPARK-8962] Add Scalastyle rule to ban direct use of Class.forName; fix existing uses · 11e5c372
      Josh Rosen authored
      This pull request adds a Scalastyle regex rule which fails the style check if `Class.forName` is used directly.  `Class.forName` always loads classes from the default / system classloader, but in a majority of cases, we should be using Spark's own `Utils.classForName` instead, which tries to load classes from the current thread's context classloader and falls back to the classloader which loaded Spark when the context classloader is not defined.
      
      <!-- Reviewable:start -->
      [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/7350)
      <!-- Reviewable:end -->
      
      Author: Josh Rosen <joshrosen@databricks.com>
      
      Closes #7350 from JoshRosen/ban-Class.forName and squashes the following commits:
      
      e3e96f7 [Josh Rosen] Merge remote-tracking branch 'origin/master' into ban-Class.forName
      c0b7885 [Josh Rosen] Hopefully fix the last two cases
      d707ba7 [Josh Rosen] Fix uses of Class.forName that I missed in my first cleanup pass
      046470d [Josh Rosen] Merge remote-tracking branch 'origin/master' into ban-Class.forName
      62882ee [Josh Rosen] Fix uses of Class.forName or add exclusion.
      d9abade [Josh Rosen] Add stylechecker rule to ban uses of Class.forName
      11e5c372
    • Sean Owen's avatar
      [SPARK-4362] [MLLIB] Make prediction probability available in NaiveBayesModel · 740b034f
      Sean Owen authored
      Add predictProbabilities to Naive Bayes, return class probabilities.
      
      Continues https://github.com/apache/spark/pull/6761
      
      Author: Sean Owen <sowen@cloudera.com>
      
      Closes #7376 from srowen/SPARK-4362 and squashes the following commits:
      
      23d5a76 [Sean Owen] Fix model.labels -> model.theta
      95d91fb [Sean Owen] Check that predicted probabilities sum to 1
      b32d1c8 [Sean Owen] Add predictProbabilities to Naive Bayes, return class probabilities
      740b034f
    • Liang-Chi Hsieh's avatar
      [SPARK-8800] [SQL] Fix inaccurate precision/scale of Decimal division operation · 4b5cfc98
      Liang-Chi Hsieh authored
      JIRA: https://issues.apache.org/jira/browse/SPARK-8800
      
      Previously, we turn to Java BigDecimal's divide with specified ROUNDING_MODE to avoid non-terminating decimal expansion problem. However, as JihongMA reported, for the division operation on some specific values, we get inaccurate results.
      
      Author: Liang-Chi Hsieh <viirya@gmail.com>
      
      Closes #7212 from viirya/fix_decimal4 and squashes the following commits:
      
      4205a0a [Liang-Chi Hsieh] Fix inaccuracy precision/scale of Decimal division operation.
      4b5cfc98
    • zsxwing's avatar
      [SPARK-4072] [CORE] Display Streaming blocks in Streaming UI · fb1d06fc
      zsxwing authored
      Replace #6634
      
      This PR adds `SparkListenerBlockUpdated` to SparkListener so that it can monitor all block update infos that are sent to `BlockManagerMasaterEndpoint`, and also add new tables in the Storage tab to display the stream block infos.
      
      ![screen shot 2015-07-01 at 5 19 46 pm](https://cloud.githubusercontent.com/assets/1000778/8451562/c291a6ec-2016-11e5-890d-0afc174e1f8c.png)
      
      Author: zsxwing <zsxwing@gmail.com>
      
      Closes #6672 from zsxwing/SPARK-4072-2 and squashes the following commits:
      
      df2c1d8 [zsxwing] Use xml query to check the xml elements
      54d54af [zsxwing] Add unit tests for StoragePage
      e29fb53 [zsxwing] Update as per TD's comments
      ccbee07 [zsxwing] Fix the code style
      6dc42b4 [zsxwing] Fix the replication level of blocks
      450fad1 [zsxwing] Merge branch 'master' into SPARK-4072-2
      1e9ef52 [zsxwing] Don't categorize by Executor ID
      ca0ab69 [zsxwing] Fix the code style
      3de2762 [zsxwing] Make object BlockUpdatedInfo private
      e95b594 [zsxwing] Add 'Aggregated Stream Block Metrics by Executor' table
      ba5d0d1 [zsxwing] Refactor the unit test to improve the readability
      4bbe341 [zsxwing] Revert JsonProtocol and don't log SparkListenerBlockUpdated
      b464dd1 [zsxwing] Add onBlockUpdated to EventLoggingListener
      5ba014c [zsxwing] Fix the code style
      0b1e47b [zsxwing] Add a developer api BlockUpdatedInfo
      04838a9 [zsxwing] Fix the code style
      2baa161 [zsxwing] Add unit tests
      80f6c6d [zsxwing] Address comments
      797ee4b [zsxwing] Display Streaming blocks in Streaming UI
      fb1d06fc
    • Andrew Ray's avatar
      [SPARK-8718] [GRAPHX] Improve EdgePartition2D for non perfect square number of partitions · 0a4071ea
      Andrew Ray authored
      See https://github.com/aray/e2d/blob/master/EdgePartition2D.ipynb
      
      Author: Andrew Ray <ray.andrew@gmail.com>
      
      Closes #7104 from aray/edge-partition-2d-improvement and squashes the following commits:
      
      3729f84 [Andrew Ray] correct bounds and remove unneeded comments
      97f8464 [Andrew Ray] change less
      5141ab4 [Andrew Ray] Merge branch 'master' into edge-partition-2d-improvement
      925fd2c [Andrew Ray] use new interface for partitioning
      001bfd0 [Andrew Ray] Refactor PartitionStrategy so that we can return a prtition function for a given number of parts. To keep compatibility we define default methods that translate between the two implementation options. Made EdgePartition2D use old strategy when we have a perfect square and implement new interface.
      5d42105 [Andrew Ray] % -> /
      3560084 [Andrew Ray] Merge branch 'master' into edge-partition-2d-improvement
      f006364 [Andrew Ray] remove unneeded comments
      cfa2c5e [Andrew Ray] Modifications to EdgePartition2D so that it works for non perfect squares.
      0a4071ea
    • Josh Rosen's avatar
      [SPARK-9031] Merge BlockObjectWriter and DiskBlockObject writer to remove abstract class · d267c283
      Josh Rosen authored
      BlockObjectWriter has only one concrete non-test class, DiskBlockObjectWriter. In order to simplify the code in preparation for other refactorings, I think that we should remove this base class and have only DiskBlockObjectWriter.
      
      While at one time we may have planned to have multiple BlockObjectWriter implementations, that doesn't seem to have happened, so the extra abstraction seems unnecessary.
      
      Author: Josh Rosen <joshrosen@databricks.com>
      
      Closes #7391 from JoshRosen/shuffle-write-interface-refactoring and squashes the following commits:
      
      c418e33 [Josh Rosen] Fix compilation
      5047995 [Josh Rosen] Fix comments
      d5dc548 [Josh Rosen] Update references in comments
      89dc797 [Josh Rosen] Rename test suite.
      5755918 [Josh Rosen] Remove unnecessary val in case class
      1607c91 [Josh Rosen] Merge BlockObjectWriter and DiskBlockObjectWriter
      d267c283
    • Andrew Or's avatar
      [SPARK-8911] Fix local mode endless heartbeats · 8fb3a65c
      Andrew Or authored
      As of #7173 we expect executors to properly register with the driver before responding to their heartbeats. This behavior is not matched in local mode. This patch adds the missing event that needs to be posted.
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #7382 from andrewor14/fix-local-heartbeat and squashes the following commits:
      
      1258bdf [Andrew Or] Post ExecutorAdded event to local executor
      8fb3a65c
    • Brennon York's avatar
      [SPARK-8933] [BUILD] Provide a --force flag to build/mvn that always uses downloaded maven · c4e98ff0
      Brennon York authored
      added --force flag to manually download, if necessary, and use a built-in version of maven best for spark
      
      Author: Brennon York <brennon.york@capitalone.com>
      
      Closes #7374 from brennonyork/SPARK-8933 and squashes the following commits:
      
      d673127 [Brennon York] added --force flag to manually download, if necessary, and use a built-in version of maven best for spark
      c4e98ff0
    • Michael Armbrust's avatar
      [SPARK-9027] [SQL] Generalize metastore predicate pushdown · 37f2d963
      Michael Armbrust authored
      Add support for pushing down metastore filters that are in different orders and add some unit tests.
      
      Author: Michael Armbrust <michael@databricks.com>
      
      Closes #7386 from marmbrus/metastoreFilters and squashes the following commits:
      
      05a4524 [Michael Armbrust] [SPARK-9027][SQL] Generalize metastore predicate pushdown
      37f2d963
    • Wenchen Fan's avatar
      [SPARK-9029] [SQL] shortcut CaseKeyWhen if key is null · 59d820aa
      Wenchen Fan authored
      Author: Wenchen Fan <cloud0fan@outlook.com>
      
      Closes #7389 from cloud-fan/case-when and squashes the following commits:
      
      ea4b6ba [Wenchen Fan] shortcut for case key when
      59d820aa
    • Daoyuan Wang's avatar
      [SPARK-6851] [SQL] function least/greatest follow up · 257236c3
      Daoyuan Wang authored
      This is a follow up of remaining comments from #6851
      
      Author: Daoyuan Wang <daoyuan.wang@intel.com>
      
      Closes #7387 from adrian-wang/udflgfollow and squashes the following commits:
      
      6163e62 [Daoyuan Wang] add skipping null values
      e8c2e09 [Daoyuan Wang] use seq
      8362966 [Daoyuan Wang] pr6851 follow up
      257236c3
    • zhaishidan's avatar
      [SPARK-9010] [DOCUMENTATION] Improve the Spark Configuration document about... · c1feebd8
      zhaishidan authored
      [SPARK-9010] [DOCUMENTATION] Improve the Spark Configuration document about `spark.kryoserializer.buffer`
      
      The meaning of spark.kryoserializer.buffer should be "Initial size of Kryo's serialization buffer. Note that there will be one buffer per core on each worker. This buffer will grow up to spark.kryoserializer.buffer.max if needed.".
      
      The spark.kryoserializer.buffer.max.mb is out-of-date in spark 1.4.
      
      Author: zhaishidan <zhaishidan@haizhi.com>
      
      Closes #7393 from stanzhai/master and squashes the following commits:
      
      69729ef [zhaishidan] fix document error about spark.kryoserializer.buffer.max.mb
      c1feebd8
    • Joseph Gonzalez's avatar
      [SPARK-9001] Fixing errors in javadocs that lead to failed build/sbt doc · 20c1434a
      Joseph Gonzalez authored
      These are minor corrections in the documentation of several classes that are preventing:
      
      ```bash
      build/sbt publish-local
      ```
      
      I believe this might be an issue associated with running JDK8 as ankurdave does not appear to have this issue in JDK7.
      
      Author: Joseph Gonzalez <joseph.e.gonzalez@gmail.com>
      
      Closes #7354 from jegonzal/FixingJavadocErrors and squashes the following commits:
      
      6664b7e [Joseph Gonzalez] making requested changes
      2e16d89 [Joseph Gonzalez] Fixing errors in javadocs that prevents build/sbt publish-local from completing.
      20c1434a
  3. Jul 13, 2015
    • Cheolsoo Park's avatar
      [SPARK-6910] [SQL] Support for pushing predicates down to metastore for partition pruning · 408b384d
      Cheolsoo Park authored
      This PR supersedes my old one #6921. Since my patch has changed quite a bit, I am opening a new PR to make it easier to review.
      
      The changes include-
      * Implement `toMetastoreFilter()` function in `HiveShim` that takes `Seq[Expression]` and converts them into a filter string for Hive metastore.
       * This functions matches all the `AttributeReference` + `BinaryComparisonOp` + `Integral/StringType` patterns in `Seq[Expression]` and fold them into a string.
      * Change `hiveQlPartitions` field in `MetastoreRelation` to `getHiveQlPartitions()` function that takes a filter string parameter.
      * Call `getHiveQlPartitions()` in `HiveTableScan` with a filter string.
      
      But there are some cases in which predicate pushdown is disabled-
      
      Case | Predicate pushdown
      ------- | -----------------------------
      Hive integral and string types | Yes
      Hive varchar type | No
      Hive 0.13 and newer | Yes
      Hive 0.12 and older | No
      convertMetastoreParquet=false | Yes
      convertMetastoreParquet=true | No
      
      In case of `convertMetastoreParquet=true`, predicates are not pushed down because this conversion happens in an `Analyzer` rule (`HiveMetastoreCatalog.ParquetConversions`). At this point, `HiveTableScan` hasn't run, so predicates are not available. But reading the source code, I think it is intentional to convert the entire Hive table w/ all the partitions into `ParquetRelation` because then `ParquetRelation` can be cached and reused for any query against that table. Please correct me if I am wrong.
      
      cc marmbrus
      
      Author: Cheolsoo Park <cheolsoop@netflix.com>
      
      Closes #7216 from piaozhexiu/SPARK-6910-2 and squashes the following commits:
      
      aa1490f [Cheolsoo Park] Fix ordering of imports
      c212c4d [Cheolsoo Park] Incorporate review comments
      5e93f9d [Cheolsoo Park] Predicate pushdown into Hive metastore
      408b384d
    • Neelesh Srinivas Salian's avatar
      [SPARK-8743] [STREAMING] Deregister Codahale metrics for streaming when StreamingContext is closed · b7bcbe25
      Neelesh Srinivas Salian authored
      The issue link: https://issues.apache.org/jira/browse/SPARK-8743
      Deregister Codahale metrics for streaming when StreamingContext is closed
      
      Design:
      Adding the method calls in the appropriate start() and stop () methods for the StreamingContext
      
      Actions in the PullRequest:
      1) Added the registerSource method call to the start method for the Streaming Context.
      2) Added the removeSource method to the stop method.
      3) Added comments for both 1 and 2 and comment to show initialization of the StreamingSource
      4) Added a test case to check for both registration and de-registration of metrics
      
      Previous closed PR for reference: https://github.com/apache/spark/pull/7250
      
      Author: Neelesh Srinivas Salian <nsalian@cloudera.com>
      
      Closes #7362 from nssalian/branch-SPARK-8743 and squashes the following commits:
      
      7d998a3 [Neelesh Srinivas Salian] Removed the Thread.sleep() call
      8b26397 [Neelesh Srinivas Salian] Moved the scalatest.{} import
      0e8007a [Neelesh Srinivas Salian] moved import org.apache.spark{} to correct place
      daedaa5 [Neelesh Srinivas Salian] Corrected Ordering of imports
      8873180 [Neelesh Srinivas Salian] Removed redundancy in imports
      59227a4 [Neelesh Srinivas Salian] Changed the ordering of the imports to classify  scala and spark imports
      d8cb577 [Neelesh Srinivas Salian] Added registerSource to start() and removeSource to stop(). Wrote a test to check the registration and de-registration
      b7bcbe25
    • Hari Shreedharan's avatar
      [SPARK-8533] [STREAMING] Upgrade Flume to 1.6.0 · 0aed38e4
      Hari Shreedharan authored
      Author: Hari Shreedharan <hshreedharan@apache.org>
      
      Closes #6939 from harishreedharan/upgrade-flume-1.6.0 and squashes the following commits:
      
      94b80ae [Hari Shreedharan] [SPARK-8533][Streaming] Upgrade Flume to 1.6.0
      0aed38e4
    • Vinod K C's avatar
      [SPARK-8636] [SQL] Fix equalNullSafe comparison · 4c797f2b
      Vinod K C authored
      Author: Vinod K C <vinod.kc@huawei.com>
      
      Closes #7040 from vinodkc/fix_CaseKeyWhen_equalNullSafe and squashes the following commits:
      
      be5e641 [Vinod K C] Renamed equalNullSafe to threeValueEquals
      aac9f67 [Vinod K C] Updated test suite and genCode method
      f2d0b53 [Vinod K C]  Fix equalNullSafe comparison
      4c797f2b
    • Vinod K C's avatar
      [SPARK-8991] [ML] Update SharedParamsCodeGen's Generated Documentation · 714fc55f
      Vinod K C authored
      Removed private[ml] from Generated documentation
      
      Author: Vinod K C <vinod.kc@huawei.com>
      
      Closes #7367 from vinodkc/fix_sharedparmascodegen and squashes the following commits:
      
      4fa3c8f [Vinod K C] Adding auto generated code
      7e19025 [Vinod K C] Removed private[ml]
      714fc55f
Loading