-
- Downloads
[SPARK-8962] Add Scalastyle rule to ban direct use of Class.forName; fix existing uses
This pull request adds a Scalastyle regex rule which fails the style check if `Class.forName` is used directly. `Class.forName` always loads classes from the default / system classloader, but in a majority of cases, we should be using Spark's own `Utils.classForName` instead, which tries to load classes from the current thread's context classloader and falls back to the classloader which loaded Spark when the context classloader is not defined. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/7350) <!-- Reviewable:end --> Author: Josh Rosen <joshrosen@databricks.com> Closes #7350 from JoshRosen/ban-Class.forName and squashes the following commits: e3e96f7 [Josh Rosen] Merge remote-tracking branch 'origin/master' into ban-Class.forName c0b7885 [Josh Rosen] Hopefully fix the last two cases d707ba7 [Josh Rosen] Fix uses of Class.forName that I missed in my first cleanup pass 046470d [Josh Rosen] Merge remote-tracking branch 'origin/master' into ban-Class.forName 62882ee [Josh Rosen] Fix uses of Class.forName or add exclusion. d9abade [Josh Rosen] Add stylechecker rule to ban uses of Class.forName
Showing
- core/src/main/scala/org/apache/spark/Logging.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/Logging.scala
- core/src/main/scala/org/apache/spark/SparkContext.scala 5 additions, 6 deletionscore/src/main/scala/org/apache/spark/SparkContext.scala
- core/src/main/scala/org/apache/spark/SparkEnv.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/SparkEnv.scala
- core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala 2 additions, 16 deletions...c/main/scala/org/apache/spark/api/r/RBackendHandler.scala
- core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala 2 additions, 1 deletion...n/scala/org/apache/spark/broadcast/BroadcastManager.scala
- core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 2 additions, 2 deletions.../main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
- core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala 1 addition, 1 deletion.../src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
- core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala 1 addition, 1 deletion.../scala/org/apache/spark/deploy/SparkSubmitArguments.scala
- core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala 1 addition, 1 deletion...scala/org/apache/spark/deploy/history/HistoryServer.scala
- core/src/main/scala/org/apache/spark/deploy/master/Master.scala 1 addition, 1 deletion...rc/main/scala/org/apache/spark/deploy/master/Master.scala
- core/src/main/scala/org/apache/spark/deploy/rest/SubmitRestProtocolMessage.scala 1 addition, 1 deletion.../apache/spark/deploy/rest/SubmitRestProtocolMessage.scala
- core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala 1 addition, 1 deletion.../scala/org/apache/spark/deploy/worker/DriverWrapper.scala
- core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala 2 additions, 0 deletions...cala/org/apache/spark/deploy/worker/WorkerArguments.scala
- core/src/main/scala/org/apache/spark/executor/Executor.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/executor/Executor.scala
- core/src/main/scala/org/apache/spark/io/CompressionCodec.scala 1 addition, 2 deletions...src/main/scala/org/apache/spark/io/CompressionCodec.scala
- core/src/main/scala/org/apache/spark/mapred/SparkHadoopMapRedUtil.scala 3 additions, 2 deletions...scala/org/apache/spark/mapred/SparkHadoopMapRedUtil.scala
- core/src/main/scala/org/apache/spark/mapreduce/SparkHadoopMapReduceUtil.scala 5 additions, 4 deletions...org/apache/spark/mapreduce/SparkHadoopMapReduceUtil.scala
- core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala 4 additions, 2 deletions...c/main/scala/org/apache/spark/metrics/MetricsSystem.scala
- core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala 3 additions, 3 deletionscore/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala
- core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala 1 addition, 2 deletionscore/src/main/scala/org/apache/spark/rpc/RpcEnv.scala
Loading
Please register or sign in to comment