Skip to content
Snippets Groups Projects
  1. Nov 16, 2016
    • Tathagata Das's avatar
      [SPARK-18461][DOCS][STRUCTUREDSTREAMING] Added more information about monitoring streaming queries · bb6cdfd9
      Tathagata Das authored
      ## What changes were proposed in this pull request?
      <img width="941" alt="screen shot 2016-11-15 at 6 27 32 pm" src="https://cloud.githubusercontent.com/assets/663212/20332521/4190b858-ab61-11e6-93a6-4bdc05105ed9.png">
      <img width="940" alt="screen shot 2016-11-15 at 6 27 45 pm" src="https://cloud.githubusercontent.com/assets/663212/20332525/44a0d01e-ab61-11e6-8668-47f925490d4f.png">
      
      Author: Tathagata Das <tathagata.das1565@gmail.com>
      
      Closes #15897 from tdas/SPARK-18461.
      bb6cdfd9
    • Tathagata Das's avatar
      [SPARK-18459][SPARK-18460][STRUCTUREDSTREAMING] Rename triggerId to batchId... · 0048ce7c
      Tathagata Das authored
      [SPARK-18459][SPARK-18460][STRUCTUREDSTREAMING] Rename triggerId to batchId and add triggerDetails to json in StreamingQueryStatus
      
      ## What changes were proposed in this pull request?
      
      SPARK-18459: triggerId seems like a number that should be increasing with each trigger, whether or not there is data in it. However, actually, triggerId increases only where there is a batch of data in a trigger. So its better to rename it to batchId.
      
      SPARK-18460: triggerDetails was missing from json representation. Fixed it.
      
      ## How was this patch tested?
      Updated existing unit tests.
      
      Author: Tathagata Das <tathagata.das1565@gmail.com>
      
      Closes #15895 from tdas/SPARK-18459.
      0048ce7c
    • gatorsmile's avatar
      [SPARK-18415][SQL] Weird Plan Output when CTE used in RunnableCommand · 608ecc51
      gatorsmile authored
      ### What changes were proposed in this pull request?
      Currently, when CTE is used in RunnableCommand, the Analyzer does not replace the logical node `With`. The child plan of RunnableCommand is not resolved. Thus, the output of the `With` plan node looks very confusing.
      For example,
      ```
      sql(
        """
          |CREATE VIEW cte_view AS
          |WITH w AS (SELECT 1 AS n), cte1 (select 2), cte2 as (select 3)
          |SELECT n FROM w
        """.stripMargin).explain()
      ```
      The output is like
      ```
      ExecutedCommand
         +- CreateViewCommand `cte_view`, WITH w AS (SELECT 1 AS n), cte1 (select 2), cte2 as (select 3)
      SELECT n FROM w, false, false, PersistedView
               +- 'With [(w,SubqueryAlias w
      +- Project [1 AS n#16]
         +- OneRowRelation$
      ), (cte1,'SubqueryAlias cte1
      +- 'Project [unresolvedalias(2, None)]
         +- OneRowRelation$
      ), (cte2,'SubqueryAlias cte2
      +- 'Project [unresolvedalias(3, None)]
         +- OneRowRelation$
      )]
                  +- 'Project ['n]
                     +- 'UnresolvedRelation `w`
      ```
      After the fix, the output is as shown below.
      ```
      ExecutedCommand
         +- CreateViewCommand `cte_view`, WITH w AS (SELECT 1 AS n), cte1 (select 2), cte2 as (select 3)
      SELECT n FROM w, false, false, PersistedView
               +- CTE [w, cte1, cte2]
                  :  :- SubqueryAlias w
                  :  :  +- Project [1 AS n#16]
                  :  :     +- OneRowRelation$
                  :  :- 'SubqueryAlias cte1
                  :  :  +- 'Project [unresolvedalias(2, None)]
                  :  :     +- OneRowRelation$
                  :  +- 'SubqueryAlias cte2
                  :     +- 'Project [unresolvedalias(3, None)]
                  :        +- OneRowRelation$
                  +- 'Project ['n]
                     +- 'UnresolvedRelation `w`
      ```
      
      BTW, this PR also fixes the output of the view type.
      
      ### How was this patch tested?
      Manual
      
      Author: gatorsmile <gatorsmile@gmail.com>
      
      Closes #15854 from gatorsmile/cteName.
      608ecc51
    • Xianyang Liu's avatar
      [SPARK-18420][BUILD] Fix the errors caused by lint check in Java · 7569cf6c
      Xianyang Liu authored
      ## What changes were proposed in this pull request?
      
      Small fix, fix the errors caused by lint check in Java
      
      - Clear unused objects and `UnusedImports`.
      - Add comments around the method `finalize` of `NioBufferedFileInputStream`to turn off checkstyle.
      - Cut the line which is longer than 100 characters into two lines.
      
      ## How was this patch tested?
      Travis CI.
      ```
      $ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
      $ dev/lint-java
      ```
      Before:
      ```
      Checkstyle checks failed at following occurrences:
      [ERROR] src/main/java/org/apache/spark/network/util/TransportConf.java:[21,8] (imports) UnusedImports: Unused import - org.apache.commons.crypto.cipher.CryptoCipherFactory.
      [ERROR] src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java:[516,5] (modifier) RedundantModifier: Redundant 'public' modifier.
      [ERROR] src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java:[133] (coding) NoFinalizer: Avoid using finalizer method.
      [ERROR] src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeMapData.java:[71] (sizes) LineLength: Line is longer than 100 characters (found 113).
      [ERROR] src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java:[112] (sizes) LineLength: Line is longer than 100 characters (found 110).
      [ERROR] src/test/java/org/apache/spark/sql/catalyst/expressions/HiveHasherSuite.java:[31,17] (modifier) ModifierOrder: 'static' modifier out of order with the JLS suggestions.
      [ERROR]src/main/java/org/apache/spark/examples/ml/JavaLogisticRegressionWithElasticNetExample.java:[64] (sizes) LineLength: Line is longer than 100 characters (found 103).
      [ERROR] src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[22,8] (imports) UnusedImports: Unused import - org.apache.spark.ml.linalg.Vectors.
      [ERROR] src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[51] (regexp) RegexpSingleline: No trailing whitespace allowed.
      ```
      
      After:
      ```
      $ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
      $ dev/lint-java
      Using `mvn` from path: /home/travis/build/ConeyLiu/spark/build/apache-maven-3.3.9/bin/mvn
      Checkstyle checks passed.
      ```
      
      Author: Xianyang Liu <xyliu0530@icloud.com>
      
      Closes #15865 from ConeyLiu/master.
      Unverified
      7569cf6c
    • Zheng RuiFeng's avatar
      [SPARK-18446][ML][DOCS] Add links to API docs for ML algos · a75e3fe9
      Zheng RuiFeng authored
      ## What changes were proposed in this pull request?
      Add links to API docs for ML algos
      ## How was this patch tested?
      Manual checking for the API links
      
      Author: Zheng RuiFeng <ruifengz@foxmail.com>
      
      Closes #15890 from zhengruifeng/algo_link.
      Unverified
      a75e3fe9
    • Zheng RuiFeng's avatar
      [SPARK-18434][ML] Add missing ParamValidations for ML algos · c68f1a38
      Zheng RuiFeng authored
      ## What changes were proposed in this pull request?
      Add missing ParamValidations for ML algos
      ## How was this patch tested?
      existing tests
      
      Author: Zheng RuiFeng <ruifengz@foxmail.com>
      
      Closes #15881 from zhengruifeng/arg_checking.
      c68f1a38
    • Weiqing Yang's avatar
      [MINOR][DOC] Fix typos in the 'configuration', 'monitoring' and... · 241e04bc
      Weiqing Yang authored
      [MINOR][DOC] Fix typos in the 'configuration', 'monitoring' and 'sql-programming-guide' documentation
      
      ## What changes were proposed in this pull request?
      
      Fix typos in the 'configuration', 'monitoring' and 'sql-programming-guide' documentation.
      
      ## How was this patch tested?
      Manually.
      
      Author: Weiqing Yang <yangweiqing001@gmail.com>
      
      Closes #15886 from weiqingy/fixTypo.
      Unverified
      241e04bc
    • uncleGen's avatar
      [SPARK-18410][STREAMING] Add structured kafka example · e6145772
      uncleGen authored
      ## What changes were proposed in this pull request?
      
      This PR provides structured kafka wordcount examples
      
      ## How was this patch tested?
      
      Author: uncleGen <hustyugm@gmail.com>
      
      Closes #15849 from uncleGen/SPARK-18410.
      Unverified
      e6145772
    • Sean Owen's avatar
      [SPARK-18400][STREAMING] NPE when resharding Kinesis Stream · 43a26899
      Sean Owen authored
      ## What changes were proposed in this pull request?
      
      Avoid NPE in KinesisRecordProcessor when shutdown happens without successful init
      
      ## How was this patch tested?
      
      Existing tests
      
      Author: Sean Owen <sowen@cloudera.com>
      
      Closes #15882 from srowen/SPARK-18400.
      Unverified
      43a26899
    • Liwei Lin's avatar
    • Dongjoon Hyun's avatar
      [SPARK-18433][SQL] Improve DataSource option keys to be more case-insensitive · 74f5c217
      Dongjoon Hyun authored
      ## What changes were proposed in this pull request?
      
      This PR aims to improve DataSource option keys to be more case-insensitive
      
      DataSource partially use CaseInsensitiveMap in code-path. For example, the following fails to find url.
      
      ```scala
      val df = spark.createDataFrame(sparkContext.parallelize(arr2x2), schema2)
      df.write.format("jdbc")
          .option("UrL", url1)
          .option("dbtable", "TEST.SAVETEST")
          .options(properties.asScala)
          .save()
      ```
      
      This PR makes DataSource options to use CaseInsensitiveMap internally and also makes DataSource to use CaseInsensitiveMap generally except `InMemoryFileIndex` and `InsertIntoHadoopFsRelationCommand`. We can not pass them CaseInsensitiveMap because they creates new case-sensitive HadoopConfs by calling newHadoopConfWithOptions(options) inside.
      
      ## How was this patch tested?
      
      Pass the Jenkins test with newly added test cases.
      
      Author: Dongjoon Hyun <dongjoon@apache.org>
      
      Closes #15884 from dongjoon-hyun/SPARK-18433.
      74f5c217
    • Yanbo Liang's avatar
      [SPARK-18438][SPARKR][ML] spark.mlp should support RFormula. · 95eb06bd
      Yanbo Liang authored
      ## What changes were proposed in this pull request?
      ```spark.mlp``` should support ```RFormula``` like other ML algorithm wrappers.
      BTW, I did some cleanup and improvement for ```spark.mlp```.
      
      ## How was this patch tested?
      Unit tests.
      
      Author: Yanbo Liang <ybliang8@gmail.com>
      
      Closes #15883 from yanboliang/spark-18438.
      95eb06bd
  2. Nov 15, 2016
    • Wenchen Fan's avatar
      [SPARK-18377][SQL] warehouse path should be a static conf · 4ac9759f
      Wenchen Fan authored
      ## What changes were proposed in this pull request?
      
      it's weird that every session can set its own warehouse path at runtime, we should forbid it and make it a static conf.
      
      ## How was this patch tested?
      
      existing tests.
      
      Author: Wenchen Fan <wenchen@databricks.com>
      
      Closes #15825 from cloud-fan/warehouse.
      4ac9759f
    • Herman van Hovell's avatar
      [SPARK-18300][SQL] Fix scala 2.10 build for FoldablePropagation · 4b35d13b
      Herman van Hovell authored
      ## What changes were proposed in this pull request?
      Commit https://github.com/apache/spark/commit/f14ae4900ad0ed66ba36108b7792d56cd6767a69 broke the scala 2.10 build. This PR fixes this by simplifying the used pattern match.
      
      ## How was this patch tested?
      Tested building manually. Ran `build/sbt -Dscala-2.10 -Pscala-2.10 package`.
      
      Author: Herman van Hovell <hvanhovell@databricks.com>
      
      Closes #15891 from hvanhovell/SPARK-18300-scala-2.10.
      4b35d13b
    • Dongjoon Hyun's avatar
      [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should support comparators · 3ce057d0
      Dongjoon Hyun authored
      ## What changes were proposed in this pull request?
      
      This PR aims to support `comparators`, e.g. '<', '<=', '>', '>=', again in Apache Spark 2.0 for backward compatibility.
      
      **Spark 1.6**
      
      ``` scala
      scala> sql("CREATE TABLE sales(id INT) PARTITIONED BY (country STRING, quarter STRING)")
      res0: org.apache.spark.sql.DataFrame = [result: string]
      
      scala> sql("ALTER TABLE sales DROP PARTITION (country < 'KR')")
      res1: org.apache.spark.sql.DataFrame = [result: string]
      ```
      
      **Spark 2.0**
      
      ``` scala
      scala> sql("CREATE TABLE sales(id INT) PARTITIONED BY (country STRING, quarter STRING)")
      res0: org.apache.spark.sql.DataFrame = []
      
      scala> sql("ALTER TABLE sales DROP PARTITION (country < 'KR')")
      org.apache.spark.sql.catalyst.parser.ParseException:
      mismatched input '<' expecting {')', ','}(line 1, pos 42)
      ```
      
      After this PR, it's supported.
      
      ## How was this patch tested?
      
      Pass the Jenkins test with a newly added testcase.
      
      Author: Dongjoon Hyun <dongjoon@apache.org>
      
      Closes #15704 from dongjoon-hyun/SPARK-17732-2.
      3ce057d0
    • hyukjinkwon's avatar
      [SPARK-18423][STREAMING] ReceiverTracker should close checkpoint dir when... · 503378f1
      hyukjinkwon authored
      [SPARK-18423][STREAMING] ReceiverTracker should close checkpoint dir when stopped even if it was not started
      
      ## What changes were proposed in this pull request?
      
      Several tests are being failed on Windows due to the failure of removing the checkpoint dir between each tests.
      
      This is caused by not closed file in `ReceiverTracker`. When it is not started, it does not close it even if `stop()` is called.
      
      ```
      Test org.apache.spark.streaming.JavaAPISuite.testCheckpointMasterRecovery started
      Test org.apache.spark.streaming.JavaAPISuite.testCheckpointMasterRecovery failed: java.io.IOException: Failed to delete: C:\projects\spark\target\tmp\1478983663710-0, took 3.828 sec
          at org.apache.spark.util.Utils$.deleteRecursively(Utils.scala:1010)
          at org.apache.spark.util.Utils.deleteRecursively(Utils.scala)
          at org.apache.spark.streaming.JavaAPISuite.testCheckpointMasterRecovery(JavaAPISuite.java:1809)
          ...
      ```
      
      ```
      - mapWithState - basic operations with simple API (7 seconds, 640 milliseconds)
      Exception encountered when attempting to run a suite with class name: org.apache.spark.streaming.MapWithStateSuite *** ABORTED *** (12 seconds, 688 milliseconds)
        java.io.IOException: Failed to delete: C:\projects\spark\streaming\checkpoint\spark-b8486e2b-6468-4e6f-bb24-88277d2c033c
        ...
      ```
      
      ## How was this patch tested?
      
      Tests in `JavaAPISuite` and `MapWithStateSuite`.
      
      Manually tested via AppVeyor:
      
      **Before**
      
      - `org.apache.spark.streaming.JavaAPISuite`
        Build: https://ci.appveyor.com/project/spark-test/spark/build/71-MapWithStateSuite-1
        Diff: https://github.com/apache/spark/compare/master...spark-test:188c828e682ec45b75d15c3dfc782bcdc8ce024c
      
      - `org.apache.spark.streaming.MapWithStateSuite`
        Build: https://ci.appveyor.com/project/spark-test/spark/build/72-MapWithStateSuite-1
        Diff: https://github.com/apache/spark/compare/master...spark-test:8f6945d0ccde022a23d3848f6b7fe6da1e7c902e
      
      **After**
      
      - `org.apache.spark.streaming.JavaAPISuite`
        Build started: [Streaming] `org.apache.spark.streaming.JavaAPISuite` [![PR-15867](https://ci.appveyor.com/api/projects/status/github/spark-test/spark?branch=3D74F2D5-B0D5-4E1D-874C-685AE694FD37&svg=true)](https://ci.appveyor.com/project/spark-test/spark/branch/3D74F2D5-B0D5-4E1D-874C-685AE694FD37)
        Diff: https://github.com/apache/spark/compare/master...spark-test:3D74F2D5-B0D5-4E1D-874C-685AE694FD37
      
      - `org.apache.spark.streaming.MapWithStateSuite`
        Build started: [Streaming] `org.apache.spark.streaming.MapWithStateSuite` [![PR-15867](https://ci.appveyor.com/api/projects/status/github/spark-test/spark?branch=C8E88B64-49F0-4157-9AFA-FC3ACC442351&svg=true)](https://ci.appveyor.com/project/spark-test/spark/branch/C8E88B64-49F0-4157-9AFA-FC3ACC442351)
        Diff: https://github.com/apache/spark/compare/master...spark-test:C8E88B64-49F0-4157-9AFA-FC3ACC442351
      
      Author: hyukjinkwon <gurwls223@gmail.com>
      
      Closes #15867 from HyukjinKwon/SPARK-18423.
      503378f1
    • Tathagata Das's avatar
      [SPARK-18440][STRUCTURED STREAMING] Pass correct query execution to FileFormatWriter · 1ae4652b
      Tathagata Das authored
      ## What changes were proposed in this pull request?
      
      SPARK-18012 refactored the file write path in FileStreamSink using FileFormatWriter which always uses the default non-streaming QueryExecution to perform the writes. This is wrong for FileStreamSink, because the streaming QueryExecution (i.e. IncrementalExecution) should be used for correctly incrementalizing aggregation. The addition of watermarks in SPARK-18124, file stream sink should logically supports aggregation + watermark + append mode. But actually it fails with
      ```
      16:23:07.389 ERROR org.apache.spark.sql.execution.streaming.StreamExecution: Query query-0 terminated with error
      java.lang.AssertionError: assertion failed: No plan for EventTimeWatermark timestamp#7: timestamp, interval 10 seconds
      +- LocalRelation [timestamp#7]
      
      	at scala.Predef$.assert(Predef.scala:170)
      	at org.apache.spark.sql.catalyst.planning.QueryPlanner.plan(QueryPlanner.scala:92)
      	at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:77)
      	at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:74)
      	at scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)
      	at scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)
      	at scala.collection.Iterator$class.foreach(Iterator.scala:893)
      	at scala.collection.AbstractIterator.foreach(Iterator.scala:1336)
      	at scala.collection.TraversableOnce$class.foldLeft(TraversableOnce.scala:157)
      	at scala.collection.AbstractIterator.foldLeft(Iterator.scala:1336)
      	at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:74)
      	at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:66)
      	at scala.collection.Iterator$$anon$12.nextCur(Iterator.scala:434)
      	at scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:440)
      	at org.apache.spark.sql.catalyst.planning.QueryPlanner.plan(QueryPlanner.scala:92)
      	at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:77)
      	at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:74)
      ```
      
      This PR fixes it by passing the correct query execution.
      
      ## How was this patch tested?
      New unit test
      
      Author: Tathagata Das <tathagata.das1565@gmail.com>
      
      Closes #15885 from tdas/SPARK-18440.
      1ae4652b
    • Weiqing Yang's avatar
      [SPARK-18417][YARN] Define 'spark.yarn.am.port' in yarn config object · 5bcb9a7f
      Weiqing Yang authored
      ## What changes were proposed in this pull request?
      This PR is to define 'spark.yarn.am.port' in yarn config.scala just like other Yarn configurations. That makes code easier to maintain.
      
      ## How was this patch tested?
      Build passed & tested some Yarn unit tests.
      
      Author: Weiqing Yang <yangweiqing001@gmail.com>
      
      Closes #15858 from weiqingy/yarn.
      5bcb9a7f
    • Burak Yavuz's avatar
      [SPARK-18337] Complete mode memory sinks should be able to recover from checkpoints · 2afdaa98
      Burak Yavuz authored
      ## What changes were proposed in this pull request?
      
      It would be nice if memory sinks can also recover from checkpoints. For correctness reasons, the only time we should support it is in `Complete` OutputMode. We can support this in CompleteMode, because the output of the StateStore is already persisted in the checkpoint directory.
      
      ## How was this patch tested?
      
      Unit test
      
      Author: Burak Yavuz <brkyvz@gmail.com>
      
      Closes #15801 from brkyvz/mem-stream.
      2afdaa98
    • Aaditya Ramesh's avatar
      [SPARK-13027][STREAMING] Added batch time as a parameter to updateStateByKey · 6f9e598c
      Aaditya Ramesh authored
      Added RDD batch time as an input parameter to the update function in updateStateByKey.
      
      Author: Aaditya Ramesh <aramesh@conviva.com>
      
      Closes #11122 from aramesh117/SPARK-13027.
      6f9e598c
    • genmao.ygm's avatar
      [SPARK-18379][SQL] Make the parallelism of parallelPartitionDiscovery configurable. · 745ab8bc
      genmao.ygm authored
      ## What changes were proposed in this pull request?
      
      The largest parallelism in PartitioningAwareFileIndex #listLeafFilesInParallel() is 10000 in hard code. We may need to make this number configurable. And in PR, I reduce it to 100.
      
      ## How was this patch tested?
      
      Existing ut.
      
      Author: genmao.ygm <genmao.ygm@genmaoygmdeMacBook-Air.local>
      Author: dylon <hustyugm@gmail.com>
      
      Closes #15829 from uncleGen/SPARK-18379.
      745ab8bc
    • Herman van Hovell's avatar
      [SPARK-18300][SQL] Do not apply foldable propagation with expand as a child. · f14ae490
      Herman van Hovell authored
      ## What changes were proposed in this pull request?
      The `FoldablePropagation` optimizer rule, pulls foldable values out from under an `Expand`. This breaks the `Expand` in two ways:
      
      - It rewrites the output attributes of the `Expand`. We explicitly define output attributes for `Expand`, these are (unfortunately) considered as part of the expressions of the `Expand` and can be rewritten.
      - Expand can actually change the column (it will typically re-use the attributes or the underlying plan). This means that we cannot safely propagate the expressions from under an `Expand`.
      
      This PR fixes this and (hopefully) other issues by explicitly whitelisting allowed operators.
      
      ## How was this patch tested?
      Added tests to `FoldablePropagationSuite` and to `SQLQueryTestSuite`.
      
      Author: Herman van Hovell <hvanhovell@databricks.com>
      
      Closes #15857 from hvanhovell/SPARK-18300.
      f14ae490
    • Zheng RuiFeng's avatar
      [SPARK-18427][DOC] Update docs of mllib.KMeans · 33be4da5
      Zheng RuiFeng authored
      ## What changes were proposed in this pull request?
      1,Remove `runs` from docs of mllib.KMeans
      2,Add notes for `k` according to comments in sources
      ## How was this patch tested?
      existing tests
      
      Author: Zheng RuiFeng <ruifengz@foxmail.com>
      
      Closes #15873 from zhengruifeng/update_doc_mllib_kmeans.
      Unverified
      33be4da5
    • Michael Gummelt's avatar
      [SPARK-18232][MESOS] Support CNI · d89bfc92
      Michael Gummelt authored
      ## What changes were proposed in this pull request?
      
      Adds support for CNI-isolated containers
      
      ## How was this patch tested?
      
      I launched SparkPi both with and without `spark.mesos.network.name`, and verified the job completed successfully.
      
      Author: Michael Gummelt <mgummelt@mesosphere.io>
      
      Closes #15740 from mgummelt/spark-342-cni.
      d89bfc92
  3. Nov 14, 2016
    • gatorsmile's avatar
      [SPARK-18430][SQL] Fixed Exception Messages when Hitting an Invocation Exception of Function Lookup · 86430cc4
      gatorsmile authored
      ### What changes were proposed in this pull request?
      When the exception is an invocation exception during function lookup, we return a useless/confusing error message:
      
      For example,
      ```Scala
      df.selectExpr("concat_ws()")
      ```
      Below is the error message we got:
      ```
      null; line 1 pos 0
      org.apache.spark.sql.AnalysisException: null; line 1 pos 0
      ```
      
      To get the meaningful error message, we need to get the cause. The fix is exactly the same as what we did in https://github.com/apache/spark/pull/12136. After the fix, the message we got is the exception issued in the constuctor of function implementation:
      ```
      requirement failed: concat_ws requires at least one argument.; line 1 pos 0
      org.apache.spark.sql.AnalysisException: requirement failed: concat_ws requires at least one argument.; line 1 pos 0
      ```
      
      ### How was this patch tested?
      Added test cases.
      
      Author: gatorsmile <gatorsmile@gmail.com>
      
      Closes #15878 from gatorsmile/functionNotFound.
      86430cc4
    • Zheng RuiFeng's avatar
      [SPARK-18428][DOC] Update docs for GraphX · c31def1d
      Zheng RuiFeng authored
      ## What changes were proposed in this pull request?
      1, Add link of `VertexRDD` and `EdgeRDD`
      2, Notify in `Vertex and Edge RDDs` that not all methods are listed
      3, `VertexID` -> `VertexId`
      
      ## How was this patch tested?
      No tests, only docs is modified
      
      Author: Zheng RuiFeng <ruifengz@foxmail.com>
      
      Closes #15875 from zhengruifeng/update_graphop_doc.
      c31def1d
    • Michael Armbrust's avatar
      [SPARK-18124] Observed delay based Event Time Watermarks · c0718782
      Michael Armbrust authored
      This PR adds a new method `withWatermark` to the `Dataset` API, which can be used specify an _event time watermark_.  An event time watermark allows the streaming engine to reason about the point in time after which we no longer expect to see late data.  This PR also has augmented `StreamExecution` to use this watermark for several purposes:
        - To know when a given time window aggregation is finalized and thus results can be emitted when using output modes that do not allow updates (e.g. `Append` mode).
        - To minimize the amount of state that we need to keep for on-going aggregations, by evicting state for groups that are no longer expected to change.  Although, we do still maintain all state if the query requires (i.e. if the event time is not present in the `groupBy` or when running in `Complete` mode).
      
      An example that emits windowed counts of records, waiting up to 5 minutes for late data to arrive.
      ```scala
      df.withWatermark("eventTime", "5 minutes")
        .groupBy(window($"eventTime", "1 minute") as 'window)
        .count()
        .writeStream
        .format("console")
        .mode("append") // In append mode, we only output finalized aggregations.
        .start()
      ```
      
      ### Calculating the watermark.
      The current event time is computed by looking at the `MAX(eventTime)` seen this epoch across all of the partitions in the query minus some user defined _delayThreshold_.  An additional constraint is that the watermark must increase monotonically.
      
      Note that since we must coordinate this value across partitions occasionally, the actual watermark used is only guaranteed to be at least `delay` behind the actual event time.  In some cases we may still process records that arrive more than delay late.
      
      This mechanism was chosen for the initial implementation over processing time for two reasons:
        - it is robust to downtime that could affect processing delay
        - it does not require syncing of time or timezones between the producer and the processing engine.
      
      ### Other notable implementation details
       - A new trigger metric `eventTimeWatermark` outputs the current value of the watermark.
       - We mark the event time column in the `Attribute` metadata using the key `spark.watermarkDelay`.  This allows downstream operations to know which column holds the event time.  Operations like `window` propagate this metadata.
       - `explain()` marks the watermark with a suffix of `-T${delayMs}` to ease debugging of how this information is propagated.
       - Currently, we don't filter out late records, but instead rely on the state store to avoid emitting records that are both added and filtered in the same epoch.
      
      ### Remaining in this PR
       - [ ] The test for recovery is currently failing as we don't record the watermark used in the offset log.  We will need to do so to ensure determinism, but this is deferred until #15626 is merged.
      
      ### Other follow-ups
      There are some natural additional features that we should consider for future work:
       - Ability to write records that arrive too late to some external store in case any out-of-band remediation is required.
       - `Update` mode so you can get partial results before a group is evicted.
       - Other mechanisms for calculating the watermark.  In particular a watermark based on quantiles would be more robust to outliers.
      
      Author: Michael Armbrust <michael@databricks.com>
      
      Closes #15702 from marmbrus/watermarks.
      c0718782
    • Nattavut Sutyanyong's avatar
      [SPARK-17348][SQL] Incorrect results from subquery transformation · bd85603b
      Nattavut Sutyanyong authored
      ## What changes were proposed in this pull request?
      
      Return an Analysis exception when there is a correlated non-equality predicate in a subquery and the correlated column from the outer reference is not from the immediate parent operator of the subquery. This PR prevents incorrect results from subquery transformation in such case.
      
      Test cases, both positive and negative tests, are added.
      
      ## How was this patch tested?
      
      sql/test, catalyst/test, hive/test, and scenarios that will produce incorrect results without this PR and product correct results when subquery transformation does happen.
      
      Author: Nattavut Sutyanyong <nsy.can@gmail.com>
      
      Closes #15763 from nsyca/spark-17348.
      bd85603b
    • Zheng RuiFeng's avatar
      [SPARK-11496][GRAPHX][FOLLOWUP] Add param checking for runParallelPersonalizedPageRank · 75934457
      Zheng RuiFeng authored
      ## What changes were proposed in this pull request?
      add the param checking to keep in line with other algos
      
      ## How was this patch tested?
      existing tests
      
      Author: Zheng RuiFeng <ruifengz@foxmail.com>
      
      Closes #15876 from zhengruifeng/param_check_runParallelPersonalizedPageRank.
      Unverified
      75934457
    • cody koeninger's avatar
      [SPARK-17510][STREAMING][KAFKA] config max rate on a per-partition basis · 89d1fa58
      cody koeninger authored
      ## What changes were proposed in this pull request?
      
      Allow configuration of max rate on a per-topicpartition basis.
      ## How was this patch tested?
      
      Unit tests.
      
      The reporter (Jeff Nadler) said he could test on his workload, so let's wait on that report.
      
      Author: cody koeninger <cody@koeninger.org>
      
      Closes #15132 from koeninger/SPARK-17510.
      89d1fa58
    • Tathagata Das's avatar
      [SPARK-18416][STRUCTURED STREAMING] Fixed temp file leak in state store · bdfe60ac
      Tathagata Das authored
      ## What changes were proposed in this pull request?
      
      StateStore.get() causes temporary files to be created immediately, even if the store is not used to make updates for new version. The temp file is not closed as store.commit() is not called in those cases, thus keeping the output stream to temp file open forever.
      
      This PR fixes it by opening the temp file only when there are updates being made.
      
      ## How was this patch tested?
      
      New unit test
      
      Author: Tathagata Das <tathagata.das1565@gmail.com>
      
      Closes #15859 from tdas/SPARK-18416.
      bdfe60ac
    • Noritaka Sekiyama's avatar
      [SPARK-18432][DOC] Changed HDFS default block size from 64MB to 128MB · 9d07ceee
      Noritaka Sekiyama authored
      Changed HDFS default block size from 64MB to 128MB.
      https://issues.apache.org/jira/browse/SPARK-18432
      
      Author: Noritaka Sekiyama <moomindani@gmail.com>
      
      Closes #15879 from moomindani/SPARK-18432.
      9d07ceee
    • WangTaoTheTonic's avatar
      [SPARK-18396][HISTORYSERVER] Duration" column makes search result confused,... · 637a0bb8
      WangTaoTheTonic authored
      [SPARK-18396][HISTORYSERVER] Duration" column makes search result confused, maybe we should make it unsearchable
      
      ## What changes were proposed in this pull request?
      
      When we search data in History Server, it will check if any columns contains the search string. Duration is represented as long value in table, so if we search simple string like "003", "111", the duration containing "003", ‘111“ will be showed, which make not much sense to users.
      We cannot simply transfer the long value to meaning format like "1 h", "3.2 min" because they are also used for sorting. Better way to handle it is ban "Duration" columns from searching.
      
      ## How was this patch tested
      
      manually tests.
      
      Before("local-1478225166651" pass the filter because its duration in long value, which is "257244245" contains search string "244"):
      ![before](https://cloud.githubusercontent.com/assets/5276001/20203166/f851ffc6-a7ff-11e6-8fe6-91a90ca92b23.jpg)
      
      After:
      ![after](https://cloud.githubusercontent.com/assets/5276001/20178646/2129fbb0-a78d-11e6-9edb-39f885ce3ed0.jpg)
      
      Author: WangTaoTheTonic <wangtao111@huawei.com>
      
      Closes #15838 from WangTaoTheTonic/duration.
      Unverified
      637a0bb8
    • actuaryzhang's avatar
      [SPARK-18166][MLLIB] Fix Poisson GLM bug due to wrong requirement of response values · ae6cddb7
      actuaryzhang authored
      ## What changes were proposed in this pull request?
      
      The current implementation of Poisson GLM seems to allow only positive values. This is incorrect since the support of Poisson includes the origin. The bug is easily fixed by changing the test of the Poisson variable from  'require(y **>** 0.0' to  'require(y **>=** 0.0'.
      
      mengxr  srowen
      
      Author: actuaryzhang <actuaryzhang10@gmail.com>
      Author: actuaryzhang <actuaryzhang@uber.com>
      
      Closes #15683 from actuaryzhang/master.
      Unverified
      ae6cddb7
    • Sean Owen's avatar
      [SPARK-18382][WEBUI] "run at null:-1" in UI when no file/line info in call site info · f95b124c
      Sean Owen authored
      ## What changes were proposed in this pull request?
      
      Avoid reporting null/-1 file / line number in call sites if encountering StackTraceElement without this info
      
      ## How was this patch tested?
      
      Existing tests
      
      Author: Sean Owen <sowen@cloudera.com>
      
      Closes #15862 from srowen/SPARK-18382.
      f95b124c
  4. Nov 13, 2016
    • Yanbo Liang's avatar
      [SPARK-18412][SPARKR][ML] Fix exception for some SparkR ML algorithms training on libsvm data · 07be232e
      Yanbo Liang authored
      ## What changes were proposed in this pull request?
      * Fix the following exceptions which throws when ```spark.randomForest```(classification), ```spark.gbt```(classification), ```spark.naiveBayes``` and ```spark.glm```(binomial family) were fitted on libsvm data.
      ```
      java.lang.IllegalArgumentException: requirement failed: If label column already exists, forceIndexLabel can not be set with true.
      ```
      See [SPARK-18412](https://issues.apache.org/jira/browse/SPARK-18412) for more detail about how to reproduce this bug.
      * Refactor out ```getFeaturesAndLabels``` to RWrapperUtils, since lots of ML algorithm wrappers use this function.
      * Drop some unwanted columns when making prediction.
      
      ## How was this patch tested?
      Add unit test.
      
      Author: Yanbo Liang <ybliang8@gmail.com>
      
      Closes #15851 from yanboliang/spark-18412.
      07be232e
    • Denny Lee's avatar
      [SPARK-18426][STRUCTURED STREAMING] Python Documentation Fix for Structured... · b91a51bb
      Denny Lee authored
      [SPARK-18426][STRUCTURED STREAMING] Python Documentation Fix for Structured Streaming Programming Guide
      
      ## What changes were proposed in this pull request?
      
      Update the python section of the Structured Streaming Guide from .builder() to .builder
      
      ## How was this patch tested?
      
      Validated documentation and successfully running the test example.
      
      Please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before opening a pull request.
      
      'Builder' object is not callable object hence changed .builder() to
      .builder
      
      Author: Denny Lee <dennylee@gallifrey.local>
      
      Closes #15872 from dennyglee/master.
      b91a51bb
  5. Nov 12, 2016
    • Holden Karau's avatar
      [SPARK-18418] Fix flags for make_binary_release for hadoop profile · 1386fd28
      Holden Karau authored
      ## What changes were proposed in this pull request?
      
      Fix the flags used to specify the hadoop version
      
      ## How was this patch tested?
      
      Manually tested as part of https://github.com/apache/spark/pull/15659 by having the build succeed.
      
      cc joshrosen
      
      Author: Holden Karau <holden@us.ibm.com>
      
      Closes #15860 from holdenk/minor-fix-release-build-script.
      1386fd28
    • Yanbo Liang's avatar
      [SPARK-14077][ML][FOLLOW-UP] Minor refactor and cleanup for NaiveBayes · 22cb3a06
      Yanbo Liang authored
      ## What changes were proposed in this pull request?
      * Refactor out ```trainWithLabelCheck``` and make ```mllib.NaiveBayes``` call into it.
      * Avoid capturing the outer object for ```modelType```.
      * Move ```requireNonnegativeValues``` and ```requireZeroOneBernoulliValues``` to companion object.
      
      ## How was this patch tested?
      Existing tests.
      
      Author: Yanbo Liang <ybliang8@gmail.com>
      
      Closes #15826 from yanboliang/spark-14077-2.
      22cb3a06
    • Guoqiang Li's avatar
      [SPARK-18375][SPARK-18383][BUILD][CORE] Upgrade netty to 4.0.42.Final · bc41d997
      Guoqiang Li authored
      ## What changes were proposed in this pull request?
      
      One of the important changes for 4.0.42.Final is "Support any FileRegion implementation when using epoll transport netty/netty#5825".
      In 4.0.42.Final, `MessageWithHeader` can work properly when `spark.[shuffle|rpc].io.mode` is set to epoll
      
      ## How was this patch tested?
      
      Existing tests
      
      Author: Guoqiang Li <witgo@qq.com>
      
      Closes #15830 from witgo/SPARK-18375_netty-4.0.42.
      Unverified
      bc41d997
Loading