Skip to content
Snippets Groups Projects
  1. Dec 28, 2015
    • Yaron Weinsberg's avatar
      [SPARK-12517] add default RDD name for one created via sc.textFile · 73b70f07
      Yaron Weinsberg authored
      The feature was first added at commit: 7b877b27 but was later removed (probably by mistake) at commit: fc8b5819.
      This change sets the default path of RDDs created via sc.textFile(...) to the path argument.
      
      Here is the symptom:
      
      * Using spark-1.5.2-bin-hadoop2.6:
      
      scala> sc.textFile("/home/root/.bashrc").name
      res5: String = null
      
      scala> sc.binaryFiles("/home/root/.bashrc").name
      res6: String = /home/root/.bashrc
      
      * while using Spark 1.3.1:
      
      scala> sc.textFile("/home/root/.bashrc").name
      res0: String = /home/root/.bashrc
      
      scala> sc.binaryFiles("/home/root/.bashrc").name
      res1: String = /home/root/.bashrc
      
      Author: Yaron Weinsberg <wyaron@gmail.com>
      Author: yaron <yaron@il.ibm.com>
      
      Closes #10456 from wyaron/master.
      73b70f07
    • Kevin Yu's avatar
      [SPARK-12231][SQL] create a combineFilters' projection when we call buildPartitionedTableScan · fd50df41
      Kevin Yu authored
      Hello Michael & All:
      
      We have some issues to submit the new codes in the other PR(#10299), so we closed that PR and open this one with the fix.
      
      The reason for the previous failure is that the projection for the scan when there is a filter that is not pushed down (the "left-over" filter) could be different, in elements or ordering, from the original projection.
      
      With this new codes, the approach to solve this problem is:
      
      Insert a new Project if the "left-over" filter is nonempty and (the original projection is not empty and the projection for the scan has more than one elements which could otherwise cause different ordering in projection).
      
      We create 3 test cases to cover the otherwise failure cases.
      
      Author: Kevin Yu <qyu@us.ibm.com>
      
      Closes #10388 from kevinyu98/spark-12231.
      fd50df41
    • Wenchen Fan's avatar
      [HOT-FIX] bypass hive test when parse logical plan to json · 8543997f
      Wenchen Fan authored
      https://github.com/apache/spark/pull/10311 introduces some rare, non-deterministic flakiness for hive udf tests, see https://github.com/apache/spark/pull/10311#issuecomment-166548851
      
      I can't reproduce it locally, and may need more time to investigate, a quick solution is: bypass hive tests for json serialization.
      
      Author: Wenchen Fan <wenchen@databricks.com>
      
      Closes #10430 from cloud-fan/hot-fix.
      8543997f
    • Josh Rosen's avatar
      [SPARK-12508][PROJECT-INFRA] Fix minor bugs in dev/tests/pr_public_classes.sh script · ab6bedd8
      Josh Rosen authored
      This patch fixes a handful of minor bugs in the `dev/tests/pr_public_classes.sh` script, which is used by the `run_tests_jenkins` script to detect the addition of new public classes:
      
      - Account for differences between BSD and GNU `sed` in order to allow the script to run on OS X.
      - Diff `$ghprbActualCommit^...$ghprbActualCommit ` instead of `master...$ghprbActualCommit`: since `ghprbActualCommit` is a merge commit which results from merging the PR into the target branch, this will give us the desired diff and will avoid certain race-conditions which could lead to false-positives.
      - Use `echo -e` instead of `echo` so that newline characters are handled correctly in output. This should fix a formatting glitch which caused the output to appear on a single line in the GitHub comment (see [the SC2028 page](https://github.com/koalaman/shellcheck/wiki/SC2028) on the Shellcheck wiki for more details).
      
      Author: Josh Rosen <joshrosen@databricks.com>
      
      Closes #10455 from JoshRosen/fix-pr-public-classes-test.
      ab6bedd8
    • Cheng Lian's avatar
      [SPARK-12218] Fixes ORC conjunction predicate push down · 8e23d8db
      Cheng Lian authored
      This PR is a follow-up of PR #10362.
      
      Two major changes:
      
      1.  The fix introduced in #10362 is OK for Parquet, but may disable ORC PPD in many cases
      
          PR #10362 stops converting an `AND` predicate if any branch is inconvertible.  On the other hand, `OrcFilters` combines all filters into a single big conjunction first and then tries to convert it into ORC `SearchArgument`.  This means, if any filter is inconvertible, no filters can be pushed down.  This PR fixes this issue by finding out all convertible filters first before doing the actual conversion.
      
          The reason behind the current implementation is mostly due to the limitation of ORC `SearchArgument` builder, which is documented in this PR in detail.
      
      1.  Copied the `AND` predicate fix for ORC from #10362 to avoid merge conflict.
      
      Same as #10362, this PR targets master (2.0.0-SNAPSHOT), branch-1.6, and branch-1.5.
      
      Author: Cheng Lian <lian@databricks.com>
      
      Closes #10377 from liancheng/spark-12218.fix-orc-conjunction-ppd.
      8e23d8db
    • jerryshao's avatar
      [SPARK-12353][STREAMING][PYSPARK] Fix countByValue inconsistent output in Python API · 8d494009
      jerryshao authored
      The semantics of Python countByValue is different from Scala API, it is more like countDistinctValue, so here change to make it consistent with Scala/Java API.
      
      Author: jerryshao <sshao@hortonworks.com>
      
      Closes #10350 from jerryshao/SPARK-12353.
      8d494009
    • felixcheung's avatar
      [SPARK-12515][SQL][DOC] minor doc update for read.jdbc · 5aa2710c
      felixcheung authored
      Author: felixcheung <felixcheung_m@hotmail.com>
      
      Closes #10465 from felixcheung/dfreaderjdbcdoc.
      5aa2710c
    • gatorsmile's avatar
      [SPARK-12520] [PYSPARK] Correct Descriptions and Add Use Cases in Equi-Join · 9ab296ec
      gatorsmile authored
      After reading the JIRA https://issues.apache.org/jira/browse/SPARK-12520, I double checked the code.
      
      For example, users can do the Equi-Join like
        ```df.join(df2, 'name', 'outer').select('name', 'height').collect()```
      - There exists a bug in 1.5 and 1.4. The code just ignores the third parameter (join type) users pass. However, the join type we called is `Inner`, even if the user-specified type is the other type (e.g., `Outer`).
      - After a PR: https://github.com/apache/spark/pull/8600, the 1.6 does not have such an issue, but the description has not been updated.
      
      Plan to submit another PR to fix 1.5 and issue an error message if users specify a non-inner join type when using Equi-Join.
      
      Author: gatorsmile <gatorsmile@gmail.com>
      
      Closes #10477 from gatorsmile/pyOuterJoin.
      9ab296ec
  2. Dec 25, 2015
  3. Dec 24, 2015
    • pierre-borckmans's avatar
      [SPARK-12440][CORE] Avoid setCheckpoint warning when directory is not local · ea4aab7e
      pierre-borckmans authored
      In SparkContext method `setCheckpointDir`, a warning is issued when spark master is not local and the passed directory for the checkpoint dir appears to be local.
      
      In practice, when relying on HDFS configuration file and using a relative path for the checkpoint directory (using an incomplete URI without HDFS scheme, ...), this warning should not be issued and might be confusing.
      In fact, in this case, the checkpoint directory is successfully created, and the checkpointing mechanism works as expected.
      
      This PR uses the `FileSystem` instance created with the given directory, and checks whether it is local or not.
      (The rationale is that since this same `FileSystem` instance is used to create the checkpoint dir anyway and can therefore be reliably used to determine if it is local or not).
      
      The warning is only issued if the directory is not local, on top of the existing conditions.
      
      Author: pierre-borckmans <pierre.borckmans@realimpactanalytics.com>
      
      Closes #10392 from pierre-borckmans/SPARK-12440_CheckpointDir_Warning_NonLocal.
      ea4aab7e
    • CK50's avatar
      [SPARK-12010][SQL] Spark JDBC requires support for column-name-free INSERT syntax · 502476e4
      CK50 authored
      In the past Spark JDBC write only worked with technologies which support the following INSERT statement syntax (JdbcUtils.scala: insertStatement()):
      
      INSERT INTO $table VALUES ( ?, ?, ..., ? )
      
      But some technologies require a list of column names:
      
      INSERT INTO $table ( $colNameList ) VALUES ( ?, ?, ..., ? )
      
      This was blocking the use of e.g. the Progress JDBC Driver for Cassandra.
      
      Another limitation is that syntax 1 relies no the dataframe field ordering match that of the target table. This works fine, as long as the target table has been created by writer.jdbc().
      
      If the target table contains more columns (not created by writer.jdbc()), then the insert fails due mismatch of number of columns or their data types.
      
      This PR switches to the recommended second INSERT syntax. Column names are taken from datafram field names.
      
      Author: CK50 <christian.kurz@oracle.com>
      
      Closes #10380 from CK50/master-SPARK-12010-2.
      502476e4
    • Kazuaki Ishizaki's avatar
      [SPARK-12311][CORE] Restore previous value of "os.arch" property in test... · 39204661
      Kazuaki Ishizaki authored
      [SPARK-12311][CORE] Restore previous value of "os.arch" property in test suites after forcing to set specific value to "os.arch" property
      
      Restore the original value of os.arch property after each test
      
      Since some of tests forced to set the specific value to os.arch property, we need to set the original value.
      
      Author: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
      
      Closes #10289 from kiszk/SPARK-12311.
      39204661
    • Kazuaki Ishizaki's avatar
      [SPARK-12502][BUILD][PYTHON] Script /dev/run-tests fails when IBM Java is used · 9e85bb71
      Kazuaki Ishizaki authored
      fix an exception with IBM JDK by removing update field from a JavaVersion tuple. This is because IBM JDK does not have information on update '_xx'
      
      Author: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
      
      Closes #10463 from kiszk/SPARK-12502.
      9e85bb71
  4. Dec 23, 2015
    • Adrian Bridgett's avatar
      [SPARK-12499][BUILD] don't force MAVEN_OPTS · ead6abf7
      Adrian Bridgett authored
      allow the user to override MAVEN_OPTS (2GB wasn't sufficient for me)
      
      Author: Adrian Bridgett <adrian@smop.co.uk>
      
      Closes #10448 from abridgett/feature/do_not_force_maven_opts.
      ead6abf7
    • Sean Owen's avatar
      [SPARK-12500][CORE] Fix Tachyon deprecations; pull Tachyon dependency into one class · ae1f54aa
      Sean Owen authored
      Fix Tachyon deprecations; pull Tachyon dependency into `TachyonBlockManager` only
      
      CC calvinjia as I probably need a double-check that the usage of the new API is correct.
      
      Author: Sean Owen <sowen@cloudera.com>
      
      Closes #10449 from srowen/SPARK-12500.
      ae1f54aa
    • pierre-borckmans's avatar
      [SPARK-12477][SQL] - Tungsten projection fails for null values in array fields · 43b2a639
      pierre-borckmans authored
      Accessing null elements in an array field fails when tungsten is enabled.
      It works in Spark 1.3.1, and in Spark > 1.5 with Tungsten disabled.
      
      This PR solves this by checking if the accessed element in the array field is null, in the generated code.
      
      Example:
      ```
      // Array of String
      case class AS( as: Seq[String] )
      val dfAS = sc.parallelize( Seq( AS ( Seq("a",null,"b") ) ) ).toDF
      dfAS.registerTempTable("T_AS")
      for (i <- 0 to 2) { println(i + " = " + sqlContext.sql(s"select as[$i] from T_AS").collect.mkString(","))}
      ```
      
      With Tungsten disabled:
      ```
      0 = [a]
      1 = [null]
      2 = [b]
      ```
      
      With Tungsten enabled:
      ```
      0 = [a]
      15/12/22 09:32:50 ERROR Executor: Exception in task 7.0 in stage 1.0 (TID 15)
      java.lang.NullPointerException
      	at org.apache.spark.sql.catalyst.expressions.UnsafeRowWriters$UTF8StringWriter.getSize(UnsafeRowWriters.java:90)
      	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificUnsafeProjection.apply(Unknown Source)
      	at org.apache.spark.sql.execution.TungstenProject$$anonfun$3$$anonfun$apply$3.apply(basicOperators.scala:90)
      	at org.apache.spark.sql.execution.TungstenProject$$anonfun$3$$anonfun$apply$3.apply(basicOperators.scala:88)
      	at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
      	at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
      	at scala.collection.Iterator$class.foreach(Iterator.scala:727)
      	at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
      ```
      
      Author: pierre-borckmans <pierre.borckmans@realimpactanalytics.com>
      
      Closes #10429 from pierre-borckmans/SPARK-12477_Tungsten-Projection-Null-Element-In-Array.
      43b2a639
    • Liang-Chi Hsieh's avatar
      [SPARK-11164][SQL] Add InSet pushdown filter back for Parquet · 50301c0a
      Liang-Chi Hsieh authored
      When the filter is ```"b in ('1', '2')"```, the filter is not pushed down to Parquet. Thanks!
      
      Author: gatorsmile <gatorsmile@gmail.com>
      Author: xiaoli <lixiao1983@gmail.com>
      Author: Xiao Li <xiaoli@Xiaos-MacBook-Pro.local>
      
      Closes #10278 from gatorsmile/parquetFilterNot.
      50301c0a
  5. Dec 22, 2015
  6. Dec 21, 2015
Loading