-
- Downloads
[SPARK-6990][BUILD] Add Java linting script; fix minor warnings
This replaces https://github.com/apache/spark/pull/9696 Invoke Checkstyle and print any errors to the console, failing the step. Use Google's style rules modified according to https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide Some important checks are disabled (see TODOs in `checkstyle.xml`) due to multiple violations being present in the codebase. Suggest fixing those TODOs in a separate PR(s). More on Checkstyle can be found on the [official website](http://checkstyle.sourceforge.net/). Sample output (from [build 46345](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46345/consoleFull)) (duplicated because I run the build twice with different profiles): > Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java:[217,7] (coding) MissingSwitchDefault: switch without "default" clause. > [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[198,10] (modifier) ModifierOrder: 'protected' modifier out of order with the JLS suggestions. > [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java:[217,7] (coding) MissingSwitchDefault: switch without "default" clause. > [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[198,10] (modifier) ModifierOrder: 'protected' modifier out of order with the JLS suggestions. > [error] running /home/jenkins/workspace/SparkPullRequestBuilder2/dev/lint-java ; received return code 1 Also fix some of the minor violations that didn't require sweeping changes. Apologies for the previous botched PRs - I finally figured out the issue. cr: JoshRosen, pwendell > I state that the contribution is my original work, and I license the work to the project under the project's open source license. Author: Dmitry Erastov <derastov@gmail.com> Closes #9867 from dskrvk/master.
Showing
- checkstyle-suppressions.xml 33 additions, 0 deletionscheckstyle-suppressions.xml
- checkstyle.xml 164 additions, 0 deletionscheckstyle.xml
- core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java 1 addition, 1 deletion...ark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
- core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java 2 additions, 2 deletions...apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
- dev/lint-java 30 additions, 0 deletionsdev/lint-java
- dev/run-tests-jenkins.py 1 addition, 0 deletionsdev/run-tests-jenkins.py
- dev/run-tests.py 7 additions, 0 deletionsdev/run-tests.py
- dev/sparktestsupport/__init__.py 1 addition, 0 deletionsdev/sparktestsupport/__init__.py
- examples/src/main/java/org/apache/spark/examples/ml/JavaSimpleParamsExample.java 1 addition, 1 deletion...org/apache/spark/examples/ml/JavaSimpleParamsExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaLDAExample.java 2 additions, 1 deletion.../java/org/apache/spark/examples/mllib/JavaLDAExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaMultiLabelClassificationMetricsExample.java 6 additions, 6 deletions...les/mllib/JavaMultiLabelClassificationMetricsExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaMulticlassClassificationMetricsExample.java 6 additions, 6 deletions...les/mllib/JavaMulticlassClassificationMetricsExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaRankingMetricsExample.java 2 additions, 2 deletions...pache/spark/examples/mllib/JavaRankingMetricsExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaRecommendationExample.java 1 addition, 1 deletion...pache/spark/examples/mllib/JavaRecommendationExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaRegressionMetricsExample.java 2 additions, 1 deletion...he/spark/examples/mllib/JavaRegressionMetricsExample.java
- examples/src/main/java/org/apache/spark/examples/streaming/JavaSqlNetworkWordCount.java 2 additions, 2 deletions...che/spark/examples/streaming/JavaSqlNetworkWordCount.java
- mllib/src/test/java/org/apache/spark/ml/feature/JavaStringIndexerSuite.java 3 additions, 3 deletions...a/org/apache/spark/ml/feature/JavaStringIndexerSuite.java
- mllib/src/test/java/org/apache/spark/mllib/clustering/JavaLDASuite.java 1 addition, 1 deletion.../java/org/apache/spark/mllib/clustering/JavaLDASuite.java
- network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java 1 addition, 1 deletion...e/spark/network/shuffle/ExternalShuffleBlockResolver.java
- network/shuffle/src/test/java/org/apache/spark/network/sasl/SaslIntegrationSuite.java 1 addition, 1 deletion...a/org/apache/spark/network/sasl/SaslIntegrationSuite.java
Loading
Please register or sign in to comment