Skip to content
Snippets Groups Projects
Commit 9493b079 authored by Xiangrui Meng's avatar Xiangrui Meng
Browse files

[SPARK-16118][MLLIB] add getDropLast to OneHotEncoder

## What changes were proposed in this pull request?

We forgot the getter of `dropLast` in `OneHotEncoder`

## How was this patch tested?

unit test

Author: Xiangrui Meng <meng@databricks.com>

Closes #13821 from mengxr/SPARK-16118.
parent f4e8c31a
No related branches found
No related tags found
No related merge requests found
...@@ -59,6 +59,10 @@ class OneHotEncoder @Since("1.4.0") (@Since("1.4.0") override val uid: String) e ...@@ -59,6 +59,10 @@ class OneHotEncoder @Since("1.4.0") (@Since("1.4.0") override val uid: String) e
new BooleanParam(this, "dropLast", "whether to drop the last category") new BooleanParam(this, "dropLast", "whether to drop the last category")
setDefault(dropLast -> true) setDefault(dropLast -> true)
/** @group getParam */
@Since("2.0.0")
def getDropLast: Boolean = $(dropLast)
/** @group setParam */ /** @group setParam */
@Since("1.4.0") @Since("1.4.0")
def setDropLast(value: Boolean): this.type = set(dropLast, value) def setDropLast(value: Boolean): this.type = set(dropLast, value)
......
...@@ -49,7 +49,9 @@ class OneHotEncoderSuite ...@@ -49,7 +49,9 @@ class OneHotEncoderSuite
val encoder = new OneHotEncoder() val encoder = new OneHotEncoder()
.setInputCol("labelIndex") .setInputCol("labelIndex")
.setOutputCol("labelVec") .setOutputCol("labelVec")
.setDropLast(false) assert(encoder.getDropLast === true)
encoder.setDropLast(false)
assert(encoder.getDropLast === false)
val encoded = encoder.transform(transformed) val encoded = encoder.transform(transformed)
val output = encoded.select("id", "labelVec").rdd.map { r => val output = encoded.select("id", "labelVec").rdd.map { r =>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment