From 9493b079a0050f0a6f4936c17622b96fb185b67f Mon Sep 17 00:00:00 2001
From: Xiangrui Meng <meng@databricks.com>
Date: Tue, 21 Jun 2016 15:52:31 -0700
Subject: [PATCH] [SPARK-16118][MLLIB] add getDropLast to OneHotEncoder
## What changes were proposed in this pull request?
We forgot the getter of `dropLast` in `OneHotEncoder`
## How was this patch tested?
unit test
Author: Xiangrui Meng <meng@databricks.com>
Closes #13821 from mengxr/SPARK-16118.
---
.../scala/org/apache/spark/ml/feature/OneHotEncoder.scala | 4 ++++
.../org/apache/spark/ml/feature/OneHotEncoderSuite.scala | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala b/mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala
index 4fafc1e349..01828ede6b 100644
--- a/mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala
+++ b/mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala
@@ -59,6 +59,10 @@ class OneHotEncoder @Since("1.4.0") (@Since("1.4.0") override val uid: String) e
new BooleanParam(this, "dropLast", "whether to drop the last category")
setDefault(dropLast -> true)
+ /** @group getParam */
+ @Since("2.0.0")
+ def getDropLast: Boolean = $(dropLast)
+
/** @group setParam */
@Since("1.4.0")
def setDropLast(value: Boolean): this.type = set(dropLast, value)
diff --git a/mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderSuite.scala b/mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderSuite.scala
index 7841b4fbc7..d41eeec132 100644
--- a/mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderSuite.scala
@@ -49,7 +49,9 @@ class OneHotEncoderSuite
val encoder = new OneHotEncoder()
.setInputCol("labelIndex")
.setOutputCol("labelVec")
- .setDropLast(false)
+ assert(encoder.getDropLast === true)
+ encoder.setDropLast(false)
+ assert(encoder.getDropLast === false)
val encoded = encoder.transform(transformed)
val output = encoded.select("id", "labelVec").rdd.map { r =>
--
GitLab