-
- Downloads
[SPARK-3854][BUILD] Scala style: require spaces before `{`.
## What changes were proposed in this pull request? Since the opening curly brace, '{', has many usages as discussed in [SPARK-3854](https://issues.apache.org/jira/browse/SPARK-3854), this PR adds a ScalaStyle rule to prevent '){' pattern for the following majority pattern and fixes the code accordingly. If we enforce this in ScalaStyle from now, it will improve the Scala code quality and reduce review time. ``` // Correct: if (true) { println("Wow!") } // Incorrect: if (true){ println("Wow!") } ``` IntelliJ also shows new warnings based on this. ## How was this patch tested? Pass the Jenkins ScalaStyle test. Author: Dongjoon Hyun <dongjoon@apache.org> Closes #11637 from dongjoon-hyun/SPARK-3854.
Showing
- core/src/main/scala/org/apache/spark/rdd/RDD.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/rdd/RDD.scala
- core/src/main/scala/org/apache/spark/rpc/RpcTimeout.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/rpc/RpcTimeout.scala
- core/src/main/scala/org/apache/spark/scheduler/InputFormatInfo.scala 1 addition, 1 deletion...in/scala/org/apache/spark/scheduler/InputFormatInfo.scala
- core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala 1 addition, 1 deletion.../scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
- core/src/main/scala/org/apache/spark/status/api/v1/OneStageResource.scala 1 addition, 1 deletion...ala/org/apache/spark/status/api/v1/OneStageResource.scala
- core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala 1 addition, 1 deletion.../main/scala/org/apache/spark/storage/BlockManagerId.scala
- core/src/test/scala/org/apache/spark/AccumulatorSuite.scala 1 addition, 1 deletioncore/src/test/scala/org/apache/spark/AccumulatorSuite.scala
- core/src/test/scala/org/apache/spark/ImplicitOrderingSuite.scala 1 addition, 1 deletion...c/test/scala/org/apache/spark/ImplicitOrderingSuite.scala
- core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala 1 addition, 1 deletion...g/apache/spark/deploy/history/ApplicationCacheSuite.scala
- examples/src/main/scala/org/apache/spark/examples/LocalFileLR.scala 1 addition, 1 deletion...rc/main/scala/org/apache/spark/examples/LocalFileLR.scala
- examples/src/main/scala/org/apache/spark/examples/LocalKMeans.scala 1 addition, 1 deletion...rc/main/scala/org/apache/spark/examples/LocalKMeans.scala
- examples/src/main/scala/org/apache/spark/examples/LocalLR.scala 2 additions, 2 deletions...es/src/main/scala/org/apache/spark/examples/LocalLR.scala
- examples/src/main/scala/org/apache/spark/examples/SparkHdfsLR.scala 1 addition, 1 deletion...rc/main/scala/org/apache/spark/examples/SparkHdfsLR.scala
- examples/src/main/scala/org/apache/spark/examples/SparkLR.scala 2 additions, 2 deletions...es/src/main/scala/org/apache/spark/examples/SparkLR.scala
- examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala 1 addition, 1 deletion.../org/apache/spark/examples/streaming/ActorWordCount.scala
- mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala 4 additions, 4 deletionsmllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala
- mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala 1 addition, 1 deletion...scala/org/apache/spark/ml/classification/NaiveBayes.scala
- mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala 1 addition, 1 deletion...la/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala
- mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala 1 addition, 1 deletion...la/org/apache/spark/mllib/classification/NaiveBayes.scala
- mllib/src/main/scala/org/apache/spark/mllib/evaluation/MultilabelMetrics.scala 2 additions, 2 deletions...org/apache/spark/mllib/evaluation/MultilabelMetrics.scala
Loading
Please register or sign in to comment