-
- Downloads
[SPARK-14718][SQL] Avoid mutating ExprCode in doGenCode
## What changes were proposed in this pull request? The `doGenCode` method currently takes in an `ExprCode`, mutates it and returns the java code to evaluate the given expression. It should instead just return a new `ExprCode` to avoid passing around mutable objects during code generation. ## How was this patch tested? Existing Tests Author: Sameer Agarwal <sameer@databricks.com> Closes #12483 from sameeragarwal/new-exprcode-2.
Showing
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala 1 addition, 1 deletion...a/org/apache/spark/sql/catalyst/analysis/unresolved.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala 5 additions, 9 deletions...pache/spark/sql/catalyst/expressions/BoundAttribute.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala 3 additions, 3 deletions...cala/org/apache/spark/sql/catalyst/expressions/Cast.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala 23 additions, 31 deletions...rg/apache/spark/sql/catalyst/expressions/Expression.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InputFileName.scala 3 additions, 4 deletions...apache/spark/sql/catalyst/expressions/InputFileName.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala 3 additions, 5 deletions.../sql/catalyst/expressions/MonotonicallyIncreasingID.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ReferenceToExpressions.scala 3 additions, 5 deletions...ark/sql/catalyst/expressions/ReferenceToExpressions.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala 3 additions, 4 deletions.../org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala 9 additions, 9 deletions...org/apache/spark/sql/catalyst/expressions/SortOrder.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SparkPartitionID.scala 2 additions, 3 deletions...che/spark/sql/catalyst/expressions/SparkPartitionID.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala 3 additions, 3 deletions...rg/apache/spark/sql/catalyst/expressions/TimeWindow.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala 23 additions, 29 deletions...rg/apache/spark/sql/catalyst/expressions/arithmetic.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitwiseExpressions.scala 1 addition, 1 deletion...e/spark/sql/catalyst/expressions/bitwiseExpressions.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenFallback.scala 5 additions, 7 deletions...rk/sql/catalyst/expressions/codegen/CodegenFallback.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala 2 additions, 2 deletions...spark/sql/catalyst/expressions/collectionOperations.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala 23 additions, 33 deletions...e/spark/sql/catalyst/expressions/complexTypeCreator.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala 4 additions, 4 deletions...park/sql/catalyst/expressions/complexTypeExtractors.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala 12 additions, 16 deletions...ark/sql/catalyst/expressions/conditionalExpressions.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala 49 additions, 57 deletions.../spark/sql/catalyst/expressions/datetimeExpressions.scala
- sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala 4 additions, 4 deletions...e/spark/sql/catalyst/expressions/decimalExpressions.scala
Loading
Please register or sign in to comment