Skip to content
  • Dongjoon Hyun's avatar
    20fd2541
    [SPARK-14011][CORE][SQL] Enable `LineLength` Java checkstyle rule · 20fd2541
    Dongjoon Hyun authored
    ## What changes were proposed in this pull request?
    
    [Spark Coding Style Guide](https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide) has 100-character limit on lines, but it's disabled for Java since 11/09/15. This PR enables **LineLength** checkstyle again. To help that, this also introduces **RedundantImport** and **RedundantModifier**, too. The following is the diff on `checkstyle.xml`.
    
    ```xml
    -        <!-- TODO: 11/09/15 disabled - the lengths are currently > 100 in many places -->
    -        <!--
             <module name="LineLength">
                 <property name="max" value="100"/>
                 <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
             </module>
    -        -->
             <module name="NoLineWrap"/>
             <module name="EmptyBlock">
                 <property name="option" value="TEXT"/>
     -167,5 +164,7
             </module>
             <module name="CommentsIndentation"/>
             <module name="UnusedImports"/>
    +        <module name="RedundantImport"/>
    +        <module name="RedundantModifier"/>
    ```
    
    ## How was this patch tested?
    
    Currently, `lint-java` is disabled in Jenkins. It needs a manual test.
    After passing the Jenkins tests, `dev/lint-java` should passes locally.
    
    Author: Dongjoon Hyun <dongjoon@apache.org>
    
    Closes #11831 from dongjoon-hyun/SPARK-14011.
    20fd2541
    [SPARK-14011][CORE][SQL] Enable `LineLength` Java checkstyle rule
    Dongjoon Hyun authored
    ## What changes were proposed in this pull request?
    
    [Spark Coding Style Guide](https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide) has 100-character limit on lines, but it's disabled for Java since 11/09/15. This PR enables **LineLength** checkstyle again. To help that, this also introduces **RedundantImport** and **RedundantModifier**, too. The following is the diff on `checkstyle.xml`.
    
    ```xml
    -        <!-- TODO: 11/09/15 disabled - the lengths are currently > 100 in many places -->
    -        <!--
             <module name="LineLength">
                 <property name="max" value="100"/>
                 <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
             </module>
    -        -->
             <module name="NoLineWrap"/>
             <module name="EmptyBlock">
                 <property name="option" value="TEXT"/>
     -167,5 +164,7
             </module>
             <module name="CommentsIndentation"/>
             <module name="UnusedImports"/>
    +        <module name="RedundantImport"/>
    +        <module name="RedundantModifier"/>
    ```
    
    ## How was this patch tested?
    
    Currently, `lint-java` is disabled in Jenkins. It needs a manual test.
    After passing the Jenkins tests, `dev/lint-java` should passes locally.
    
    Author: Dongjoon Hyun <dongjoon@apache.org>
    
    Closes #11831 from dongjoon-hyun/SPARK-14011.
Loading