-
- Downloads
[SPARK-14011][CORE][SQL] Enable `LineLength` Java checkstyle rule
## What changes were proposed in this pull request? [Spark Coding Style Guide](https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide) has 100-character limit on lines, but it's disabled for Java since 11/09/15. This PR enables **LineLength** checkstyle again. To help that, this also introduces **RedundantImport** and **RedundantModifier**, too. The following is the diff on `checkstyle.xml`. ```xml - <!-- TODO: 11/09/15 disabled - the lengths are currently > 100 in many places --> - <!-- <module name="LineLength"> <property name="max" value="100"/> <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/> </module> - --> <module name="NoLineWrap"/> <module name="EmptyBlock"> <property name="option" value="TEXT"/> -167,5 +164,7 </module> <module name="CommentsIndentation"/> <module name="UnusedImports"/> + <module name="RedundantImport"/> + <module name="RedundantModifier"/> ``` ## How was this patch tested? Currently, `lint-java` is disabled in Jenkins. It needs a manual test. After passing the Jenkins tests, `dev/lint-java` should passes locally. Author: Dongjoon Hyun <dongjoon@apache.org> Closes #11831 from dongjoon-hyun/SPARK-14011.
Showing
- common/network-common/src/main/java/org/apache/spark/network/TransportContext.java 2 additions, 1 deletion.../main/java/org/apache/spark/network/TransportContext.java
- common/network-common/src/main/java/org/apache/spark/network/client/StreamCallback.java 3 additions, 3 deletions.../java/org/apache/spark/network/client/StreamCallback.java
- common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java 1 addition, 1 deletion...g/apache/spark/network/client/TransportClientFactory.java
- common/network-common/src/main/java/org/apache/spark/network/protocol/Message.java 2 additions, 2 deletions.../main/java/org/apache/spark/network/protocol/Message.java
- common/network-common/src/main/java/org/apache/spark/network/protocol/RequestMessage.java 0 additions, 2 deletions...ava/org/apache/spark/network/protocol/RequestMessage.java
- common/network-common/src/main/java/org/apache/spark/network/protocol/ResponseMessage.java 0 additions, 2 deletions...va/org/apache/spark/network/protocol/ResponseMessage.java
- common/network-common/src/main/java/org/apache/spark/network/sasl/SaslMessage.java 2 additions, 2 deletions.../main/java/org/apache/spark/network/sasl/SaslMessage.java
- common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java 2 additions, 2 deletions...g/apache/spark/network/server/OneForOneStreamManager.java
- common/network-common/src/main/java/org/apache/spark/network/server/TransportChannelHandler.java 2 additions, 2 deletions.../apache/spark/network/server/TransportChannelHandler.java
- common/network-common/src/main/java/org/apache/spark/network/util/ByteUnit.java 1 addition, 1 deletion...src/main/java/org/apache/spark/network/util/ByteUnit.java
- common/network-common/src/main/java/org/apache/spark/network/util/SystemPropertyConfigProvider.java 0 additions, 2 deletions...ache/spark/network/util/SystemPropertyConfigProvider.java
- common/network-common/src/main/java/org/apache/spark/network/util/TransportFrameDecoder.java 1 addition, 1 deletion.../org/apache/spark/network/util/TransportFrameDecoder.java
- common/network-shuffle/src/main/java/org/apache/spark/network/sasl/ShuffleSecretManager.java 0 additions, 1 deletion...a/org/apache/spark/network/sasl/ShuffleSecretManager.java
- common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java 2 additions, 1 deletion...he/spark/network/shuffle/ExternalShuffleBlockHandler.java
- common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java 3 additions, 1 deletion...e/spark/network/shuffle/ExternalShuffleBlockResolver.java
- common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockFetcher.java 1 addition, 1 deletion...rg/apache/spark/network/shuffle/RetryingBlockFetcher.java
- common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlockTransferMessage.java 2 additions, 2 deletions.../spark/network/shuffle/protocol/BlockTransferMessage.java
- common/network-shuffle/src/test/java/org/apache/spark/network/sasl/SaslIntegrationSuite.java 2 additions, 1 deletion...a/org/apache/spark/network/sasl/SaslIntegrationSuite.java
- common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandlerSuite.java 2 additions, 1 deletion...ark/network/shuffle/ExternalShuffleBlockHandlerSuite.java
- common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java 1 addition, 1 deletion...ain/java/org/apache/spark/util/sketch/Murmur3_x86_32.java
Loading
Please register or sign in to comment