Skip to content
Snippets Groups Projects
  • Dmitry Erastov's avatar
    d0d82227
    [SPARK-6990][BUILD] Add Java linting script; fix minor warnings · d0d82227
    Dmitry Erastov authored
    This replaces https://github.com/apache/spark/pull/9696
    
    Invoke Checkstyle and print any errors to the console, failing the step.
    Use Google's style rules modified according to
    https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
    Some important checks are disabled (see TODOs in `checkstyle.xml`) due to
    multiple violations being present in the codebase.
    
    Suggest fixing those TODOs in a separate PR(s).
    
    More on Checkstyle can be found on the [official website](http://checkstyle.sourceforge.net/).
    
    Sample output (from [build 46345](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46345/consoleFull)) (duplicated because I run the build twice with different profiles):
    
    > Checkstyle checks failed at following occurrences:
    [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java:[217,7] (coding) MissingSwitchDefault: switch without "default" clause.
    > [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[198,10] (modifier) ModifierOrder: 'protected' modifier out of order with the JLS suggestions.
    > [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java:[217,7] (coding) MissingSwitchDefault: switch without "default" clause.
    > [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[198,10] (modifier) ModifierOrder: 'protected' modifier out of order with the JLS suggestions.
    > [error] running /home/jenkins/workspace/SparkPullRequestBuilder2/dev/lint-java ; received return code 1
    
    Also fix some of the minor violations that didn't require sweeping changes.
    
    Apologies for the previous botched PRs - I finally figured out the issue.
    
    cr: JoshRosen, pwendell
    
    > I state that the contribution is my original work, and I license the work to the project under the project's open source license.
    
    Author: Dmitry Erastov <derastov@gmail.com>
    
    Closes #9867 from dskrvk/master.
    d0d82227
    History
    [SPARK-6990][BUILD] Add Java linting script; fix minor warnings
    Dmitry Erastov authored
    This replaces https://github.com/apache/spark/pull/9696
    
    Invoke Checkstyle and print any errors to the console, failing the step.
    Use Google's style rules modified according to
    https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
    Some important checks are disabled (see TODOs in `checkstyle.xml`) due to
    multiple violations being present in the codebase.
    
    Suggest fixing those TODOs in a separate PR(s).
    
    More on Checkstyle can be found on the [official website](http://checkstyle.sourceforge.net/).
    
    Sample output (from [build 46345](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46345/consoleFull)) (duplicated because I run the build twice with different profiles):
    
    > Checkstyle checks failed at following occurrences:
    [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java:[217,7] (coding) MissingSwitchDefault: switch without "default" clause.
    > [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[198,10] (modifier) ModifierOrder: 'protected' modifier out of order with the JLS suggestions.
    > [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java:[217,7] (coding) MissingSwitchDefault: switch without "default" clause.
    > [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[198,10] (modifier) ModifierOrder: 'protected' modifier out of order with the JLS suggestions.
    > [error] running /home/jenkins/workspace/SparkPullRequestBuilder2/dev/lint-java ; received return code 1
    
    Also fix some of the minor violations that didn't require sweeping changes.
    
    Apologies for the previous botched PRs - I finally figured out the issue.
    
    cr: JoshRosen, pwendell
    
    > I state that the contribution is my original work, and I license the work to the project under the project's open source license.
    
    Author: Dmitry Erastov <derastov@gmail.com>
    
    Closes #9867 from dskrvk/master.