Skip to content
  • Dongjoon Hyun's avatar
    91fed8e9
    [SPARK-3854][BUILD] Scala style: require spaces before `{`. · 91fed8e9
    Dongjoon Hyun authored
    ## What changes were proposed in this pull request?
    
    Since the opening curly brace, '{', has many usages as discussed in [SPARK-3854](https://issues.apache.org/jira/browse/SPARK-3854), this PR adds a ScalaStyle rule to prevent '){' pattern  for the following majority pattern and fixes the code accordingly. If we enforce this in ScalaStyle from now, it will improve the Scala code quality and reduce review time.
    ```
    // Correct:
    if (true) {
      println("Wow!")
    }
    
    // Incorrect:
    if (true){
       println("Wow!")
    }
    ```
    IntelliJ also shows new warnings based on this.
    
    ## How was this patch tested?
    
    Pass the Jenkins ScalaStyle test.
    
    Author: Dongjoon Hyun <dongjoon@apache.org>
    
    Closes #11637 from dongjoon-hyun/SPARK-3854.
    91fed8e9
    [SPARK-3854][BUILD] Scala style: require spaces before `{`.
    Dongjoon Hyun authored
    ## What changes were proposed in this pull request?
    
    Since the opening curly brace, '{', has many usages as discussed in [SPARK-3854](https://issues.apache.org/jira/browse/SPARK-3854), this PR adds a ScalaStyle rule to prevent '){' pattern  for the following majority pattern and fixes the code accordingly. If we enforce this in ScalaStyle from now, it will improve the Scala code quality and reduce review time.
    ```
    // Correct:
    if (true) {
      println("Wow!")
    }
    
    // Incorrect:
    if (true){
       println("Wow!")
    }
    ```
    IntelliJ also shows new warnings based on this.
    
    ## How was this patch tested?
    
    Pass the Jenkins ScalaStyle test.
    
    Author: Dongjoon Hyun <dongjoon@apache.org>
    
    Closes #11637 from dongjoon-hyun/SPARK-3854.
Loading