Skip to content
Snippets Groups Projects
  • Marcelo Vanzin's avatar
    3f958a99
    [SPARK-21731][BUILD] Upgrade scalastyle to 0.9. · 3f958a99
    Marcelo Vanzin authored
    This version fixes a few issues in the import order checker; it provides
    better error messages, and detects more improper ordering (thus the need
    to change a lot of files in this patch). The main fix is that it correctly
    complains about the order of packages vs. classes.
    
    As part of the above, I moved some "SparkSession" import in ML examples
    inside the "$example on$" blocks; that didn't seem consistent across
    different source files to start with, and avoids having to add more on/off blocks
    around specific imports.
    
    The new scalastyle also seems to have a better header detector, so a few
    license headers had to be updated to match the expected indentation.
    
    Author: Marcelo Vanzin <vanzin@cloudera.com>
    
    Closes #18943 from vanzin/SPARK-21731.
    3f958a99
    History
    [SPARK-21731][BUILD] Upgrade scalastyle to 0.9.
    Marcelo Vanzin authored
    This version fixes a few issues in the import order checker; it provides
    better error messages, and detects more improper ordering (thus the need
    to change a lot of files in this patch). The main fix is that it correctly
    complains about the order of packages vs. classes.
    
    As part of the above, I moved some "SparkSession" import in ML examples
    inside the "$example on$" blocks; that didn't seem consistent across
    different source files to start with, and avoids having to add more on/off blocks
    around specific imports.
    
    The new scalastyle also seems to have a better header detector, so a few
    license headers had to be updated to match the expected indentation.
    
    Author: Marcelo Vanzin <vanzin@cloudera.com>
    
    Closes #18943 from vanzin/SPARK-21731.