removing unused imports in ControllerTest

from null to non-null as device moved

[BSC-3247] DeviceManager must learn devices correctly when the ethernet destination MAC in an ARP response is different from sender hardware address.  A device corresponding to the sender hardware address and sender protocol address needs to be learned.  Update unit tests accordingly.

commit 8f1917bd34be3c81f4fc049b4736e4fbe3f1cd0e
Author: Shudong Zhou <shudongzhou@gmail.com>
Date:   Thu Jan 31 00:59:16 2013 -0800

    Fix singleton task initialization

commit dd361d41dafca32cae1f2e8f6be0725633082dc5
Author: Shudong Zhou <shudongzhou@gmail.com>
Date:   Wed Jan 30 21:58:22 2013 -0800

    Send HA role request to switch when master controller gets permission error

commit c18d87699bda09c07707a36e026fb5a4e6301e0d
Author: Shudong Zhou <shudongzhou@gmail.com>
Date:   Wed Jan 30 20:33:51 2013 -0800

    Dampen frequency of HA role transitions

commit ed7c1bd030ce6826510c52427ccea1f8631e09fa
Author: Shudong Zhou <shudongzhou@gmail.com>
Date:   Wed Jan 30 20:04:43 2013 -0800

    Update unit test for HA role change

commit 32dc0b95b34a82902f1309aebbe469b4b713b356
Merge: 4963170 63a85a2
Author: abat <abat@bigswitch.com>
Date:   Wed Jan 30 16:27:28 2013 -0800

    Merge into master from pull request #2414: lower a message level to trace

commit 63a85a28be92ca5c14d826198a572c9e408b0343
Author: Kanzhe Jiang <kanzhe.jiang@bigswitch.com>
Date:   Wed Jan 30 14:55:52 2013 -0800

    lower log level to info

commit 49631705e7393452cd6825ae126e053c6ff3f3a1
Author: Gregor Maier <gregor.maier@bigswitch.com>
Date:   Wed Jan 30 10:10:07 2013 -0800

    Adding debug logging to SwitchPortMatcher. Tweak log levels.

    We'll now log when SwitchPortMatcher can't find the switch or port for a
    packet its trying to match.

commit ca75639f53067087be0b308e3aa72e07bf75d924
Author: Srinivasan Ramasubramanian <srini@bigswitch.com>
Date:   Tue Jan 29 12:20:13 2013 -0800

    Bug fix: When tunnel links are identified, they should not be added to topology switchportlinks.  Update unit tests.

commit 3ee7da2f062834929212a568bf07cb462eb41979
Author: kwanggithub <kwang@clemson.edu>
Date:   Mon Jan 28 11:51:52 2013 -0800

    refactor loadbalancer to not use StaticFlowEntries

commit a0cac00f334970199ca2af9679d927d69fa539ab
Author: Kanzhe Jiang <kanzhe.jiang@bigswitch.com>
Date:   Sun Jan 27 18:05:23 2013 -0800

    notify listeners for device classification first, then listeners for reconcile.

commit 5925b52aa2f0d7aae290dd22d30626bf81e879c3
Author: Srinivasan Ramasubramanian <srini@bigswitch.com>
Date:   Wed Jan 23 01:24:29 2013 -0800

    Refactoring some methods to better support extensibility.

commit ae577282bdc906262cf3fed44eabf685090ca60e
Merge: 9f1613e 1d88cbf
Author: abat <abat@bigswitch.com>
Date:   Mon Jan 21 17:22:21 2013 -0800

    Merge into master from pull request #2255

commit 9f1613e936c5b9485a798486e19670b8dc2dd8eb
Author: Gregor Maier <gregor.maier@bigswitch.com>
Date:   Sat Jan 19 23:25:48 2013 -0800

    Don't use vlans from devices. Use explicitly specified VLAN.

commit 1d88cbff4bc53f8936145abc8ca653fa0d58c9ce
Author: Ronald Li <ronald.li@bigswitch.com>
Date:   Thu Jan 10 18:08:39 2013 -0800

Add an interface method to ITopologyService to get all the switches in the same openflow domain as a given switch id.

Adjustment to attachment point logic.  If a device is learnt on OFPP_LOCAL of a switch, it will stay in that port until the switch is removed or the port goes down.  The attachment point of the device cannot be modified from OFPP_LOCAL, once assigned.

When injecting fake ARP: set sender IP to 0 (ARP probe)
Remove weird IP learning on DHCP-replies:
	WILL BREAK DHCP MANAGER WITH RELAYS

This is a short-term. In the long run we actually do want to prevent
learning on these ports.

BSC-2836

BSC-2837: When returning early from learnDeviceByEntity: process
	deleteQueue
BSC-2836: Do not learn entities on internal ports
BSC-2834: Some device updates get queued before check for concurrent
	modification
BSC-2824: Remove potential incorrect Corrupted Device Index exception

 * use insertion sort when adding entity to device
 * precompute Device.getVlandId() return value

This change is mostly for streamlining and clarifying IDeviceServiceAPI.
* renamed findDestDevice to findClassDevice
* pass an entityClass to findClassDevice instead of the
  "source"/"reference" device.

- event processing in cleanupEntities was exiting prematurely, some device delete
  updates were not being processed
- updated unittest to verify device deletion
- See BSC-2454

Bug fix: Whenever a device with new entity was created that causes a change in attachment point, deviceMoved notification should be sent after the indices are updated.

Update to attachment point logic. NewAP is always given preference if it is not broadcast domain port and its active time is later than oldAP.

Rewrite of reclassify, made learnDeviceByEntity the only place where devices get created or updated (through re-allocation).

Changes to classState map to use IEntityClass name as key now. Also debug logs sprayed around some methods for more visibility if required while debugging.

Update to attachment point comptuation to flag devices flapping between two switch ports.  Enable duplicate mac unit tests.

Reclassify all devices that belong to changed entityclasses or null entity class. And also some fixes to prevent race conditions.

When deleting or allocating a device as a part of reclassify update the device map, primary and class indices to reflect this change.