- Nov 21, 2014
-
-
Ryan Izard authored
-
Ryan Izard authored
Fixed some issues with the Firewall and string compares. There are probably some more things that need to be fixed there.
-
- Nov 14, 2014
-
-
Ryan Izard authored
-
Ryan Izard authored
Removed all deprecated flowcache references and marked all flowcache classes as deprecated. Also TODOed the OFMessageDamper Forwarding module unit test. It will always fail until tthe OFMessageDamper is fixed to ignore the XIDs in OFMessages.
-
Ryan Izard authored
OF1.3 handshake unit tests updated. All unit tests can be run together and have zero errors but one failure. The failure is in Forwarding and is expected for the time being until OFMessageDamper/Loxigen is fixed to ignore XIDs in OFMessages. In the previous commit, the unit tests for the flowcache package were completely removed due to the effort required to fix them. I don't know if completely removing the flowcache package though is the best idea. Even if it's not tested and not proven scalable, people might benefit from being able to look at the code. Thus, I've left the package in, at least for the time being.
-
- Nov 13, 2014
-
-
Ryan Izard authored
This is a scattered commit, but it includes more unit test fixes, including Forwarding and the NotificationManager's interdependency issue the unit tests were having when being run together as a group. It also includes some typo repairs. The last major change is a bug fix in the LinkDiscoveryManager that fixes the long-time issue of LINK_ADDED and PORT_STATUS messages being inconsistent when a link is brought up. The issue was a race condition between the PORT_STATUS update timer to process the queues and the propagation of LLDP packets from one switch to another that cause the LINK_ADDED updates.
-
- Nov 10, 2014
-
-
Ryan Izard authored
-
Ryan Izard authored
Moved a couple annoying debug messaged to trace wrt switch connections. Changed logback.xml to debug and higher-level. Removed unused imports and variables in some places to clean up warnings that have arisen over time/mods. Fixed the LoadBalancer so it works with OF1.0 and OF1.3; it no longer composes OFFlowMods using strings! =)
-
- Nov 07, 2014
-
-
Ryan Izard authored
Mid-way through Forwarding unit tests. Added a sample equals to compare OFPacketIns when the XID does not matter (in net.floodlightcontroller.util.OFMessageComparisonUtils.java).
-
Ryan Izard authored
Forgot to fix Hub after playing with it initially. Now defaults to FLOOD OFPacketOuts at the controller, which means no flows are inserted. The option still exists to insert flows instead.
-
Ryan Izard authored
Firewall working and unit tests working. Found an fixed a couple bugs in the Firewall during the process.
-
Ryan Izard authored
-
Ryan Izard authored
Some Firewall unit test fixes. Went through all code and corrected pi.getInPort() to (pi.getVersion().compareTo(OFVersion.OF_12) < 0 ? pi.getInPort() : pi.getMatch().get(MatchField.IN_PORT)). OF1.2 and greater specifies the ingress port as an OXM in the Match.
-
- Nov 05, 2014
-
-
Ryan Izard authored
-
Ryan Izard authored
-
- Nov 03, 2014
-
-
https://github.com/rizard/floodlightRyan Izard authored
Pull in Hung-Wei's WEBUI changes. Then, push Ryan's unit test changes to remote again.
-
Ryan Izard authored
Fixed DeviceManagerImplTest unit tests. TODO: With OpenFlowJ-Loxi, an untagged VLAN can be denoted with VlanVid.ZERO. Presently, it's VlanVid.of(-1), which was the case before integration of the new library. It makes more sense to have it as ZERO I think.
-
Ryan Izard authored
Thanks Hung-Wei!
-
- Nov 01, 2014
-
-
hwchiu authored
1. Modify the wm/core/switch/${id}/flow/json's return format, it use a array to shows the flow entries, e.g. I think this format is more convenience for restapi caller. "flows": [ { "byte_count": "2498", "cookie": "0", "duration_sec": "4", "flags": "0", "hard_timeout_sec": "0", "idle_timeout_sec": "0", "instructions": { "apply_actions": { "output": "-3" } }, "match": {}, "packet_count": "33", "priority": "32768", "table_id": "0", "version": "OF_13" }, { "byte_count": "0", "cookie": "9007199254740992", "duration_sec": "2", "flags": "0", "hard_timeout_sec": "0", "idle_timeout_sec": "5", "instructions": { "apply_actions": { "output": "1" } }, "match": { "dl_dst": "e6:85:22:16:59:87", "dl_src": "b2:ac:81:4a:92:57", "dl_type": "2054", "ingress_port": "2" }, "packet_count": "0", "priority": "0", "table_id": "0", "version": "OF_13" }, 2. Adding the new coloum write_actions and replace the original action field to apply_actions. 3. Since the OF1.1+ use the OXM format to present the match filed, we don't need to use the wildcard to check what kind of the fild be used in the flow, we can directly use the query result. If we want to make it compatible with OF1.0, we need to use the version field to check in the javascript and modify the way how we get the match rules. 4. It has only been test with the default forwarding module and the flow entries looks right. It need to be tested with other match rule and actions. 5. replace the tab with 4-spaces
-
hwchiu authored
complete the serialization of PortDescStats and PortStats, also modfiy the webui to fit the new-format of restapi
-
hwchiu authored
-
- Oct 31, 2014
-
-
hwchiu authored
1. Serialize the return value of /wm/core/controller/switches/json 2. Serialize the OFDescStatReply 3. Serialize THE OFAggregateStatREply 4. Modify the webui to make it fit the current restapi format
-
Ryan Izard authored
Fixed some DeviceManager unit tests and (not quite a bug but) an issue converting an Entity to a SyncEntity, which requires primitives for serialization. I tried to supply the MacAddress, IPv4Address, etc JSON serializer classes via the @JsonSerialize annotation, but the serializer still didn't do it...
-
Ryan Izard authored
VirtualNetworkFilter unit tests complete. Found bug in Entity in devicemanger package where null doesn't mean no switch or port anymore; DatapathId.NONE and OFPort.ZERO do instead. An object will always be there (not null), but it's contents will specify whether the Entity has a switch port or not.
-
- Oct 30, 2014
-
-
Ryan Izard authored
Fixed LoadBalancer unit tests! TODO: Need to change the LB to not compose flows with strings...yuck. This will make OF1.0/OF1.1+ support integration easier.
-
Ryan Izard authored
Commented out all of EventTest.java's format-checking unit test. Why does the format need to be checked to see if it's ISO8601? Java's java.util.Date toString() returns a different format (with spaces), but I don't see what the big deal is at this point.
-
Ryan Izard authored
Fixed OFMessageDamper unit tests and removed context from within OFMessageDamper (not used with a switch write anymore).
-
Ryan Izard authored
-
- Oct 27, 2014
-
-
Ryan Izard authored
-
Ryan Izard authored
Fixed more unit tests. Found another place in TopologyInstance.java where I accidentally used shallow compares instead of deep when checking to see if two links are symmetrical.
-
- Oct 26, 2014
-
-
Ryan Izard authored
Fixed some more unit tests. Have some device manager issues maybe. Many of the remaining unit tests to fix seem to tie back to the device manager.
-
- Oct 10, 2014
-
-
Ryan Izard authored
Fixed some more unit tests. In the process, discovered some errors in more overridden equals(). Also, discovered I had inadvertently commented out an important few lines the routing module uses to set the ingress port of flows used in the route. Those lines are now ported and use MatchUtils to copy the Match properly.
-
- Sep 16, 2014
-
-
Ryan Izard authored
switchDisconnected() already called when the main connection is closed (so it wasn't a bug after all).
-
Ryan Izard authored
Undo weaving of IDebugCounterService into the OFSwitch class for previous SwitchCounters implementation.
-
Ryan Izard authored
Changed methodology after realizing the counters are already defined in OFConnectionCounters, which makes more sense since switches can have multiple connections now. OFConnectionCounters now refactored to remove counters when a switch disconnects.
-
Ryan Izard authored
Added SwitchCounters.java. Similar to SwitchManagerCounters.java, the SwitchCounters class contained within contains and maintains all the counters for a switch instance. When the switch disconnects, either accidentally or forcefully with disconnect(), the SwitchCounters will be removed from the IDebugCounterService, since they will no longer be valid or meaningful if the switch never reconnects.
-
- Sep 15, 2014
-
-
Ryan Izard authored
Changed DebugCounterServiceImpl's registerCounter(). It turns out we do need to always return a reference to an IDebugCounter. If the counter we're trying to add is already there, return the existing IDebugCounter, else if the counter is not there, add it, and return it instead.
-
- Sep 14, 2014
-
-
Ryan Izard authored
-
Ryan Izard authored
Add 'json' to the DeviceManager's REST API to be consistent with the rest. Ending the path in a / is bad REST practice.
-
Ryan Izard authored
-