Skip to content
Snippets Groups Projects
Commit 48ed56eb authored by Alex Ellis's avatar Alex Ellis
Browse files

Add design/approved label to contribution guide


Signed-off-by: default avatarAlex Ellis <alexellis2@gmail.com>
parent 6754e5b8
No related branches found
No related tags found
No related merge requests found
......@@ -49,13 +49,15 @@ What makes a good proposal?
* Mock-up screenshots or examples of how the CLI would work
* Clear examples of how to reproduce any issue the proposal is addressing
If you are proposing a new tool or service please do due diligence. Does this tool already exist? Can we reuse it? For example: a timer / CRON-type scheduler for invoking functions.
Once your proposal receives a `design/approved` label you may go ahead and start work on your Pull Request.
If you are proposing a new tool or service please do due diligence. Does this tool already exist in a 3rd party project or library? Can we reuse it? For example: a timer / CRON-type scheduler for invoking functions is a well-solved problem, do we need to reinvent the wheel?
#### What happens if you ignore the process?
If you raise a PR without following the process, it will be closed immediately and marked as invalid, this is because you have chosen not to honour the community guidelines.
If you raise a PR without following the process, it will be closed immediately and marked as invalid. You may have also made an honest mistake or you may have have chosen not to follow the contribution guidelines.
This is not the end of the discussion, but it's not a great first impression for the community either. At that point, you should request comment on your proposal issue from the project lead and core contributors.
This is not the end of the discussion, but it's not a great first impression for the community either. At that point, you should request comment on your proposal issue from the project lead and core contributors. If a label of `design/approved` is applied to your proposal, it means that you can go ahead and start on your PR/implementation.
#### Paperwork for Pull Requests
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment