Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
git-svn-demo
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
raila
git-svn-demo
Commits
99dc7100
Commit
99dc7100
authored
16 years ago
by
raila
Browse files
Options
Downloads
Patches
Plain Diff
Add @Override annotation to generated Java code where appropriate.
Patch from Brian Atkinson <nairb774@gmail.com>.
parent
166169d7
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CONTRIBUTORS.txt
+2
-0
2 additions, 0 deletions
CONTRIBUTORS.txt
src/google/protobuf/compiler/java/java_message.cc
+11
-0
11 additions, 0 deletions
src/google/protobuf/compiler/java/java_message.cc
with
13 additions
and
0 deletions
CONTRIBUTORS.txt
+
2
−
0
View file @
99dc7100
...
@@ -47,3 +47,5 @@ Non-Google patch contributors:
...
@@ -47,3 +47,5 @@ Non-Google patch contributors:
Dilip Joseph <dilip.antony.joseph@gmail.com>
Dilip Joseph <dilip.antony.joseph@gmail.com>
* Heuristic detection of sub-messages when printing unknown fields in
* Heuristic detection of sub-messages when printing unknown fields in
text format.
text format.
Brian Atkinson <nairb774@gmail.com>
* Added @Override annotation to generated Java code where appropriate.
This diff is collapsed.
Click to expand it.
src/google/protobuf/compiler/java/java_message.cc
+
11
−
0
View file @
99dc7100
...
@@ -241,6 +241,7 @@ void MessageGenerator::Generate(io::Printer* printer) {
...
@@ -241,6 +241,7 @@ void MessageGenerator::Generate(io::Printer* printer) {
" return $fileclass$.internal_$identifier$_descriptor;
\n
"
" return $fileclass$.internal_$identifier$_descriptor;
\n
"
"}
\n
"
"}
\n
"
"
\n
"
"
\n
"
"@Override
\n
"
"protected com.google.protobuf.GeneratedMessage.FieldAccessorTable
\n
"
"protected com.google.protobuf.GeneratedMessage.FieldAccessorTable
\n
"
" internalGetFieldAccessorTable() {
\n
"
" internalGetFieldAccessorTable() {
\n
"
" return $fileclass$.internal_$identifier$_fieldAccessorTable;
\n
"
" return $fileclass$.internal_$identifier$_fieldAccessorTable;
\n
"
...
@@ -293,6 +294,7 @@ GenerateMessageSerializationMethods(io::Printer* printer) {
...
@@ -293,6 +294,7 @@ GenerateMessageSerializationMethods(io::Printer* printer) {
ExtensionRangeOrdering
());
ExtensionRangeOrdering
());
printer
->
Print
(
printer
->
Print
(
"@Override
\n
"
"public void writeTo(com.google.protobuf.CodedOutputStream output)
\n
"
"public void writeTo(com.google.protobuf.CodedOutputStream output)
\n
"
" throws java.io.IOException {
\n
"
);
" throws java.io.IOException {
\n
"
);
printer
->
Indent
();
printer
->
Indent
();
...
@@ -331,6 +333,7 @@ GenerateMessageSerializationMethods(io::Printer* printer) {
...
@@ -331,6 +333,7 @@ GenerateMessageSerializationMethods(io::Printer* printer) {
"}
\n
"
"}
\n
"
"
\n
"
"
\n
"
"private int memoizedSerializedSize = -1;
\n
"
"private int memoizedSerializedSize = -1;
\n
"
"@Override
\n
"
"public int getSerializedSize() {
\n
"
"public int getSerializedSize() {
\n
"
" int size = memoizedSerializedSize;
\n
"
" int size = memoizedSerializedSize;
\n
"
" if (size != -1) return size;
\n
"
" if (size != -1) return size;
\n
"
...
@@ -485,19 +488,23 @@ void MessageGenerator::GenerateCommonBuilderMethods(io::Printer* printer) {
...
@@ -485,19 +488,23 @@ void MessageGenerator::GenerateCommonBuilderMethods(io::Printer* printer) {
"
\n
"
"
\n
"
"$classname$ result = new $classname$();
\n
"
"$classname$ result = new $classname$();
\n
"
"
\n
"
"
\n
"
"@Override
\n
"
"protected $classname$ internalGetResult() {
\n
"
"protected $classname$ internalGetResult() {
\n
"
" return result;
\n
"
" return result;
\n
"
"}
\n
"
"}
\n
"
"
\n
"
"
\n
"
"@Override
\n
"
"public Builder clear() {
\n
"
"public Builder clear() {
\n
"
" result = new $classname$();
\n
"
" result = new $classname$();
\n
"
" return this;
\n
"
" return this;
\n
"
"}
\n
"
"}
\n
"
"
\n
"
"
\n
"
"@Override
\n
"
"public Builder clone() {
\n
"
"public Builder clone() {
\n
"
" return new Builder().mergeFrom(result);
\n
"
" return new Builder().mergeFrom(result);
\n
"
"}
\n
"
"}
\n
"
"
\n
"
"
\n
"
"@Override
\n
"
"public com.google.protobuf.Descriptors.Descriptor
\n
"
"public com.google.protobuf.Descriptors.Descriptor
\n
"
" getDescriptorForType() {
\n
"
" getDescriptorForType() {
\n
"
" return $classname$.getDescriptor();
\n
"
" return $classname$.getDescriptor();
\n
"
...
@@ -550,6 +557,7 @@ void MessageGenerator::GenerateCommonBuilderMethods(io::Printer* printer) {
...
@@ -550,6 +557,7 @@ void MessageGenerator::GenerateCommonBuilderMethods(io::Printer* printer) {
if
(
descriptor_
->
file
()
->
options
().
optimize_for
()
==
FileOptions
::
SPEED
)
{
if
(
descriptor_
->
file
()
->
options
().
optimize_for
()
==
FileOptions
::
SPEED
)
{
printer
->
Print
(
printer
->
Print
(
"@Override
\n
"
"public Builder mergeFrom(com.google.protobuf.Message other) {
\n
"
"public Builder mergeFrom(com.google.protobuf.Message other) {
\n
"
" if (other instanceof $classname$) {
\n
"
" if (other instanceof $classname$) {
\n
"
" return mergeFrom(($classname$)other);
\n
"
" return mergeFrom(($classname$)other);
\n
"
...
@@ -586,6 +594,7 @@ void MessageGenerator::GenerateBuilderParsingMethods(io::Printer* printer) {
...
@@ -586,6 +594,7 @@ void MessageGenerator::GenerateBuilderParsingMethods(io::Printer* printer) {
SortFieldsByNumber
(
descriptor_
));
SortFieldsByNumber
(
descriptor_
));
printer
->
Print
(
printer
->
Print
(
"@Override
\n
"
"public Builder mergeFrom(
\n
"
"public Builder mergeFrom(
\n
"
" com.google.protobuf.CodedInputStream input)
\n
"
" com.google.protobuf.CodedInputStream input)
\n
"
" throws java.io.IOException {
\n
"
" throws java.io.IOException {
\n
"
...
@@ -593,6 +602,7 @@ void MessageGenerator::GenerateBuilderParsingMethods(io::Printer* printer) {
...
@@ -593,6 +602,7 @@ void MessageGenerator::GenerateBuilderParsingMethods(io::Printer* printer) {
" com.google.protobuf.ExtensionRegistry.getEmptyRegistry());
\n
"
" com.google.protobuf.ExtensionRegistry.getEmptyRegistry());
\n
"
"}
\n
"
"}
\n
"
"
\n
"
"
\n
"
"@Override
\n
"
"public Builder mergeFrom(
\n
"
"public Builder mergeFrom(
\n
"
" com.google.protobuf.CodedInputStream input,
\n
"
" com.google.protobuf.CodedInputStream input,
\n
"
" com.google.protobuf.ExtensionRegistry extensionRegistry)
\n
"
" com.google.protobuf.ExtensionRegistry extensionRegistry)
\n
"
...
@@ -656,6 +666,7 @@ void MessageGenerator::GenerateBuilderParsingMethods(io::Printer* printer) {
...
@@ -656,6 +666,7 @@ void MessageGenerator::GenerateBuilderParsingMethods(io::Printer* printer) {
void
MessageGenerator
::
GenerateIsInitialized
(
io
::
Printer
*
printer
)
{
void
MessageGenerator
::
GenerateIsInitialized
(
io
::
Printer
*
printer
)
{
printer
->
Print
(
printer
->
Print
(
"@Override
\n
"
"public final boolean isInitialized() {
\n
"
);
"public final boolean isInitialized() {
\n
"
);
printer
->
Indent
();
printer
->
Indent
();
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment