Make function names safe in schedule dot
- Replace "." and "-" with "__"; Juno generates function names that include "." but this seems to produce issues with dot.
Merge request reports
Activity
requested review from @rarbore2
Yes, actually I made that change on a different branch and just never noticed that I didn't merge it into main (I wasn't using dots in Juno function names in the version on main). I'll add that here as well, if that's alright with you.
As a note, if I use dots in function names (which is my preference because it avoids possible conflicts with user names) we may need to be careful in the proc macro to only generate rust code for entry functions (for which I'll only generate valid rust/juno names)
Looking at the Rust docs, I think our best choice is to generate names in the format
_<uid>_<name>
for non-entry functions (entry functions are non-polymorphic and their names are preserved) since Rust allows identifiers to have leading underscores but Juno does not. This will mean we shouldn't need to change the names for dot. I'll close this MR and include this fix in my Juno MR (coming soon).