Implementation of assignment-1.1
5 unresolved threads
5 unresolved threads
Merge request reports
Activity
assigned to @ziyue5
16 16 JFrame frame; 17 17 JFrame gameFrame; 18 18 JFrame frameEnd; 19 19 JButton button1; changed this line in version 5 of the diff
213 214 } else { 214 215 playerNumber.close(); 215 216 } 217 */ 218 numPlayers = 4; changed this line in version 4 of the diff
130 131 deck.setText("<html>" + "Current Playing Deck : " + gamestate.getPlayingDeck() + "</html>"); 131 132 deck.setBounds(80, 80, 80, 24); 132 133 panel.add(deck); 133 134 } changed this line in version 5 of the diff
Peer Review Report
1-This question references the Code Review Checklist available at course website. Select one item from Item 4 (Non Functional requirements) in the checklist, and answer the following questions:
- Which checklist item has been selected? Maintainability.
- Does the code attempt to address the checklist item? Part of.
- Why or why not? The draw or play card action is mainly dependent on the logic written in the corresponding Card class and gameState class. So if we want to maintain or understand the logic of the player, we have to read all of the code in gameState class.
2-Please select one item from the Item 5 (OOAD Principle), and answer the following questions:
- Which checklist item has been selected? Single Responsibility Principle.
- Does the code attempt to address the checklist item? Part of.
- Why or why not? The gameState class covers most of the logic of the game which maybe should be the responsibility of other classes. Maybe the author can consider splitting the functionalities.
3-If applicable, does the author address all the comments you made last week? Yes.
mentioned in commit 5611476a
mentioned in commit e7cbfb0c
Please register or sign in to reply