Skip to content
Snippets Groups Projects
  1. May 13, 2016
    • Holden Karau's avatar
      [SPARK-15061][PYSPARK] Upgrade to Py4J 0.10.1 · 382dbc12
      Holden Karau authored
      ## What changes were proposed in this pull request?
      
      This upgrades to Py4J 0.10.1 which reduces syscal overhead in Java gateway ( see https://github.com/bartdag/py4j/issues/201 ). Related https://issues.apache.org/jira/browse/SPARK-6728 .
      
      ## How was this patch tested?
      
      Existing doctests & unit tests pass
      
      Author: Holden Karau <holden@us.ibm.com>
      
      Closes #13064 from holdenk/SPARK-15061-upgrade-to-py4j-0.10.1.
      382dbc12
    • wm624@hotmail.com's avatar
      [SPARK-14900][ML] spark.ml classification metrics should include accuracy · bdff299f
      wm624@hotmail.com authored
      ## What changes were proposed in this pull request?
      
      (Please fill in changes proposed in this fix)
      Add accuracy to MulticlassMetrics class and add corresponding code in MulticlassClassificationEvaluator.
      
      ## How was this patch tested?
      
      (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
      Scala Unit tests in ml.evaluation
      
      Author: wm624@hotmail.com <wm624@hotmail.com>
      
      Closes #12882 from wangmiao1981/accuracy.
      bdff299f
    • Reynold Xin's avatar
      [SPARK-15310][SQL] Rename HiveTypeCoercion -> TypeCoercion · e1dc8537
      Reynold Xin authored
      ## What changes were proposed in this pull request?
      We originally designed the type coercion rules to match Hive, but over time we have diverged. It does not make sense to call it HiveTypeCoercion anymore. This patch renames it TypeCoercion.
      
      ## How was this patch tested?
      Updated unit tests to reflect the rename.
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #13091 from rxin/SPARK-15310.
      e1dc8537
    • BenFradet's avatar
      [SPARK-13961][ML] spark.ml ChiSqSelector and RFormula should support other numeric types for label · 31f1aebb
      BenFradet authored
      ## What changes were proposed in this pull request?
      
      Made ChiSqSelector and RFormula accept all numeric types for label
      
      ## How was this patch tested?
      
      Unit tests
      
      Author: BenFradet <benjamin.fradet@gmail.com>
      
      Closes #12467 from BenFradet/SPARK-13961.
      31f1aebb
    • sethah's avatar
      [SPARK-15181][ML][PYSPARK] Python API for GLR summaries. · 5b849766
      sethah authored
      ## What changes were proposed in this pull request?
      
      This patch adds a python API for generalized linear regression summaries (training and test). This helps provide feature parity for Python GLMs.
      
      ## How was this patch tested?
      
      Added a unit test to `pyspark.ml.tests`
      
      Author: sethah <seth.hendrickson16@gmail.com>
      
      Closes #12961 from sethah/GLR_summary.
      5b849766
    • Zheng RuiFeng's avatar
      [MINOR][PYSPARK] update _shared_params_code_gen.py · 87d69a01
      Zheng RuiFeng authored
      ## What changes were proposed in this pull request?
      
      1, add arg-checkings for `tol` and `stepSize` to  keep in line with `SharedParamsCodeGen.scala`
      2, fix one typo
      
      ## How was this patch tested?
      local build
      
      Author: Zheng RuiFeng <ruifengz@foxmail.com>
      
      Closes #12996 from zhengruifeng/py_args_checking.
      87d69a01
    • Holden Karau's avatar
      [SPARK-15188] Add missing thresholds param to NaiveBayes in PySpark · d1aadea0
      Holden Karau authored
      ## What changes were proposed in this pull request?
      
      Add missing thresholds param to NiaveBayes
      
      ## How was this patch tested?
      doctests
      
      Author: Holden Karau <holden@us.ibm.com>
      
      Closes #12963 from holdenk/SPARK-15188-add-missing-naive-bayes-param.
      d1aadea0
    • hyukjinkwon's avatar
      [SPARK-13866] [SQL] Handle decimal type in CSV inference at CSV data source. · 51841d77
      hyukjinkwon authored
      ## What changes were proposed in this pull request?
      
      https://issues.apache.org/jira/browse/SPARK-13866
      
      This PR adds the support to infer `DecimalType`.
      Here are the rules between `IntegerType`, `LongType` and `DecimalType`.
      
      #### Infering Types
      
      1. `IntegerType` and then `LongType`are tried first.
      
        ```scala
        Int.MaxValue => IntegerType
        Long.MaxValue => LongType
        ```
      
      2. If it fails, try `DecimalType`.
      
        ```scala
        (Long.MaxValue + 1) => DecimalType(20, 0)
        ```
        This does not try to infer this as `DecimalType` when scale is less than 0.
      
      3. if it fails, try `DoubleType`
        ```scala
        0.1 => DoubleType // This is failed to be inferred as `DecimalType` because it has the scale, 1.
        ```
      
      #### Compatible Types (Merging Types)
      
      For merging types, this is the same with JSON data source. If `DecimalType` is not capable, then it becomes `DoubleType`
      
      ## How was this patch tested?
      
      Unit tests were used and `./dev/run_tests` for code style test.
      
      Author: hyukjinkwon <gurwls223@gmail.com>
      Author: Hyukjin Kwon <gurwls223@gmail.com>
      
      Closes #11724 from HyukjinKwon/SPARK-13866.
      51841d77
    • Reynold Xin's avatar
      [SPARK-14541][SQL] Support IFNULL, NULLIF, NVL and NVL2 · eda2800d
      Reynold Xin authored
      ## What changes were proposed in this pull request?
      This patch adds support for a few SQL functions to improve compatibility with other databases: IFNULL, NULLIF, NVL and NVL2. In order to do this, this patch introduced a RuntimeReplaceable expression trait that allows replacing an unevaluable expression in the optimizer before evaluation.
      
      Note that the semantics are not completely identical to other databases in esoteric cases.
      
      ## How was this patch tested?
      Added a new test suite SQLCompatibilityFunctionSuite.
      
      Closes #12373.
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #13084 from rxin/SPARK-14541.
      eda2800d
  2. May 12, 2016
    • Reynold Xin's avatar
      [SPARK-15306][SQL] Move object expressions into expressions.objects package · ba169c32
      Reynold Xin authored
      ## What changes were proposed in this pull request?
      This patch moves all the object related expressions into expressions.objects package, for better code organization.
      
      ## How was this patch tested?
      N/A
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #13085 from rxin/SPARK-15306.
      ba169c32
    • Sun Rui's avatar
      [SPARK-15202][SPARKR] add dapplyCollect() method for DataFrame in SparkR. · b3930f74
      Sun Rui authored
      ## What changes were proposed in this pull request?
      
      dapplyCollect() applies an R function on each partition of a SparkDataFrame and collects the result back to R as a data.frame.
      ```
      dapplyCollect(df, function(ldf) {...})
      ```
      
      ## How was this patch tested?
      SparkR unit tests.
      
      Author: Sun Rui <sunrui2016@gmail.com>
      
      Closes #12989 from sun-rui/SPARK-15202.
      b3930f74
    • Herman van Hovell's avatar
      [SPARK-10605][SQL] Create native collect_list/collect_set aggregates · bb1362eb
      Herman van Hovell authored
      ## What changes were proposed in this pull request?
      We currently use the Hive implementations for the collect_list/collect_set aggregate functions. This has a few major drawbacks: the use of HiveUDAF (which has quite a bit of overhead) and the lack of support for struct datatypes. This PR adds native implementation of these functions to Spark.
      
      The size of the collected list/set may vary, this means we cannot use the fast, Tungsten, aggregation path to perform the aggregation, and that we fallback to the slower sort based path. Another big issue with these operators is that when the size of the collected list/set grows too large, we can start experiencing large GC pauzes and OOMEs.
      
      This `collect*` aggregates implemented in this PR rely on the sort based aggregate path for correctness. They maintain their own internal buffer which holds the rows for one group at a time. The sortbased aggregation path is triggered by disabling `partialAggregation` for these aggregates (which is kinda funny); this technique is also employed in `org.apache.spark.sql.hiveHiveUDAFFunction`.
      
      I have done some performance testing:
      ```scala
      import org.apache.spark.sql.{Dataset, Row}
      
      sql("create function collect_list2 as 'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFCollectList'")
      
      val df = range(0, 10000000).select($"id", (rand(213123L) * 100000).cast("int").as("grp"))
      df.select(countDistinct($"grp")).show
      
      def benchmark(name: String, plan: Dataset[Row], maxItr: Int = 5): Unit = {
         // Do not measure planning.
         plan1.queryExecution.executedPlan
      
         // Execute the plan a number of times and average the result.
         val start = System.nanoTime
         var i = 0
         while (i < maxItr) {
           plan.rdd.foreach(row => Unit)
           i += 1
         }
         val time = (System.nanoTime - start) / (maxItr * 1000000L)
         println(s"[$name] $maxItr iterations completed in an average time of $time ms.")
      }
      
      val plan1 = df.groupBy($"grp").agg(collect_list($"id"))
      val plan2 = df.groupBy($"grp").agg(callUDF("collect_list2", $"id"))
      
      benchmark("Spark collect_list", plan1)
      ...
      > [Spark collect_list] 5 iterations completed in an average time of 3371 ms.
      
      benchmark("Hive collect_list", plan2)
      ...
      > [Hive collect_list] 5 iterations completed in an average time of 9109 ms.
      ```
      Performance is improved by a factor 2-3.
      
      ## How was this patch tested?
      Added tests to `DataFrameAggregateSuite`.
      
      Author: Herman van Hovell <hvanhovell@questtec.nl>
      
      Closes #12874 from hvanhovell/implode.
      bb1362eb
    • Takuya UESHIN's avatar
      [SPARK-13902][SCHEDULER] Make DAGScheduler not to create duplicate stage. · a57aadae
      Takuya UESHIN authored
      ## What changes were proposed in this pull request?
      
      `DAGScheduler`sometimes generate incorrect stage graph.
      
      Suppose you have the following DAG:
      
      ```
      [A] <--(s_A)-- [B] <--(s_B)-- [C] <--(s_C)-- [D]
                  \                /
                    <-------------
      ```
      
      Note: [] means an RDD, () means a shuffle dependency.
      
      Here, RDD `B` has a shuffle dependency on RDD `A`, and RDD `C` has shuffle dependency on both `B` and `A`. The shuffle dependency IDs are numbers in the `DAGScheduler`, but to make the example easier to understand, let's call the shuffled data from `A` shuffle dependency ID `s_A` and the shuffled data from `B` shuffle dependency ID `s_B`.
      The `getAncestorShuffleDependencies` method in `DAGScheduler` (incorrectly) does not check for duplicates when it's adding ShuffleDependencies to the parents data structure, so for this DAG, when `getAncestorShuffleDependencies` gets called on `C` (previous of the final RDD), `getAncestorShuffleDependencies` will return `s_A`, `s_B`, `s_A` (`s_A` gets added twice: once when the method "visit"s RDD `C`, and once when the method "visit"s RDD `B`). This is problematic because this line of code: https://github.com/apache/spark/blob/8ef3399/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L289 then generates a new shuffle stage for each dependency returned by `getAncestorShuffleDependencies`, resulting in duplicate map stages that compute the map output from RDD `A`.
      
      As a result, `DAGScheduler` generates the following stages and their parents for each shuffle:
      
      | | stage | parents |
      |----|----|----|
      | s_A | ShuffleMapStage 2 | List() |
      | s_B | ShuffleMapStage 1 | List(ShuffleMapStage 0) |
      | s_C | ShuffleMapStage 3 | List(ShuffleMapStage 1, ShuffleMapStage 2) |
      | - | ResultStage 4 | List(ShuffleMapStage 3) |
      
      The stage for s_A should be `ShuffleMapStage 0`, but the stage for `s_A` is generated twice as `ShuffleMapStage 2` and `ShuffleMapStage 0` is overwritten by `ShuffleMapStage 2`, and the stage `ShuffleMap Stage1` keeps referring the old stage `ShuffleMapStage 0`.
      
      This patch is fixing it.
      
      ## How was this patch tested?
      
      I added the sample RDD graph to show the illegal stage graph to `DAGSchedulerSuite`.
      
      Author: Takuya UESHIN <ueshin@happy-camper.st>
      
      Closes #12655 from ueshin/issues/SPARK-13902.
      a57aadae
    • Brian O'Neill's avatar
      [SPARK-14421] Upgrades protobuf dependency to 2.6.1 for the new version of KCL, and… · 81e3bfc1
      Brian O'Neill authored
      ## What changes were proposed in this pull request?
      
      When running with Kinesis Consumer Library (KCL), against a stream that contains aggregated data, the KCL needs access to protobuf to de-aggregate the records.   Without this patch, that results in the following error message:
      
      ```
         Caused by: java.lang.ClassNotFoundException: com.google.protobuf.ProtocolStringList
      ```
      
      This PR upgrades the protobuf dependency within the kinesis-asl-assembly, and relocates that package (as not to conflict with Spark's use of 2.5.0), which fixes the above CNFE.
      
      ## How was this patch tested?
      
      Used kinesis word count example against a stream containing aggregated data.
      
      See: SPARK-14421
      
      Author: Brian O'Neill <bone@alumni.brown.edu>
      
      Closes #13054 from boneill42/protobuf-relocation-for-kcl.
      81e3bfc1
    • bomeng's avatar
      [SPARK-14897][SQL] upgrade to jetty 9.2.16 · 81bf8708
      bomeng authored
      ## What changes were proposed in this pull request?
      
      Since Jetty 8 is EOL (end of life) and has critical security issue [http://www.securityweek.com/critical-vulnerability-found-jetty-web-server], I think upgrading to 9 is necessary. I am using latest 9.2 since 9.3 requires Java 8+.
      
      `javax.servlet` and `derby` were also upgraded since Jetty 9.2 needs corresponding version.
      
      ## How was this patch tested?
      
      Manual test and current test cases should cover it.
      
      Author: bomeng <bmeng@us.ibm.com>
      
      Closes #12916 from bomeng/SPARK-14897.
      81bf8708
    • gatorsmile's avatar
      [SPARK-14684][SPARK-15277][SQL] Partition Spec Validation in SessionCatalog... · be617f3d
      gatorsmile authored
      [SPARK-14684][SPARK-15277][SQL] Partition Spec Validation in SessionCatalog and Checking Partition Spec Existence Before Dropping
      
      #### What changes were proposed in this pull request?
      ~~Currently, multiple partitions are allowed to drop by using a single DDL command: Alter Table Drop Partition. However, the internal implementation could break atomicity. That means, we could just drop a subset of qualified partitions, if hitting an exception when dropping one of qualified partitions~~
      
      ~~This PR contains the following behavior changes:~~
      ~~- disallow dropping multiple partitions by a single command ~~
      ~~- allow users to input predicates in partition specification and issue a nicer error message if the predicate's comparison operator is not `=`.~~
      ~~- verify the partition spec in SessionCatalog. This can ensure each partition spec in `Drop Partition` does not correspond to multiple partitions.~~
      
      This PR has two major parts:
      - Verify the partition spec in SessionCatalog for fixing the following issue:
        ```scala
        sql(s"ALTER TABLE $externalTab DROP PARTITION (ds='2008-04-09', unknownCol='12')")
        ```
        Above example uses an invalid partition spec. Without this PR, we will drop all the partitions. The reason is Hive megastores getPartitions API returns all the partitions if we provide an invalid spec.
      
      - Re-implemented the `dropPartitions` in `HiveClientImpl`. Now, we always check if all the user-specified partition specs exist before attempting to drop the partitions. Previously, we start drop the partition before completing checking the existence of all the partition specs. If any failure happened after we start to drop the partitions, we will log an error message to indicate which partitions have been dropped and which partitions have not been dropped.
      
      #### How was this patch tested?
      Modified the existing test cases and added new test cases.
      
      Author: gatorsmile <gatorsmile@gmail.com>
      Author: xiaoli <lixiao1983@gmail.com>
      Author: Xiao Li <xiaoli@Xiaos-MacBook-Pro.local>
      
      Closes #12801 from gatorsmile/banDropMultiPart.
      be617f3d
    • Liang-Chi Hsieh's avatar
      [SPARK-15094][SPARK-14803][SQL] Remove extra Project added in EliminateSerialization · 470de743
      Liang-Chi Hsieh authored
      ## What changes were proposed in this pull request?
      
      We will eliminate the pair of `DeserializeToObject` and `SerializeFromObject` in `Optimizer` and add extra `Project`. However, when DeserializeToObject's outputObjectType is ObjectType and its cls can't be processed by unsafe project, it will be failed.
      
      To fix it, we can simply remove the extra `Project` and replace the output attribute of `DeserializeToObject` in another rule.
      
      ## How was this patch tested?
      `DatasetSuite`.
      
      Author: Liang-Chi Hsieh <simonh@tw.ibm.com>
      
      Closes #12926 from viirya/fix-eliminate-serialization-projection.
      470de743
    • Sean Owen's avatar
      [BUILD] Test closing stale PRs · 5bb62b89
      Sean Owen authored
      ## What changes were proposed in this pull request?
      
      Here I'm seeing if we can close stale PRs via a PR message, as I'd expect.
      See thread https://www.mail-archive.com/devspark.apache.org/msg14149.html
      
      Closes #9354
      Closes #9451
      Closes #10507
      Closes #10486
      Closes #10460
      Closes #10967
      Closes #10681
      Closes #11766
      Closes #9907
      Closes #10209
      Closes #10379
      Closes #10403
      Closes #10842
      Closes #11036
      Closes #13003
      Closes #10887
      
      ## How was this patch tested?
      
      (No changes)
      
      Author: Sean Owen <sowen@cloudera.com>
      
      Closes #13052 from srowen/TestClosingPRs.
      5bb62b89
    • Sean Zhong's avatar
      [SPARK-15171][SQL] Deprecate registerTempTable and add dataset.createTempView · 33c6eb52
      Sean Zhong authored
      ## What changes were proposed in this pull request?
      
      Deprecates registerTempTable and add dataset.createTempView, dataset.createOrReplaceTempView.
      
      ## How was this patch tested?
      
      Unit tests.
      
      Author: Sean Zhong <seanzhong@databricks.com>
      
      Closes #12945 from clockfly/spark-15171.
      33c6eb52
    • Holden Karau's avatar
      [SPARK-15281][PYSPARK][ML][TRIVIAL] Add impurity param to GBTRegressor & add... · 5207a005
      Holden Karau authored
      [SPARK-15281][PYSPARK][ML][TRIVIAL] Add impurity param to GBTRegressor & add experimental inside of regression.py
      
      ## What changes were proposed in this pull request?
      
      Add impurity param to  GBTRegressor and mark the of the models & regressors in regression.py as experimental to match Scaladoc.
      
      ## How was this patch tested?
      
      Added default value to init, tested with unit/doc tests.
      
      Author: Holden Karau <holden@us.ibm.com>
      
      Closes #13071 from holdenk/SPARK-15281-GBTRegressor-impurity.
      5207a005
    • Wenchen Fan's avatar
      [SPARK-15160][SQL] support data source table in InMemoryCatalog · 46991448
      Wenchen Fan authored
      ## What changes were proposed in this pull request?
      
      This PR adds a new rule to convert `SimpleCatalogRelation` to data source table if its table property contains data source information.
      
      ## How was this patch tested?
      
      new test in SQLQuerySuite
      
      Author: Wenchen Fan <wenchen@databricks.com>
      
      Closes #12935 from cloud-fan/ds-table.
      46991448
    • Zheng RuiFeng's avatar
      [SPARK-15031][SPARK-15134][EXAMPLE][DOC] Use SparkSession and update indent in examples · 9e266d07
      Zheng RuiFeng authored
      ## What changes were proposed in this pull request?
      1, Use `SparkSession` according to [SPARK-15031](https://issues.apache.org/jira/browse/SPARK-15031)
      2, Update indent for `SparkContext` according to [SPARK-15134](https://issues.apache.org/jira/browse/SPARK-15134)
      3, BTW, remove some duplicate space and add missing '.'
      
      ## How was this patch tested?
      manual tests
      
      Author: Zheng RuiFeng <ruifengz@foxmail.com>
      
      Closes #13050 from zhengruifeng/use_sparksession.
      9e266d07
  3. May 11, 2016
    • Yin Huai's avatar
      [SPARK-15072][SQL][PYSPARK][HOT-FIX] Remove SparkSession.withHiveSupport from readwrite.py · ba5487c0
      Yin Huai authored
      ## What changes were proposed in this pull request?
      Seems https://github.com/apache/spark/commit/db573fc743d12446dd0421fb45d00c2f541eaf9a did not remove withHiveSupport from readwrite.py
      
      Author: Yin Huai <yhuai@databricks.com>
      
      Closes #13069 from yhuai/fixPython.
      ba5487c0
    • Cheng Lian's avatar
      [SPARK-14346] SHOW CREATE TABLE for data source tables · f036dd7c
      Cheng Lian authored
      ## What changes were proposed in this pull request?
      
      This PR adds native `SHOW CREATE TABLE` DDL command for data source tables. Support for Hive tables will be added in follow-up PR(s).
      
      To show table creation DDL for data source tables created by CTAS statements, this PR also added partitioning and bucketing support for normal `CREATE TABLE ... USING ...` syntax.
      
      ## How was this patch tested?
      
      (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
      
      A new test suite `ShowCreateTableSuite` is added in sql/hive package to test the new feature.
      
      Author: Cheng Lian <lian@databricks.com>
      
      Closes #12781 from liancheng/spark-14346-show-create-table.
      f036dd7c
    • Sandeep Singh's avatar
      [SPARK-15080][CORE] Break copyAndReset into copy and reset · ff92eb2e
      Sandeep Singh authored
      ## What changes were proposed in this pull request?
      Break copyAndReset into two methods copy and reset instead of just one.
      
      ## How was this patch tested?
      Existing Tests
      
      Author: Sandeep Singh <sandeep@techaddict.me>
      
      Closes #12936 from techaddict/SPARK-15080.
      ff92eb2e
    • Sandeep Singh's avatar
      [SPARK-15072][SQL][PYSPARK] FollowUp: Remove SparkSession.withHiveSupport in PySpark · db573fc7
      Sandeep Singh authored
      ## What changes were proposed in this pull request?
      This is a followup of https://github.com/apache/spark/pull/12851
      Remove `SparkSession.withHiveSupport` in PySpark and instead use `SparkSession.builder. enableHiveSupport`
      
      ## How was this patch tested?
      Existing tests.
      
      Author: Sandeep Singh <sandeep@techaddict.me>
      
      Closes #13063 from techaddict/SPARK-15072-followup.
      db573fc7
    • Bill Chambers's avatar
      [SPARK-15264][SPARK-15274][SQL] CSV Reader Error on Blank Column Names · 603f4453
      Bill Chambers authored
      ## What changes were proposed in this pull request?
      
      When a CSV begins with:
      - `,,`
      OR
      - `"","",`
      
      meaning that the first column names are either empty or blank strings and `header` is specified to be `true`, then the column name is replaced with `C` + the index number of that given column. For example, if you were to read in the CSV:
      ```
      "","second column"
      "hello", "there"
      ```
      Then column names would become `"C0", "second column"`.
      
      This behavior aligns with what currently happens when `header` is specified to be `false` in recent versions of Spark.
      
      ### Current Behavior in Spark <=1.6
      In Spark <=1.6, a CSV with a blank column name becomes a blank string, `""`, meaning that this column cannot be accessed. However the CSV reads in without issue.
      
      ### Current Behavior in Spark 2.0
      Spark throws a NullPointerError and will not read in the file.
      
      #### Reproduction in 2.0
      https://databricks-prod-cloudfront.cloud.databricks.com/public/4027ec902e239c93eaaa8714f173bcfc/346304/2828750690305044/484361/latest.html
      
      ## How was this patch tested?
      A new test was added to `CSVSuite` to account for this issue. We then have asserts that test for being able to select both the empty column names as well as the regular column names.
      
      Author: Bill Chambers <bill@databricks.com>
      Author: Bill Chambers <wchambers@ischool.berkeley.edu>
      
      Closes #13041 from anabranch/master.
      603f4453
    • Andrew Or's avatar
      [SPARK-15276][SQL] CREATE TABLE with LOCATION should imply EXTERNAL · f14c4ba0
      Andrew Or authored
      ## What changes were proposed in this pull request?
      
      Before:
      ```sql
      -- uses that location but issues a warning
      CREATE TABLE my_tab LOCATION /some/path
      -- deletes any existing data in the specified location
      DROP TABLE my_tab
      ```
      
      After:
      ```sql
      -- uses that location but creates an EXTERNAL table instead
      CREATE TABLE my_tab LOCATION /some/path
      -- does not delete the data at /some/path
      DROP TABLE my_tab
      ```
      
      This patch essentially makes the `EXTERNAL` field optional. This is related to #13032.
      
      ## How was this patch tested?
      
      New test in `DDLCommandSuite`.
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #13060 from andrewor14/location-implies-external.
      f14c4ba0
    • Nicholas Chammas's avatar
      [SPARK-15256] [SQL] [PySpark] Clarify DataFrameReader.jdbc() docstring · b9cf617a
      Nicholas Chammas authored
      This PR:
      * Corrects the documentation for the `properties` parameter, which is supposed to be a dictionary and not a list.
      * Generally clarifies the Python docstring for DataFrameReader.jdbc() by pulling from the [Scala docstrings](https://github.com/apache/spark/blob/b28137764716f56fa1a923c4278624a56364a505/sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala#L201-L251) and rephrasing things.
      * Corrects minor Sphinx typos.
      
      Author: Nicholas Chammas <nicholas.chammas@gmail.com>
      
      Closes #13034 from nchammas/SPARK-15256.
      b9cf617a
    • Andrew Or's avatar
      [SPARK-15257][SQL] Require CREATE EXTERNAL TABLE to specify LOCATION · 8881765a
      Andrew Or authored
      ## What changes were proposed in this pull request?
      
      Before:
      ```sql
      -- uses warehouse dir anyway
      CREATE EXTERNAL TABLE my_tab
      -- doesn't actually delete the data
      DROP TABLE my_tab
      ```
      After:
      ```sql
      -- no location is provided, throws exception
      CREATE EXTERNAL TABLE my_tab
      -- creates an external table using that location
      CREATE EXTERNAL TABLE my_tab LOCATION '/path/to/something'
      -- doesn't delete the data, which is expected
      DROP TABLE my_tab
      ```
      
      ## How was this patch tested?
      
      New test in `DDLCommandSuite`
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #13032 from andrewor14/create-external-table-location.
      8881765a
    • Reynold Xin's avatar
      [SPARK-15278] [SQL] Remove experimental tag from Python DataFrame · 40ba87f7
      Reynold Xin authored
      ## What changes were proposed in this pull request?
      Earlier we removed experimental tag for Scala/Java DataFrames, but haven't done so for Python. This patch removes the experimental flag for Python and declares them stable.
      
      ## How was this patch tested?
      N/A.
      
      Author: Reynold Xin <rxin@databricks.com>
      
      Closes #13062 from rxin/SPARK-15278.
      40ba87f7
    • Sandeep Singh's avatar
      [SPARK-15270] [SQL] Use SparkSession Builder to build a session with HiveSupport · de9c85cc
      Sandeep Singh authored
      ## What changes were proposed in this pull request?
      Before:
      Creating a hiveContext was failing
      ```python
      from pyspark.sql import HiveContext
      hc = HiveContext(sc)
      ```
      with
      ```
      Traceback (most recent call last):
        File "<stdin>", line 1, in <module>
        File "spark-2.0/python/pyspark/sql/context.py", line 458, in __init__
          sparkSession = SparkSession.withHiveSupport(sparkContext)
        File "spark-2.0/python/pyspark/sql/session.py", line 192, in withHiveSupport
          jsparkSession = sparkContext._jvm.SparkSession.withHiveSupport(sparkContext._jsc.sc())
        File "spark-2.0/python/lib/py4j-0.9.2-src.zip/py4j/java_gateway.py", line 1048, in __getattr__
      py4j.protocol.Py4JError: org.apache.spark.sql.SparkSession.withHiveSupport does not exist in the JVM
      ```
      
      Now:
      ```python
      >>> from pyspark.sql import HiveContext
      >>> hc = HiveContext(sc)
      >>> hc.range(0, 100)
      DataFrame[id: bigint]
      >>> hc.range(0, 100).count()
      100
      ```
      ## How was this patch tested?
      Existing Tests, tested manually in python shell
      
      Author: Sandeep Singh <sandeep@techaddict.me>
      
      Closes #13056 from techaddict/SPARK-15270.
      de9c85cc
    • Andrew Or's avatar
      [SPARK-15262] Synchronize block manager / scheduler executor state · 40a949aa
      Andrew Or authored
      ## What changes were proposed in this pull request?
      
      If an executor is still alive even after the scheduler has removed its metadata, we may receive a heartbeat from that executor and tell its block manager to reregister itself. If that happens, the block manager master will know about the executor, but the scheduler will not.
      
      That is a dangerous situation, because when the executor does get disconnected later, the scheduler will not ask the block manager to also remove metadata for that executor. Later, when we try to clean up an RDD or a broadcast variable, we may try to send a message to that executor, triggering an exception.
      
      ## How was this patch tested?
      
      Jenkins.
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #13055 from andrewor14/block-manager-remove.
      40a949aa
    • Maciej Brynski's avatar
      [SPARK-12200][SQL] Add __contains__ implementation to Row · 7ecd4968
      Maciej Brynski authored
      https://issues.apache.org/jira/browse/SPARK-12200
      
      Author: Maciej Brynski <maciej.brynski@adpilot.pl>
      Author: Maciej Bryński <maciek-github@brynski.pl>
      
      Closes #10194 from maver1ck/master.
      7ecd4968
    • Andrew Or's avatar
      [SPARK-15260] Atomically resize memory pools · bb88ad4e
      Andrew Or authored
      ## What changes were proposed in this pull request?
      
      When we acquire execution memory, we do a lot of things between shrinking the storage memory pool and enlarging the execution memory pool. In particular, we call `memoryStore.evictBlocksToFreeSpace`, which may do a lot of I/O and can throw exceptions. If an exception is thrown, the pool sizes on that executor will be in a bad state.
      
      This patch minimizes the things we do between the two calls to make the resizing more atomic.
      
      ## How was this patch tested?
      
      Jenkins.
      
      Author: Andrew Or <andrew@databricks.com>
      
      Closes #13039 from andrewor14/safer-pool.
      bb88ad4e
    • Tathagata Das's avatar
      [SPARK-15248][SQL] Make MetastoreFileCatalog consider directories from... · 81c68ece
      Tathagata Das authored
      [SPARK-15248][SQL] Make MetastoreFileCatalog consider directories from partition specs of a partitioned metastore table
      
      Table partitions can be added with locations different from default warehouse location of a hive table.
      `CREATE TABLE parquetTable (a int) PARTITIONED BY (b int) STORED AS parquet `
      `ALTER TABLE parquetTable ADD PARTITION (b=1) LOCATION '/partition'`
      Querying such a table throws error as the MetastoreFileCatalog does not list the added partition directory, it only lists the default base location.
      
      ```
      [info] - SPARK-15248: explicitly added partitions should be readable *** FAILED *** (1 second, 8 milliseconds)
      [info]   java.util.NoSuchElementException: key not found: file:/Users/tdas/Projects/Spark/spark2/target/tmp/spark-b39ad224-c5d1-4966-8981-fb45a2066d61/partition
      [info]   at scala.collection.MapLike$class.default(MapLike.scala:228)
      [info]   at scala.collection.AbstractMap.default(Map.scala:59)
      [info]   at scala.collection.MapLike$class.apply(MapLike.scala:141)
      [info]   at scala.collection.AbstractMap.apply(Map.scala:59)
      [info]   at org.apache.spark.sql.execution.datasources.PartitioningAwareFileCatalog$$anonfun$listFiles$1.apply(PartitioningAwareFileCatalog.scala:59)
      [info]   at org.apache.spark.sql.execution.datasources.PartitioningAwareFileCatalog$$anonfun$listFiles$1.apply(PartitioningAwareFileCatalog.scala:55)
      [info]   at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
      [info]   at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
      [info]   at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
      [info]   at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
      [info]   at scala.collection.TraversableLike$class.map(TraversableLike.scala:234)
      [info]   at scala.collection.AbstractTraversable.map(Traversable.scala:104)
      [info]   at org.apache.spark.sql.execution.datasources.PartitioningAwareFileCatalog.listFiles(PartitioningAwareFileCatalog.scala:55)
      [info]   at org.apache.spark.sql.execution.datasources.FileSourceStrategy$.apply(FileSourceStrategy.scala:93)
      [info]   at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$1.apply(QueryPlanner.scala:59)
      [info]   at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$1.apply(QueryPlanner.scala:59)
      [info]   at scala.collection.Iterator$$anon$12.nextCur(Iterator.scala:434)
      [info]   at scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:440)
      [info]   at org.apache.spark.sql.catalyst.planning.QueryPlanner.plan(QueryPlanner.scala:60)
      [info]   at org.apache.spark.sql.catalyst.planning.QueryPlanner.planLater(QueryPlanner.scala:55)
      [info]   at org.apache.spark.sql.execution.SparkStrategies$SpecialLimits$.apply(SparkStrategies.scala:55)
      [info]   at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$1.apply(QueryPlanner.scala:59)
      [info]   at org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$1.apply(QueryPlanner.scala:59)
      [info]   at scala.collection.Iterator$$anon$12.nextCur(Iterator.scala:434)
      [info]   at scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:440)
      [info]   at org.apache.spark.sql.catalyst.planning.QueryPlanner.plan(QueryPlanner.scala:60)
      [info]   at org.apache.spark.sql.execution.QueryExecution.sparkPlan$lzycompute(QueryExecution.scala:77)
      [info]   at org.apache.spark.sql.execution.QueryExecution.sparkPlan(QueryExecution.scala:75)
      [info]   at org.apache.spark.sql.execution.QueryExecution.executedPlan$lzycompute(QueryExecution.scala:82)
      [info]   at org.apache.spark.sql.execution.QueryExecution.executedPlan(QueryExecution.scala:82)
      [info]   at org.apache.spark.sql.QueryTest.assertEmptyMissingInput(QueryTest.scala:330)
      [info]   at org.apache.spark.sql.QueryTest.checkAnswer(QueryTest.scala:146)
      [info]   at org.apache.spark.sql.QueryTest.checkAnswer(QueryTest.scala:159)
      [info]   at org.apache.spark.sql.hive.ParquetMetastoreSuite$$anonfun$12$$anonfun$apply$mcV$sp$7$$anonfun$apply$mcV$sp$25.apply(parquetSuites.scala:554)
      [info]   at org.apache.spark.sql.hive.ParquetMetastoreSuite$$anonfun$12$$anonfun$apply$mcV$sp$7$$anonfun$apply$mcV$sp$25.apply(parquetSuites.scala:535)
      [info]   at org.apache.spark.sql.test.SQLTestUtils$class.withTempDir(SQLTestUtils.scala:125)
      [info]   at org.apache.spark.sql.hive.ParquetPartitioningTest.withTempDir(parquetSuites.scala:726)
      [info]   at org.apache.spark.sql.hive.ParquetMetastoreSuite$$anonfun$12$$anonfun$apply$mcV$sp$7.apply$mcV$sp(parquetSuites.scala:535)
      [info]   at org.apache.spark.sql.test.SQLTestUtils$class.withTable(SQLTestUtils.scala:166)
      [info]   at org.apache.spark.sql.hive.ParquetPartitioningTest.withTable(parquetSuites.scala:726)
      [info]   at org.apache.spark.sql.hive.ParquetMetastoreSuite$$anonfun$12.apply$mcV$sp(parquetSuites.scala:534)
      [info]   at org.apache.spark.sql.hive.ParquetMetastoreSuite$$anonfun$12.apply(parquetSuites.scala:534)
      [info]   at org.apache.spark.sql.hive.ParquetMetastoreSuite$$anonfun$12.apply(parquetSuites.scala:534)
      ```
      
      The solution in this PR to get the paths to list from the partition spec and not rely on the default table path alone.
      
      unit tests.
      
      Author: Tathagata Das <tathagata.das1565@gmail.com>
      
      Closes #13022 from tdas/SPARK-15248.
      81c68ece
    • cody koeninger's avatar
      [SPARK-15085][STREAMING][KAFKA] Rename streaming-kafka artifact · 89e67d66
      cody koeninger authored
      ## What changes were proposed in this pull request?
      Renaming the streaming-kafka artifact to include kafka version, in anticipation of needing a different artifact for later kafka versions
      
      ## How was this patch tested?
      Unit tests
      
      Author: cody koeninger <cody@koeninger.org>
      
      Closes #12946 from koeninger/SPARK-15085.
      89e67d66
    • Eric Liang's avatar
      [SPARK-15259] Sort time metric should not include spill and record insertion time · 6d0368ab
      Eric Liang authored
      ## What changes were proposed in this pull request?
      
      After SPARK-14669 it seems the sort time metric includes both spill and record insertion time. This makes it not very useful since the metric becomes close to the total execution time of the node.
      
      We should track just the time spent for in-memory sort, as before.
      
      ## How was this patch tested?
      
      Verified metric in the UI, also unit test on UnsafeExternalRowSorter.
      
      cc davies
      
      Author: Eric Liang <ekl@databricks.com>
      Author: Eric Liang <ekhliang@gmail.com>
      
      Closes #13035 from ericl/fix-metrics.
      6d0368ab
    • Sandeep Singh's avatar
      [SPARK-15037] [SQL] [MLLIB] Part2: Use SparkSession instead of SQLContext in Python TestSuites · 29314379
      Sandeep Singh authored
      ## What changes were proposed in this pull request?
      Use SparkSession instead of SQLContext in Python TestSuites
      
      ## How was this patch tested?
      Existing tests
      
      Author: Sandeep Singh <sandeep@techaddict.me>
      
      Closes #13044 from techaddict/SPARK-15037-python.
      29314379
    • Wenchen Fan's avatar
      [SPARK-15241] [SPARK-15242] [SQL] fix 2 decimal-related issues in RowEncoder · d8935db5
      Wenchen Fan authored
      ## What changes were proposed in this pull request?
      
      SPARK-15241: We now support java decimal and catalyst decimal in external row, it makes sense to also support scala decimal.
      
      SPARK-15242: This is a long-standing bug, and is exposed after https://github.com/apache/spark/pull/12364, which eliminate the `If` expression if the field is not nullable:
      ```
      val fieldValue = serializerFor(
        GetExternalRowField(inputObject, i, externalDataTypeForInput(f.dataType)),
        f.dataType)
      if (f.nullable) {
        If(
          Invoke(inputObject, "isNullAt", BooleanType, Literal(i) :: Nil),
          Literal.create(null, f.dataType),
          fieldValue)
      } else {
        fieldValue
      }
      ```
      
      Previously, we always use `DecimalType.SYSTEM_DEFAULT` as the output type of converted decimal field, which is wrong as it doesn't match the real decimal type. However, it works well because we always put converted field into `If` expression to do the null check, and `If` use its `trueValue`'s data type as its output type.
      Now if we have a not nullable decimal field, then the converted field's output type will be `DecimalType.SYSTEM_DEFAULT`, and we will write wrong data into unsafe row.
      
      The fix is simple, just use the given decimal type as the output type of converted decimal field.
      
      These 2 issues was found at https://github.com/apache/spark/pull/13008
      
      ## How was this patch tested?
      
      new tests in RowEncoderSuite
      
      Author: Wenchen Fan <wenchen@databricks.com>
      
      Closes #13019 from cloud-fan/encoder-decimal.
      d8935db5
Loading