Skip to content
Snippets Groups Projects
Commit f5576a05 authored by Sean Owen's avatar Sean Owen
Browse files

[SPARK-12972][CORE] Update org.apache.httpcomponents.httpclient

## What changes were proposed in this pull request?

(Retry of https://github.com/apache/spark/pull/13049)

- update to httpclient 4.5 / httpcore 4.4
- remove some defunct exclusions
- manage httpmime version to match
- update selenium / httpunit to support 4.5 (possible now that Jetty 9 is used)

## How was this patch tested?

Jenkins tests. Also, locally running the same test command of one Jenkins profile that failed: `mvn -Phadoop-2.6 -Pyarn -Phive -Phive-thriftserver -Pkinesis-asl ...`

Author: Sean Owen <sowen@cloudera.com>

Closes #13117 from srowen/SPARK-12972.2.
parent 354f8f11
No related branches found
No related tags found
No related merge requests found
...@@ -275,12 +275,11 @@ ...@@ -275,12 +275,11 @@
<dependency> <dependency>
<groupId>org.seleniumhq.selenium</groupId> <groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-java</artifactId> <artifactId>selenium-java</artifactId>
<exclusions> <scope>test</scope>
<exclusion> </dependency>
<groupId>com.google.guava</groupId> <dependency>
<artifactId>guava</artifactId> <groupId>org.seleniumhq.selenium</groupId>
</exclusion> <artifactId>selenium-htmlunit-driver</artifactId>
</exclusions>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<!-- Added for selenium: --> <!-- Added for selenium: -->
......
...@@ -69,8 +69,8 @@ hadoop-yarn-server-web-proxy-2.2.0.jar ...@@ -69,8 +69,8 @@ hadoop-yarn-server-web-proxy-2.2.0.jar
hk2-api-2.4.0-b34.jar hk2-api-2.4.0-b34.jar
hk2-locator-2.4.0-b34.jar hk2-locator-2.4.0-b34.jar
hk2-utils-2.4.0-b34.jar hk2-utils-2.4.0-b34.jar
httpclient-4.3.2.jar httpclient-4.5.2.jar
httpcore-4.3.2.jar httpcore-4.4.4.jar
ivy-2.4.0.jar ivy-2.4.0.jar
jackson-annotations-2.5.3.jar jackson-annotations-2.5.3.jar
jackson-core-2.5.3.jar jackson-core-2.5.3.jar
......
...@@ -71,8 +71,8 @@ hadoop-yarn-server-web-proxy-2.3.0.jar ...@@ -71,8 +71,8 @@ hadoop-yarn-server-web-proxy-2.3.0.jar
hk2-api-2.4.0-b34.jar hk2-api-2.4.0-b34.jar
hk2-locator-2.4.0-b34.jar hk2-locator-2.4.0-b34.jar
hk2-utils-2.4.0-b34.jar hk2-utils-2.4.0-b34.jar
httpclient-4.3.2.jar httpclient-4.5.2.jar
httpcore-4.3.2.jar httpcore-4.4.4.jar
ivy-2.4.0.jar ivy-2.4.0.jar
jackson-annotations-2.5.3.jar jackson-annotations-2.5.3.jar
jackson-core-2.5.3.jar jackson-core-2.5.3.jar
......
...@@ -71,8 +71,8 @@ hadoop-yarn-server-web-proxy-2.4.0.jar ...@@ -71,8 +71,8 @@ hadoop-yarn-server-web-proxy-2.4.0.jar
hk2-api-2.4.0-b34.jar hk2-api-2.4.0-b34.jar
hk2-locator-2.4.0-b34.jar hk2-locator-2.4.0-b34.jar
hk2-utils-2.4.0-b34.jar hk2-utils-2.4.0-b34.jar
httpclient-4.3.2.jar httpclient-4.5.2.jar
httpcore-4.3.2.jar httpcore-4.4.4.jar
ivy-2.4.0.jar ivy-2.4.0.jar
jackson-annotations-2.5.3.jar jackson-annotations-2.5.3.jar
jackson-core-2.5.3.jar jackson-core-2.5.3.jar
......
...@@ -77,8 +77,8 @@ hk2-api-2.4.0-b34.jar ...@@ -77,8 +77,8 @@ hk2-api-2.4.0-b34.jar
hk2-locator-2.4.0-b34.jar hk2-locator-2.4.0-b34.jar
hk2-utils-2.4.0-b34.jar hk2-utils-2.4.0-b34.jar
htrace-core-3.0.4.jar htrace-core-3.0.4.jar
httpclient-4.3.2.jar httpclient-4.5.2.jar
httpcore-4.3.2.jar httpcore-4.4.4.jar
ivy-2.4.0.jar ivy-2.4.0.jar
jackson-annotations-2.5.3.jar jackson-annotations-2.5.3.jar
jackson-core-2.5.3.jar jackson-core-2.5.3.jar
......
...@@ -77,8 +77,8 @@ hk2-api-2.4.0-b34.jar ...@@ -77,8 +77,8 @@ hk2-api-2.4.0-b34.jar
hk2-locator-2.4.0-b34.jar hk2-locator-2.4.0-b34.jar
hk2-utils-2.4.0-b34.jar hk2-utils-2.4.0-b34.jar
htrace-core-3.1.0-incubating.jar htrace-core-3.1.0-incubating.jar
httpclient-4.3.2.jar httpclient-4.5.2.jar
httpcore-4.3.2.jar httpcore-4.4.4.jar
ivy-2.4.0.jar ivy-2.4.0.jar
jackson-annotations-2.5.3.jar jackson-annotations-2.5.3.jar
jackson-core-2.5.3.jar jackson-core-2.5.3.jar
......
...@@ -85,13 +85,11 @@ ...@@ -85,13 +85,11 @@
<dependency> <dependency>
<groupId>org.apache.httpcomponents</groupId> <groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId> <artifactId>httpclient</artifactId>
<version>4.5</version>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.apache.httpcomponents</groupId> <groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId> <artifactId>httpcore</artifactId>
<version>4.4.1</version>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<!-- Necessary in order to avoid errors in log messages: --> <!-- Necessary in order to avoid errors in log messages: -->
......
...@@ -149,8 +149,8 @@ ...@@ -149,8 +149,8 @@
<!-- the producer is used in tests --> <!-- the producer is used in tests -->
<aws.kinesis.producer.version>0.10.2</aws.kinesis.producer.version> <aws.kinesis.producer.version>0.10.2</aws.kinesis.producer.version>
<!-- org.apache.httpcomponents/httpclient--> <!-- org.apache.httpcomponents/httpclient-->
<commons.httpclient.version>4.3.2</commons.httpclient.version> <commons.httpclient.version>4.5.2</commons.httpclient.version>
<commons.httpcore.version>4.3.2</commons.httpcore.version> <commons.httpcore.version>4.4.4</commons.httpcore.version>
<!-- commons-httpclient/commons-httpclient--> <!-- commons-httpclient/commons-httpclient-->
<httpclient.classic.version>3.1</httpclient.classic.version> <httpclient.classic.version>3.1</httpclient.classic.version>
<commons.math3.version>3.4.1</commons.math3.version> <commons.math3.version>3.4.1</commons.math3.version>
...@@ -179,6 +179,7 @@ ...@@ -179,6 +179,7 @@
<libthrift.version>0.9.2</libthrift.version> <libthrift.version>0.9.2</libthrift.version>
<antlr4.version>4.5.2-1</antlr4.version> <antlr4.version>4.5.2-1</antlr4.version>
<jpam.version>1.1</jpam.version> <jpam.version>1.1</jpam.version>
<selenium.version>2.52.0</selenium.version>
<test.java.home>${java.home}</test.java.home> <test.java.home>${java.home}</test.java.home>
<test.exclude.tags></test.exclude.tags> <test.exclude.tags></test.exclude.tags>
...@@ -410,6 +411,11 @@ ...@@ -410,6 +411,11 @@
<artifactId>httpclient</artifactId> <artifactId>httpclient</artifactId>
<version>${commons.httpclient.version}</version> <version>${commons.httpclient.version}</version>
</dependency> </dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpmime</artifactId>
<version>${commons.httpclient.version}</version>
</dependency>
<dependency> <dependency>
<groupId>org.apache.httpcomponents</groupId> <groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId> <artifactId>httpcore</artifactId>
...@@ -418,7 +424,7 @@ ...@@ -418,7 +424,7 @@
<dependency> <dependency>
<groupId>org.seleniumhq.selenium</groupId> <groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-java</artifactId> <artifactId>selenium-java</artifactId>
<version>2.45.0</version> <!-- 2.46.0+ requires Jetty 9 --> <version>${selenium.version}</version>
<scope>test</scope> <scope>test</scope>
<exclusions> <exclusions>
<exclusion> <exclusion>
...@@ -431,6 +437,12 @@ ...@@ -431,6 +437,12 @@
</exclusion> </exclusion>
</exclusions> </exclusions>
</dependency> </dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-htmlunit-driver</artifactId>
<version>${selenium.version}</version>
<scope>test</scope>
</dependency>
<!-- Added for selenium only, and should match its dependent version: --> <!-- Added for selenium only, and should match its dependent version: -->
<dependency> <dependency>
<groupId>xml-apis</groupId> <groupId>xml-apis</groupId>
...@@ -731,18 +743,6 @@ ...@@ -731,18 +743,6 @@
<artifactId>guava</artifactId> <artifactId>guava</artifactId>
<groupId>com.google.guava</groupId> <groupId>com.google.guava</groupId>
</exclusion> </exclusion>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId>
</exclusion>
<exclusion>
<groupId>commons-logging</groupId>
<artifactId>httpclient</artifactId>
</exclusion>
<exclusion> <exclusion>
<groupId>commons-logging</groupId> <groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId> <artifactId>commons-logging</artifactId>
...@@ -1448,14 +1448,6 @@ ...@@ -1448,14 +1448,6 @@
<groupId>${hive.group}</groupId> <groupId>${hive.group}</groupId>
<artifactId>hive-shims</artifactId> <artifactId>hive-shims</artifactId>
</exclusion> </exclusion>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId>
</exclusion>
<exclusion> <exclusion>
<groupId>org.apache.curator</groupId> <groupId>org.apache.curator</groupId>
<artifactId>curator-framework</artifactId> <artifactId>curator-framework</artifactId>
...@@ -1807,14 +1799,6 @@ ...@@ -1807,14 +1799,6 @@
<artifactId>libthrift</artifactId> <artifactId>libthrift</artifactId>
<version>${libthrift.version}</version> <version>${libthrift.version}</version>
<exclusions> <exclusions>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId>
</exclusion>
<exclusion> <exclusion>
<groupId>org.slf4j</groupId> <groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId> <artifactId>slf4j-api</artifactId>
...@@ -1826,14 +1810,6 @@ ...@@ -1826,14 +1810,6 @@
<artifactId>libfb303</artifactId> <artifactId>libfb303</artifactId>
<version>${libthrift.version}</version> <version>${libthrift.version}</version>
<exclusions> <exclusions>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId>
</exclusion>
<exclusion> <exclusion>
<groupId>org.slf4j</groupId> <groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId> <artifactId>slf4j-api</artifactId>
......
...@@ -70,6 +70,11 @@ ...@@ -70,6 +70,11 @@
<artifactId>selenium-java</artifactId> <artifactId>selenium-java</artifactId>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-htmlunit-driver</artifactId>
<scope>test</scope>
</dependency>
<dependency> <dependency>
<groupId>org.apache.spark</groupId> <groupId>org.apache.spark</groupId>
<artifactId>spark-sql_${scala.binary.version}</artifactId> <artifactId>spark-sql_${scala.binary.version}</artifactId>
...@@ -106,12 +111,6 @@ ...@@ -106,12 +111,6 @@
</sources> </sources>
</configuration> </configuration>
</execution> </execution>
</executions>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<execution> <execution>
<id>add-source</id> <id>add-source</id>
<phase>generate-sources</phase> <phase>generate-sources</phase>
......
...@@ -97,6 +97,11 @@ ...@@ -97,6 +97,11 @@
<artifactId>selenium-java</artifactId> <artifactId>selenium-java</artifactId>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-htmlunit-driver</artifactId>
<scope>test</scope>
</dependency>
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId> <artifactId>mockito-core</artifactId>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment