-
- Downloads
[SPARK-13692][CORE][SQL] Fix trivial Coverity/Checkstyle defects
## What changes were proposed in this pull request? This issue fixes the following potential bugs and Java coding style detected by Coverity and Checkstyle. - Implement both null and type checking in equals functions. - Fix wrong type casting logic in SimpleJavaBean2.equals. - Add `implement Cloneable` to `UTF8String` and `SortedIterator`. - Remove dereferencing before null check in `AbstractBytesToBytesMapSuite`. - Fix coding style: Add '{}' to single `for` statement in mllib examples. - Remove unused imports in `ColumnarBatch` and `JavaKinesisStreamSuite`. - Remove unused fields in `ChunkFetchIntegrationSuite`. - Add `stop()` to prevent resource leak. Please note that the last two checkstyle errors exist on newly added commits after [SPARK-13583](https://issues.apache.org/jira/browse/SPARK-13583). ## How was this patch tested? manual via `./dev/lint-java` and Coverity site. Author: Dongjoon Hyun <dongjoon@apache.org> Closes #11530 from dongjoon-hyun/SPARK-13692.
Showing
- common/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java 0 additions, 2 deletions.../org/apache/spark/network/ChunkFetchIntegrationSuite.java
- common/network-common/src/test/java/org/apache/spark/network/RequestTimeoutIntegrationSuite.java 1 addition, 1 deletion.../apache/spark/network/RequestTimeoutIntegrationSuite.java
- common/network-common/src/test/java/org/apache/spark/network/TransportClientFactorySuite.java 2 additions, 0 deletions...org/apache/spark/network/TransportClientFactorySuite.java
- common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java 2 additions, 1 deletion...c/main/java/org/apache/spark/unsafe/types/UTF8String.java
- core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java 1 addition, 1 deletion...ark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
- core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java 2 additions, 2 deletions...apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
- examples/src/main/java/org/apache/spark/examples/ml/JavaCountVectorizerExample.java 2 additions, 0 deletions.../apache/spark/examples/ml/JavaCountVectorizerExample.java
- examples/src/main/java/org/apache/spark/examples/ml/JavaDecisionTreeClassificationExample.java 2 additions, 0 deletions...rk/examples/ml/JavaDecisionTreeClassificationExample.java
- examples/src/main/java/org/apache/spark/examples/ml/JavaDecisionTreeRegressionExample.java 2 additions, 0 deletions.../spark/examples/ml/JavaDecisionTreeRegressionExample.java
- examples/src/main/java/org/apache/spark/examples/ml/JavaSQLTransformerExample.java 2 additions, 0 deletions...g/apache/spark/examples/ml/JavaSQLTransformerExample.java
- examples/src/main/java/org/apache/spark/examples/ml/JavaWord2VecExample.java 2 additions, 0 deletions...ava/org/apache/spark/examples/ml/JavaWord2VecExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaAssociationRulesExample.java 2 additions, 0 deletions...che/spark/examples/mllib/JavaAssociationRulesExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaGaussianMixtureExample.java 2 additions, 1 deletion...ache/spark/examples/mllib/JavaGaussianMixtureExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaGradientBoostingClassificationExample.java 2 additions, 0 deletions...ples/mllib/JavaGradientBoostingClassificationExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaGradientBoostingRegressionExample.java 2 additions, 0 deletions...examples/mllib/JavaGradientBoostingRegressionExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java 2 additions, 0 deletions...e/spark/examples/mllib/JavaIsotonicRegressionExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaKMeansExample.java 2 additions, 1 deletion...va/org/apache/spark/examples/mllib/JavaKMeansExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaLatentDirichletAllocationExample.java 2 additions, 1 deletion.../examples/mllib/JavaLatentDirichletAllocationExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaMultiLabelClassificationMetricsExample.java 2 additions, 0 deletions...les/mllib/JavaMultiLabelClassificationMetricsExample.java
- examples/src/main/java/org/apache/spark/examples/mllib/JavaNaiveBayesExample.java 2 additions, 0 deletions...rg/apache/spark/examples/mllib/JavaNaiveBayesExample.java
Loading
Please register or sign in to comment