Skip to content
Snippets Groups Projects
Commit f31a62d1 authored by Xusen Yin's avatar Xusen Yin Committed by Xiangrui Meng
Browse files

[SPARK-14440][PYSPARK] Remove pipeline specific reader and writer

## What changes were proposed in this pull request?

https://issues.apache.org/jira/browse/SPARK-14440

Remove

* PipelineMLWriter
* PipelineMLReader
* PipelineModelMLWriter
* PipelineModelMLReader

and modify comments.

## How was this patch tested?

test with unit test.

Author: Xusen Yin <yinxusen@gmail.com>

Closes #12216 from yinxusen/SPARK-14440.
parent 28ee1570
No related branches found
No related tags found
No related merge requests found
......@@ -29,24 +29,6 @@ from pyspark.ml.wrapper import JavaParams
from pyspark.mllib.common import inherit_doc
@inherit_doc
class PipelineMLWriter(JavaMLWriter):
"""
Private Pipeline utility class that can save ML instances through their Scala implementation.
We can currently use JavaMLWriter, rather than MLWriter, since Pipeline implements _to_java.
"""
@inherit_doc
class PipelineMLReader(JavaMLReader):
"""
Private utility class that can load Pipeline instances through their Scala implementation.
We can currently use JavaMLReader, rather than MLReader, since Pipeline implements _from_java.
"""
@inherit_doc
class Pipeline(Estimator, MLReadable, MLWritable):
"""
......@@ -154,8 +136,8 @@ class Pipeline(Estimator, MLReadable, MLWritable):
@since("2.0.0")
def write(self):
"""Returns an JavaMLWriter instance for this ML instance."""
return PipelineMLWriter(self)
"""Returns an MLWriter instance for this ML instance."""
return JavaMLWriter(self)
@since("2.0.0")
def save(self, path):
......@@ -166,7 +148,7 @@ class Pipeline(Estimator, MLReadable, MLWritable):
@since("2.0.0")
def read(cls):
"""Returns an MLReader instance for this class."""
return PipelineMLReader(cls)
return JavaMLReader(cls)
@classmethod
def _from_java(cls, java_stage):
......@@ -201,27 +183,6 @@ class Pipeline(Estimator, MLReadable, MLWritable):
return _java_obj
@inherit_doc
class PipelineModelMLWriter(JavaMLWriter):
"""
Private PipelineModel utility class that can save ML instances through their Scala
implementation.
We can (currently) use JavaMLWriter, rather than MLWriter, since PipelineModel implements
_to_java.
"""
@inherit_doc
class PipelineModelMLReader(JavaMLReader):
"""
Private utility class that can load PipelineModel instances through their Scala implementation.
We can currently use JavaMLReader, rather than MLReader, since PipelineModel implements
_from_java.
"""
@inherit_doc
class PipelineModel(Model, MLReadable, MLWritable):
"""
......@@ -254,8 +215,8 @@ class PipelineModel(Model, MLReadable, MLWritable):
@since("2.0.0")
def write(self):
"""Returns an JavaMLWriter instance for this ML instance."""
return PipelineModelMLWriter(self)
"""Returns an MLWriter instance for this ML instance."""
return JavaMLWriter(self)
@since("2.0.0")
def save(self, path):
......@@ -265,8 +226,8 @@ class PipelineModel(Model, MLReadable, MLWritable):
@classmethod
@since("2.0.0")
def read(cls):
"""Returns an JavaMLReader instance for this class."""
return PipelineModelMLReader(cls)
"""Returns an MLReader instance for this class."""
return JavaMLReader(cls)
@classmethod
def _from_java(cls, java_stage):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment