Skip to content
Snippets Groups Projects
Commit e5f77ae9 authored by Liang-Chi Hsieh's avatar Liang-Chi Hsieh Committed by Andrew Or
Browse files

[SPARK-3345] Do correct parameters for ShuffleFileGroup

In the method `newFileGroup` of class `FileShuffleBlockManager`, the parameters for creating new `ShuffleFileGroup` object is in wrong order.

Because in current codes, the parameters `shuffleId` and `fileId` are not used. So it doesn't cause problem now. However it should be corrected for readability and avoid future problem.

Author: Liang-Chi Hsieh <viirya@gmail.com>

Closes #2235 from viirya/correct_shufflefilegroup_params and squashes the following commits:

fe72567 [Liang-Chi Hsieh] Do correct parameters for ShuffleFileGroup.
parent 24262684
No related branches found
No related tags found
No related merge requests found
...@@ -168,7 +168,7 @@ class ShuffleBlockManager(blockManager: BlockManager, ...@@ -168,7 +168,7 @@ class ShuffleBlockManager(blockManager: BlockManager,
val filename = physicalFileName(shuffleId, bucketId, fileId) val filename = physicalFileName(shuffleId, bucketId, fileId)
blockManager.diskBlockManager.getFile(filename) blockManager.diskBlockManager.getFile(filename)
} }
val fileGroup = new ShuffleFileGroup(fileId, shuffleId, files) val fileGroup = new ShuffleFileGroup(shuffleId, fileId, files)
shuffleState.allFileGroups.add(fileGroup) shuffleState.allFileGroups.add(fileGroup)
fileGroup fileGroup
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment