-
- Downloads
[SPARK-19953][ML] Random Forest Models use parent UID when being fit
## What changes were proposed in this pull request? The ML `RandomForestClassificationModel` and `RandomForestRegressionModel` were not using the estimator parent UID when being fit. This change fixes that so the models can be properly be identified with their parents. ## How was this patch tested?Existing tests. Added check to verify that model uid matches that of the parent, then renamed `checkCopy` to `checkCopyAndUids` and verified that it was called by one test for each ML algorithm. Author: Bryan Cutler <cutlerb@gmail.com> Closes #17296 from BryanCutler/rfmodels-use-parent-uid-SPARK-19953.
Showing
- mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala 1 addition, 1 deletion...ache/spark/ml/classification/RandomForestClassifier.scala
- mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala 1 addition, 1 deletion...rg/apache/spark/ml/regression/RandomForestRegressor.scala
- mllib/src/test/scala/org/apache/spark/ml/PipelineSuite.scala 1 addition, 1 deletionmllib/src/test/scala/org/apache/spark/ml/PipelineSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala 1 addition, 2 deletions...spark/ml/classification/DecisionTreeClassifierSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala 2 additions, 4 deletions...g/apache/spark/ml/classification/GBTClassifierSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala 1 addition, 2 deletions...a/org/apache/spark/ml/classification/LinearSVCSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala 1 addition, 2 deletions...che/spark/ml/classification/LogisticRegressionSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala 1 addition, 1 deletion.../classification/MultilayerPerceptronClassifierSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala 1 addition, 0 deletions.../org/apache/spark/ml/classification/NaiveBayesSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala 1 addition, 2 deletions...a/org/apache/spark/ml/classification/OneVsRestSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/classification/RandomForestClassifierSuite.scala 1 addition, 2 deletions...spark/ml/classification/RandomForestClassifierSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/clustering/BisectingKMeansSuite.scala 1 addition, 2 deletions...org/apache/spark/ml/clustering/BisectingKMeansSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/clustering/GaussianMixtureSuite.scala 1 addition, 2 deletions...org/apache/spark/ml/clustering/GaussianMixtureSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala 1 addition, 2 deletions...st/scala/org/apache/spark/ml/clustering/KMeansSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala 2 additions, 2 deletions.../test/scala/org/apache/spark/ml/clustering/LDASuite.scala
- mllib/src/test/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala 2 additions, 1 deletion...e/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/feature/ChiSqSelectorSuite.scala 6 additions, 3 deletions...cala/org/apache/spark/ml/feature/ChiSqSelectorSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala 5 additions, 4 deletions...la/org/apache/spark/ml/feature/CountVectorizerSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/feature/IDFSuite.scala 5 additions, 3 deletions...src/test/scala/org/apache/spark/ml/feature/IDFSuite.scala
- mllib/src/test/scala/org/apache/spark/ml/feature/LSHTest.scala 3 additions, 1 deletion.../src/test/scala/org/apache/spark/ml/feature/LSHTest.scala
Loading
Please register or sign in to comment