Skip to content
Snippets Groups Projects
Commit dd907d1a authored by Andrew Or's avatar Andrew Or
Browse files

Revert "[SPARK-5771] Number of Cores in Completed Applications of Standalone...

Revert "[SPARK-5771] Number of Cores in Completed Applications of Standalone Master Web Page always be 0 if sc.stop() is called"

This reverts commit dd077abf.

Conflicts:
	core/src/main/scala/org/apache/spark/deploy/master/ApplicationInfo.scala
	core/src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala
parent f7c3668e
No related branches found
No related tags found
No related merge requests found
...@@ -91,7 +91,7 @@ private[deploy] class ApplicationInfo( ...@@ -91,7 +91,7 @@ private[deploy] class ApplicationInfo(
} }
} }
private[master] val requestedCores = desc.maxCores.getOrElse(defaultCores) private val requestedCores = desc.maxCores.getOrElse(defaultCores)
private[master] def coresLeft: Int = requestedCores - coresGranted private[master] def coresLeft: Int = requestedCores - coresGranted
......
...@@ -75,16 +75,12 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") { ...@@ -75,16 +75,12 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") {
val workers = state.workers.sortBy(_.id) val workers = state.workers.sortBy(_.id)
val workerTable = UIUtils.listingTable(workerHeaders, workerRow, workers) val workerTable = UIUtils.listingTable(workerHeaders, workerRow, workers)
val activeAppHeaders = Seq("Application ID", "Name", "Cores in Use", val appHeaders = Seq("Application ID", "Name", "Cores", "Memory per Node", "Submitted Time",
"Cores Requested", "Memory per Node", "Submitted Time", "User", "State", "Duration") "User", "State", "Duration")
val activeApps = state.activeApps.sortBy(_.startTime).reverse val activeApps = state.activeApps.sortBy(_.startTime).reverse
val activeAppsTable = UIUtils.listingTable(activeAppHeaders, activeAppRow, activeApps) val activeAppsTable = UIUtils.listingTable(appHeaders, appRow, activeApps)
val completedAppHeaders = Seq("Application ID", "Name", "Cores Requested", "Memory per Node",
"Submitted Time", "User", "State", "Duration")
val completedApps = state.completedApps.sortBy(_.endTime).reverse val completedApps = state.completedApps.sortBy(_.endTime).reverse
val completedAppsTable = UIUtils.listingTable(completedAppHeaders, completeAppRow, val completedAppsTable = UIUtils.listingTable(appHeaders, appRow, completedApps)
completedApps)
val driverHeaders = Seq("Submission ID", "Submitted Time", "Worker", "State", "Cores", val driverHeaders = Seq("Submission ID", "Submitted Time", "Worker", "State", "Cores",
"Memory", "Main Class") "Memory", "Main Class")
...@@ -191,7 +187,7 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") { ...@@ -191,7 +187,7 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") {
</tr> </tr>
} }
private def appRow(app: ApplicationInfo, active: Boolean): Seq[Node] = { private def appRow(app: ApplicationInfo): Seq[Node] = {
val killLink = if (parent.killEnabled && val killLink = if (parent.killEnabled &&
(app.state == ApplicationState.RUNNING || app.state == ApplicationState.WAITING)) { (app.state == ApplicationState.RUNNING || app.state == ApplicationState.WAITING)) {
val killLinkUri = s"app/kill?id=${app.id}&terminate=true" val killLinkUri = s"app/kill?id=${app.id}&terminate=true"
...@@ -201,7 +197,6 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") { ...@@ -201,7 +197,6 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") {
(<a href={killLinkUri} onclick={confirm}>kill</a>) (<a href={killLinkUri} onclick={confirm}>kill</a>)
</span> </span>
} }
<tr> <tr>
<td> <td>
<a href={"app?appId=" + app.id}>{app.id}</a> <a href={"app?appId=" + app.id}>{app.id}</a>
...@@ -210,15 +205,8 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") { ...@@ -210,15 +205,8 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") {
<td> <td>
<a href={app.desc.appUiUrl}>{app.desc.name}</a> <a href={app.desc.appUiUrl}>{app.desc.name}</a>
</td> </td>
{
if (active) {
<td>
{app.coresGranted}
</td>
}
}
<td> <td>
{app.requestedCores} {app.coresGranted}
</td> </td>
<td sorttable_customkey={app.desc.memoryPerSlave.toString}> <td sorttable_customkey={app.desc.memoryPerSlave.toString}>
{Utils.megabytesToString(app.desc.memoryPerSlave)} {Utils.megabytesToString(app.desc.memoryPerSlave)}
...@@ -230,14 +218,6 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") { ...@@ -230,14 +218,6 @@ private[ui] class MasterPage(parent: MasterWebUI) extends WebUIPage("") {
</tr> </tr>
} }
private def activeAppRow(app: ApplicationInfo): Seq[Node] = {
appRow(app, active = true)
}
private def completeAppRow(app: ApplicationInfo): Seq[Node] = {
appRow(app, active = false)
}
private def driverRow(driver: DriverInfo): Seq[Node] = { private def driverRow(driver: DriverInfo): Seq[Node] = {
val killLink = if (parent.killEnabled && val killLink = if (parent.killEnabled &&
(driver.state == DriverState.RUNNING || (driver.state == DriverState.RUNNING ||
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment