-
- Downloads
[SPARK-17851][SQL][TESTS] Make sure all test sqls in catalyst pass checkAnalysis
## What changes were proposed in this pull request? Currently we have several tens of test sqls in catalyst will fail at `SimpleAnalyzer.checkAnalysis`, we should make sure they are valid. This PR makes the following changes: 1. Apply `checkAnalysis` on plans that tests `Optimizer` rules, but don't require the testcases for `Parser`/`Analyzer` pass `checkAnalysis`; 2. Fix testcases for `Optimizer` that would have fall. ## How was this patch tested? Apply `SimpleAnalyzer.checkAnalysis` on plans in `PlanTest.comparePlans`, update invalid test cases. Author: Xingbo Jiang <xingbo.jiang@databricks.com> Author: jiangxingbo <jiangxb1987@gmail.com> Closes #15417 from jiangxb1987/cptest.
Showing
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala 8 additions, 0 deletions...org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala 1 addition, 1 deletion...e/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala 1 addition, 1 deletion...pache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala 1 addition, 1 deletion...ache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/AggregateOptimizeSuite.scala 2 additions, 2 deletions...spark/sql/catalyst/optimizer/AggregateOptimizeSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala 29 additions, 28 deletions...k/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala 2 additions, 2 deletions...che/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantPropagationSuite.scala 4 additions, 5 deletions...ark/sql/catalyst/optimizer/ConstantPropagationSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala 7 additions, 4 deletions...he/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushdownSuite.scala 7 additions, 5 deletions...che/spark/sql/catalyst/optimizer/LimitPushdownSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeCodegenSuite.scala 2 additions, 2 deletions...e/spark/sql/catalyst/optimizer/OptimizeCodegenSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OuterJoinEliminationSuite.scala 2 additions, 2 deletions...rk/sql/catalyst/optimizer/OuterJoinEliminationSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyCastsSuite.scala 7 additions, 2 deletions...che/spark/sql/catalyst/optimizer/SimplifyCastsSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala 3 additions, 3 deletions...rg/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala 12 additions, 2 deletions.../scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameHintSuite.scala 2 additions, 2 deletions.../test/scala/org/apache/spark/sql/DataFrameHintSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala 2 additions, 3 deletions.../org/apache/spark/sql/execution/SparkSqlParserSuite.scala
- sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala 9 additions, 11 deletions...scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala
Loading
Please register or sign in to comment