-
- Downloads
[SPARK-10176] [SQL] Show partially analyzed plans when checkAnswer fails to analyze
This PR takes over https://github.com/apache/spark/pull/8389. This PR improves `checkAnswer` to print the partially analyzed plan in addition to the user friendly error message, in order to aid debugging failing tests. In doing so, I ran into a conflict with the various ways that we bring a SQLContext into the tests. Depending on the trait we refer to the current context as `sqlContext`, `_sqlContext`, `ctx` or `hiveContext` with access modifiers `public`, `protected` and `private` depending on the defining class. I propose we refactor as follows: 1. All tests should only refer to a `protected sqlContext` when testing general features, and `protected hiveContext` when it is a method that only exists on a `HiveContext`. 2. All tests should only import `testImplicits._` (i.e., don't import `TestHive.implicits._`) Author: Wenchen Fan <cloud0fan@outlook.com> Closes #8584 from cloud-fan/cleanupTests.
Showing
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala 0 additions, 1 deletion.../scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala
- sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala 79 additions, 77 deletions...rc/test/scala/org/apache/spark/sql/CachedTableSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala 8 additions, 8 deletions...st/scala/org/apache/spark/sql/ColumnExpressionSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala 2 additions, 2 deletions.../scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala 3 additions, 3 deletions...cala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameImplicitsSuite.scala 4 additions, 4 deletions.../scala/org/apache/spark/sql/DataFrameImplicitsSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala 5 additions, 5 deletions.../test/scala/org/apache/spark/sql/DataFrameStatSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 7 additions, 7 deletions.../src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameTungstenSuite.scala 3 additions, 3 deletions...t/scala/org/apache/spark/sql/DataFrameTungstenSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/ExtraStrategiesSuite.scala 1 addition, 1 deletion...est/scala/org/apache/spark/sql/ExtraStrategiesSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala 6 additions, 6 deletionssql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/ListTablesSuite.scala 10 additions, 10 deletions...src/test/scala/org/apache/spark/sql/ListTablesSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala 22 additions, 5 deletionssql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala
- sql/core/src/test/scala/org/apache/spark/sql/RowSuite.scala 1 addition, 1 deletionsql/core/src/test/scala/org/apache/spark/sql/RowSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/SQLConfSuite.scala 22 additions, 22 deletions...re/src/test/scala/org/apache/spark/sql/SQLConfSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/SQLContextSuite.scala 6 additions, 6 deletions...src/test/scala/org/apache/spark/sql/SQLContextSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 19 additions, 21 deletions...e/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/SerializationSuite.scala 1 addition, 1 deletion.../test/scala/org/apache/spark/sql/SerializationSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala 14 additions, 33 deletions...est/scala/org/apache/spark/sql/StringFunctionsSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala 21 additions, 21 deletionssql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
Loading
Please register or sign in to comment