-
- Downloads
[SPARK-14465][BUILD] Checkstyle should check all Java files
## What changes were proposed in this pull request? Currently, `checkstyle` is configured to check the files under `src/main/java`. However, Spark has Java files in `src/main/scala`, too. This PR fixes the following configuration in `pom.xml` and the unchecked-so-far violations on those files. ```xml -<sourceDirectory>${basedir}/src/main/java</sourceDirectory> +<sourceDirectories>${basedir}/src/main/java,${basedir}/src/main/scala</sourceDirectories> ``` ## How was this patch tested? After passing the Jenkins build and manually `dev/lint-java`. (Note that Jenkins does not run `lint-java`) Author: Dongjoon Hyun <dongjoon@apache.org> Closes #12242 from dongjoon-hyun/SPARK-14465.
Showing
- core/src/main/java/org/apache/spark/io/LZ4BlockInputStream.java 6 additions, 8 deletions...rc/main/java/org/apache/spark/io/LZ4BlockInputStream.java
- external/java8-tests/src/test/java/org/apache/spark/streaming/Java8APISuite.java 4 additions, 2 deletions...c/test/java/org/apache/spark/streaming/Java8APISuite.java
- pom.xml 1 addition, 1 deletionpom.xml
- sql/core/src/main/java/org/apache/spark/sql/execution/BufferedRowIterator.java 1 addition, 1 deletion...a/org/apache/spark/sql/execution/BufferedRowIterator.java
- sql/core/src/main/java/org/apache/spark/sql/expressions/java/typed.java 5 additions, 6 deletions...ain/java/org/apache/spark/sql/expressions/java/typed.java
Loading
Please register or sign in to comment