-
- Downloads
[Spark 3922] Refactor spark-core to use Utils.UTF_8
A global UTF8 constant is very helpful to handle encoding problems when converting between String and bytes. There are several solutions here: 1. Add `val UTF_8 = Charset.forName("UTF-8")` to Utils.scala 2. java.nio.charset.StandardCharsets.UTF_8 (require JDK7) 3. io.netty.util.CharsetUtil.UTF_8 4. com.google.common.base.Charsets.UTF_8 5. org.apache.commons.lang.CharEncoding.UTF_8 6. org.apache.commons.lang3.CharEncoding.UTF_8 IMO, I prefer option 1) because people can find it easily. This is a PR for option 1) and only fixes Spark Core. Author: zsxwing <zsxwing@gmail.com> Closes #2781 from zsxwing/SPARK-3922 and squashes the following commits: f974edd [zsxwing] Merge branch 'master' into SPARK-3922 2d27423 [zsxwing] Refactor spark-core to use Refactor spark-core to use Utils.UTF_8
Showing
- core/src/main/scala/org/apache/spark/SparkSaslClient.scala 4 additions, 3 deletionscore/src/main/scala/org/apache/spark/SparkSaslClient.scala
- core/src/main/scala/org/apache/spark/SparkSaslServer.scala 6 additions, 4 deletionscore/src/main/scala/org/apache/spark/SparkSaslServer.scala
- core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala 4 additions, 5 deletions...rc/main/scala/org/apache/spark/api/python/PythonRDD.scala
- core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala 3 additions, 2 deletions.../spark/api/python/WriteInputFormatTestDataGenerator.scala
- core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala 2 additions, 2 deletions...n/scala/org/apache/spark/deploy/worker/DriverRunner.scala
- core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala 2 additions, 2 deletions...scala/org/apache/spark/deploy/worker/ExecutorRunner.scala
- core/src/main/scala/org/apache/spark/network/netty/client/BlockFetchingClient.scala 2 additions, 2 deletions...ache/spark/network/netty/client/BlockFetchingClient.scala
- core/src/main/scala/org/apache/spark/network/netty/client/BlockFetchingClientHandler.scala 3 additions, 2 deletions...ark/network/netty/client/BlockFetchingClientHandler.scala
- core/src/main/scala/org/apache/spark/network/netty/server/BlockServer.scala 2 additions, 2 deletions...a/org/apache/spark/network/netty/server/BlockServer.scala
- core/src/main/scala/org/apache/spark/network/netty/server/BlockServerChannelInitializer.scala 3 additions, 3 deletions.../network/netty/server/BlockServerChannelInitializer.scala
- core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala 3 additions, 1 deletion...cala/org/apache/spark/network/nio/ConnectionManager.scala
- core/src/main/scala/org/apache/spark/network/nio/Message.scala 3 additions, 1 deletion...src/main/scala/org/apache/spark/network/nio/Message.scala
- core/src/test/scala/org/apache/spark/network/netty/client/BlockFetchingClientHandlerSuite.scala 2 additions, 1 deletion...etwork/netty/client/BlockFetchingClientHandlerSuite.scala
- core/src/test/scala/org/apache/spark/network/netty/server/BlockHeaderEncoderSuite.scala 4 additions, 4 deletions.../spark/network/netty/server/BlockHeaderEncoderSuite.scala
- core/src/test/scala/org/apache/spark/util/FileAppenderSuite.scala 6 additions, 6 deletions.../test/scala/org/apache/spark/util/FileAppenderSuite.scala
- core/src/test/scala/org/apache/spark/util/UtilsSuite.scala 6 additions, 6 deletionscore/src/test/scala/org/apache/spark/util/UtilsSuite.scala
Loading
Please register or sign in to comment