-
- Downloads
[SPARK-17986][ML] SQLTransformer should remove temporary tables
## What changes were proposed in this pull request? A call to the method `SQLTransformer.transform` previously would create a temporary table and never delete it. This change adds a call to `dropTempView()` that deletes this temporary table before returning the result so that the table will not remain in spark's table catalog. Because `tableName` is randomized and not exposed, there should be no expected use of this table outside of the `transform` method. ## How was this patch tested? A single new assertion was added to the existing test of the `SQLTransformer.transform` method that all temporary tables are removed. Without the corresponding code change, this new assertion fails. I am not aware of any circumstances in which removing this temporary view would be bad for performance or correctness in other ways, but some expertise here would be helpful. Author: Drew Robb <drewrobb@gmail.com> Closes #15526 from drewrobb/SPARK-17986.
Showing
- mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala 3 additions, 1 deletion...in/scala/org/apache/spark/ml/feature/SQLTransformer.scala
- mllib/src/test/scala/org/apache/spark/ml/feature/SQLTransformerSuite.scala 1 addition, 0 deletions...ala/org/apache/spark/ml/feature/SQLTransformerSuite.scala
Please register or sign in to comment