Skip to content
Snippets Groups Projects
Commit a7c0e2a7 authored by Matei Zaharia's avatar Matei Zaharia
Browse files

Made task-finished log messages slightly nicer

parent 40f69140
No related branches found
No related tags found
No related merge requests found
...@@ -299,9 +299,11 @@ extends ParallelOperation with Logging ...@@ -299,9 +299,11 @@ extends ParallelOperation with Logging
def taskFinished(status: TaskStatus) { def taskFinished(status: TaskStatus) {
val tid = status.getTaskId val tid = status.getTaskId
logInfo("Finished opId " + opId + " TID " + tid)
val index = tidToIndex(tid) val index = tidToIndex(tid)
if (!finished(index)) { if (!finished(index)) {
tasksFinished += 1
logInfo("Finished opId %d TID %d (progress: %d/%d)".format(
opId, tid, tasksFinished, numTasks))
// Deserialize task result // Deserialize task result
val result = Utils.deserialize[TaskResult[T]](status.getData) val result = Utils.deserialize[TaskResult[T]](status.getData)
results(index) = result.value results(index) = result.value
...@@ -311,25 +313,25 @@ extends ParallelOperation with Logging ...@@ -311,25 +313,25 @@ extends ParallelOperation with Logging
finished(index) = true finished(index) = true
// Remove TID -> opId mapping from sched // Remove TID -> opId mapping from sched
sched.taskIdToOpId.remove(tid) sched.taskIdToOpId.remove(tid)
tasksFinished += 1
logInfo("Progress: " + tasksFinished + "/" + numTasks)
if (tasksFinished == numTasks) if (tasksFinished == numTasks)
setAllFinished() setAllFinished()
} else { } else {
logInfo("Task " + index + " has already finished, so ignoring it") logInfo("Ignoring task-finished event for TID " + tid +
" because task " + index + " is already finished")
} }
} }
def taskLost(status: TaskStatus) { def taskLost(status: TaskStatus) {
val tid = status.getTaskId val tid = status.getTaskId
logInfo("Lost opId " + opId + " TID " + tid)
val index = tidToIndex(tid) val index = tidToIndex(tid)
if (!finished(index)) { if (!finished(index)) {
logInfo("Lost opId " + opId + " TID " + tid)
launched(index) = false launched(index) = false
sched.taskIdToOpId.remove(tid) sched.taskIdToOpId.remove(tid)
tasksLaunched -= 1 tasksLaunched -= 1
} else { } else {
logInfo("Task " + index + " has already finished, so ignoring it") logInfo("Ignoring task-lost event for TID " + tid +
" because task " + index + " is already finished")
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment