-
- Downloads
[SPARK-17623][CORE] Clarify type of TaskEndReason with a failed task.
## What changes were proposed in this pull request? In TaskResultGetter, enqueueFailedTask currently deserializes the result as a TaskEndReason. But the type is actually more specific, its a TaskFailedReason. This just leads to more blind casting later on – it would be more clear if the msg was cast to the right type immediately, so method parameter types could be tightened. ## How was this patch tested? Existing unit tests via jenkins. Note that the code was already performing a blind-cast to a TaskFailedReason before in any case, just in a different spot, so there shouldn't be any behavior change. Author: Imran Rashid <irashid@cloudera.com> Closes #15181 from squito/SPARK-17623.
Showing
- core/src/main/scala/org/apache/spark/executor/CommitDeniedException.scala 2 additions, 2 deletions...ala/org/apache/spark/executor/CommitDeniedException.scala
- core/src/main/scala/org/apache/spark/executor/Executor.scala 2 additions, 2 deletionscore/src/main/scala/org/apache/spark/executor/Executor.scala
- core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala 2 additions, 2 deletions...n/scala/org/apache/spark/scheduler/TaskResultGetter.scala
- core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala 1 addition, 1 deletion.../scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
- core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala 3 additions, 9 deletions...ain/scala/org/apache/spark/scheduler/TaskSetManager.scala
- core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala 2 additions, 2 deletions...scala/org/apache/spark/shuffle/FetchFailedException.scala
- core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala 1 addition, 1 deletion.../test/scala/org/apache/spark/util/JsonProtocolSuite.scala
Loading
Please register or sign in to comment