Skip to content
Snippets Groups Projects
Commit 8c66c499 authored by Matei Zaharia's avatar Matei Zaharia
Browse files

Tweak web UI so that people don't get confused about master URL format

Conflicts:
	core/src/main/twirl/spark/deploy/master/index.scala.html
	core/src/main/twirl/spark/deploy/worker/index.scala.html
parent 0b788b76
No related branches found
No related tags found
No related merge requests found
......@@ -76,8 +76,11 @@ private[spark] case object RequestMasterState
// Master to MasterWebUI
private[spark]
case class MasterState(uri: String, workers: Array[WorkerInfo], activeJobs: Array[JobInfo],
completedJobs: Array[JobInfo])
case class MasterState(host: String, port: Int, workers: Array[WorkerInfo],
activeJobs: Array[JobInfo], completedJobs: Array[JobInfo]) {
def uri = "spark://" + host + ":" + port
}
// WorkerWebUI to Worker
private[spark] case object RequestWorkerState
......@@ -85,6 +88,6 @@ private[spark] case object RequestWorkerState
// Worker to WorkerWebUI
private[spark]
case class WorkerState(uri: String, workerId: String, executors: List[ExecutorRunner],
case class WorkerState(host: String, port: Int, workerId: String, executors: List[ExecutorRunner],
finishedExecutors: List[ExecutorRunner], masterUrl: String, cores: Int, memory: Int,
coresUsed: Int, memoryUsed: Int, masterWebUiUrl: String)
......@@ -131,7 +131,7 @@ private[spark] class Master(ip: String, port: Int, webUiPort: Int) extends Actor
}
case RequestMasterState => {
sender ! MasterState(ip + ":" + port, workers.toArray, jobs.toArray, completedJobs.toArray)
sender ! MasterState(ip, port, workers.toArray, jobs.toArray, completedJobs.toArray)
}
}
......
......@@ -140,7 +140,7 @@ private[spark] class Worker(
masterDisconnected()
case RequestWorkerState => {
sender ! WorkerState(ip + ":" + port, workerId, executors.values.toList,
sender ! WorkerState(ip, port, workerId, executors.values.toList,
finishedExecutors.values.toList, masterUrl, cores, memory,
coresUsed, memoryUsed, masterWebUiUrl)
}
......
......@@ -2,13 +2,13 @@
@import spark.deploy.master._
@import spark.Utils
@spark.common.html.layout(title = "Spark Master on " + state.uri) {
@spark.common.html.layout(title = "Spark Master on " + state.host) {
<!-- Cluster Details -->
<div class="row">
<div class="span12">
<ul class="unstyled">
<li><strong>URL:</strong> spark://@(state.uri)</li>
<li><strong>URL:</strong> @(state.uri)</li>
<li><strong>Workers:</strong> @state.workers.size </li>
<li><strong>Cores:</strong> @{state.workers.map(_.cores).sum} Total,
@{state.workers.map(_.coresUsed).sum} Used</li>
......
@(worker: spark.deploy.WorkerState)
@import spark.Utils
@spark.common.html.layout(title = "Spark Worker on " + worker.uri) {
@spark.common.html.layout(title = "Spark Worker on " + worker.host) {
<!-- Worker Details -->
<div class="row">
<div class="span12">
......@@ -10,12 +10,12 @@
<li><strong>ID:</strong> @worker.workerId</li>
<li><strong>
Master URL:</strong> @worker.masterUrl
(WebUI at <a href="@worker.masterWebUiUrl">@worker.masterWebUiUrl</a>)
</li>
<li><strong>Cores:</strong> @worker.cores (@worker.coresUsed Used)</li>
<li><strong>Memory:</strong> @{Utils.memoryMegabytesToString(worker.memory)}
(@{Utils.memoryMegabytesToString(worker.memoryUsed)} Used)</li>
</ul>
<p><a href="@worker.masterWebUiUrl">Back to Master</a></p>
</div>
</div>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment