Skip to content
Snippets Groups Projects
Commit 81b4db37 authored by Josiah Samuel's avatar Josiah Samuel Committed by Marcelo Vanzin
Browse files

[SPARK-10172] [CORE] disable sort in HistoryServer webUI

This pull request is to address the JIRA SPARK-10172 (History Server web UI gets messed up when sorting on any column).
The content of the table gets messed up due to the rowspan attribute of the table data(cell) during sorting.
The current table sort library used in SparkUI (sorttable.js) doesn't support/handle cells(td) with rowspans.
The fix will disable the table sort in the web UI, when there are jobs listed with multiple attempts.

Author: Josiah Samuel <josiah_sams@in.ibm.com>

Closes #8506 from josiahsams/SPARK-10172.
parent 136c77d8
No related branches found
No related tags found
No related merge requests found
......@@ -51,7 +51,10 @@ private[history] class HistoryPage(parent: HistoryServer) extends WebUIPage("")
val hasMultipleAttempts = appsToShow.exists(_.attempts.size > 1)
val appTable =
if (hasMultipleAttempts) {
UIUtils.listingTable(appWithAttemptHeader, appWithAttemptRow, appsToShow)
// Sorting is disable here as table sort on rowspan has issues.
// ref. SPARK-10172
UIUtils.listingTable(appWithAttemptHeader, appWithAttemptRow,
appsToShow, sortable = false)
} else {
UIUtils.listingTable(appHeader, appRow, appsToShow)
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment