-
- Downloads
[SPARK-9580] [SQL] Replace singletons in SQL tests
A fundamental limitation of the existing SQL tests is that *there is simply no way to create your own `SparkContext`*. This is a serious limitation because the user may wish to use a different master or config. As a case in point, `BroadcastJoinSuite` is entirely commented out because there is no way to make it pass with the existing infrastructure. This patch removes the singletons `TestSQLContext` and `TestData`, and instead introduces a `SharedSQLContext` that starts a context per suite. Unfortunately the singletons were so ingrained in the SQL tests that this patch necessarily needed to touch *all* the SQL test files. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/8111) <!-- Reviewable:end --> Author: Andrew Or <andrew@databricks.com> Closes #8111 from andrewor14/sql-tests-refactor.
Showing
- project/MimaExcludes.scala 10 additions, 0 deletionsproject/MimaExcludes.scala
- project/SparkBuild.scala 11 additions, 5 deletionsproject/SparkBuild.scala
- sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala 1 addition, 5 deletions...ache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
- sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala 4 additions, 93 deletions...core/src/main/scala/org/apache/spark/sql/SQLContext.scala
- sql/core/src/main/scala/org/apache/spark/sql/SQLImplicits.scala 123 additions, 0 deletions...re/src/main/scala/org/apache/spark/sql/SQLImplicits.scala
- sql/core/src/test/java/test/org/apache/spark/sql/JavaApplySchemaSuite.java 6 additions, 4 deletions.../java/test/org/apache/spark/sql/JavaApplySchemaSuite.java
- sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java 20 additions, 19 deletions...st/java/test/org/apache/spark/sql/JavaDataFrameSuite.java
- sql/core/src/test/java/test/org/apache/spark/sql/JavaUDFSuite.java 7 additions, 3 deletions...src/test/java/test/org/apache/spark/sql/JavaUDFSuite.java
- sql/core/src/test/java/test/org/apache/spark/sql/sources/JavaSaveLoadSuite.java 12 additions, 3 deletions.../test/org/apache/spark/sql/sources/JavaSaveLoadSuite.java
- sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala 5 additions, 9 deletions...rc/test/scala/org/apache/spark/sql/CachedTableSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala 17 additions, 20 deletions...st/scala/org/apache/spark/sql/ColumnExpressionSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala 4 additions, 6 deletions.../scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala 8 additions, 10 deletions.../scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameImplicitsSuite.scala 3 additions, 3 deletions.../scala/org/apache/spark/sql/DataFrameImplicitsSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala 4 additions, 6 deletions.../test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala 3 additions, 3 deletions...cala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala 8 additions, 11 deletions.../test/scala/org/apache/spark/sql/DataFrameStatSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 3 additions, 9 deletions.../src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DataFrameTungstenSuite.scala 3 additions, 5 deletions...t/scala/org/apache/spark/sql/DataFrameTungstenSuite.scala
- sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala 6 additions, 7 deletions.../test/scala/org/apache/spark/sql/DateFunctionsSuite.scala
Loading
Please register or sign in to comment