-
- Downloads
[SPARK-21903][BUILD] Upgrade scalastyle to 1.0.0.
## What changes were proposed in this pull request? 1.0.0 fixes an issue with import order, explicit type for public methods, line length limitation and comment validation: ``` [error] .../spark/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala:50:16: Are you sure you want to println? If yes, wrap the code block with [error] // scalastyle:off println [error] println(...) [error] // scalastyle:on println [error] .../spark/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala:49: File line length exceeds 100 characters [error] .../spark/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala:22:21: Are you sure you want to println? If yes, wrap the code block with [error] // scalastyle:off println [error] println(...) [error] // scalastyle:on println [error] .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:35:6: Public method must have explicit type [error] .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:51:6: Public method must have explicit type [error] .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:93:15: Public method must have explicit type [error] .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:98:15: Public method must have explicit type [error] .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:47:2: Insert a space after the start of the comment [error] .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:26:43: JavaDStream should come before JavaDStreamLike. ``` This PR also fixes the workaround added in SPARK-16877 for `org.scalastyle.scalariform.OverrideJavaChecker` feature, added from 0.9.0. ## How was this patch tested? Manually tested. Author: hyukjinkwon <gurwls223@gmail.com> Closes #19116 from HyukjinKwon/scalastyle-1.0.0.
Showing
- project/SparkBuild.scala 3 additions, 2 deletionsproject/SparkBuild.scala
- project/plugins.sbt 1 addition, 2 deletionsproject/plugins.sbt
- repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala 2 additions, 0 deletions...cala-2.11/src/main/scala/org/apache/spark/repl/Main.scala
- repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala 4 additions, 1 deletion....11/src/main/scala/org/apache/spark/repl/SparkILoop.scala
- scalastyle-config.xml 1 addition, 4 deletionsscalastyle-config.xml
- streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala 6 additions, 6 deletions.../test/java/org/apache/spark/streaming/JavaTestUtils.scala
Loading
Please register or sign in to comment