-
- Downloads
SPARK-1708. Add a ClassTag on Serializer and things that depend on it
This pull request contains a rebased patch from @heathermiller (https://github.com/heathermiller/spark/pull/1) to add ClassTags on Serializer and types that depend on it (Broadcast and AccumulableCollection). Putting these in the public API signatures now will allow us to use Scala Pickling for serialization down the line without breaking binary compatibility. One question remaining is whether we also want them on Accumulator -- Accumulator is passed as part of a bigger Task or TaskResult object via the closure serializer so it doesn't seem super useful to add the ClassTag there. Broadcast and AccumulableCollection in contrast were being serialized directly. CC @rxin, @pwendell, @heathermiller Author: Matei Zaharia <matei@databricks.com> Closes #700 from mateiz/spark-1708 and squashes the following commits: 1a3d8b0 [Matei Zaharia] Use fake ClassTag in Java 3b449ed [Matei Zaharia] test fix 2209a27 [Matei Zaharia] Code style fixes 9d48830 [Matei Zaharia] Add a ClassTag on Serializer and things that depend on it
Showing
- core/src/main/scala/org/apache/spark/Accumulators.scala 4 additions, 3 deletionscore/src/main/scala/org/apache/spark/Accumulators.scala
- core/src/main/scala/org/apache/spark/SparkContext.scala 2 additions, 2 deletionscore/src/main/scala/org/apache/spark/SparkContext.scala
- core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala 1 addition, 1 deletion...in/scala/org/apache/spark/api/java/JavaSparkContext.scala
- core/src/main/scala/org/apache/spark/broadcast/Broadcast.scala 3 additions, 1 deletion...src/main/scala/org/apache/spark/broadcast/Broadcast.scala
- core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala 3 additions, 1 deletion...n/scala/org/apache/spark/broadcast/BroadcastFactory.scala
- core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala 3 additions, 1 deletion...n/scala/org/apache/spark/broadcast/BroadcastManager.scala
- core/src/main/scala/org/apache/spark/broadcast/HttpBroadcast.scala 5 additions, 2 deletions...main/scala/org/apache/spark/broadcast/HttpBroadcast.scala
- core/src/main/scala/org/apache/spark/broadcast/HttpBroadcastFactory.scala 3 additions, 1 deletion...ala/org/apache/spark/broadcast/HttpBroadcastFactory.scala
- core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala 3 additions, 1 deletion...n/scala/org/apache/spark/broadcast/TorrentBroadcast.scala
- core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcastFactory.scala 3 additions, 1 deletion.../org/apache/spark/broadcast/TorrentBroadcastFactory.scala
- core/src/main/scala/org/apache/spark/rdd/CheckpointRDD.scala 2 additions, 2 deletionscore/src/main/scala/org/apache/spark/rdd/CheckpointRDD.scala
- core/src/main/scala/org/apache/spark/rdd/ParallelCollectionRDD.scala 1 addition, 1 deletion...in/scala/org/apache/spark/rdd/ParallelCollectionRDD.scala
- core/src/main/scala/org/apache/spark/rdd/RDDCheckpointData.scala 1 addition, 1 deletion...c/main/scala/org/apache/spark/rdd/RDDCheckpointData.scala
- core/src/main/scala/org/apache/spark/serializer/JavaSerializer.scala 8 additions, 5 deletions...in/scala/org/apache/spark/serializer/JavaSerializer.scala
- core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala 7 additions, 5 deletions...in/scala/org/apache/spark/serializer/KryoSerializer.scala
- core/src/main/scala/org/apache/spark/serializer/Serializer.scala 9 additions, 8 deletions...c/main/scala/org/apache/spark/serializer/Serializer.scala
- core/src/main/scala/org/apache/spark/util/Utils.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/util/Utils.scala
- core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala 6 additions, 5 deletions...ala/org/apache/spark/serializer/KryoSerializerSuite.scala
- examples/src/main/scala/org/apache/spark/examples/bagel/WikipediaPageRankStandalone.scala 7 additions, 5 deletions...he/spark/examples/bagel/WikipediaPageRankStandalone.scala
- graphx/src/main/scala/org/apache/spark/graphx/impl/Serializers.scala 24 additions, 21 deletions...main/scala/org/apache/spark/graphx/impl/Serializers.scala
Loading
Please register or sign in to comment