Skip to content
Snippets Groups Projects
Commit 71b7d42f authored by Xin Ren's avatar Xin Ren Committed by Shivaram Venkataraman
Browse files

[SPARK-16445][MLLIB][SPARKR] Fix @return description for sparkR mlp summary() method

## What changes were proposed in this pull request?

Fix summary() method's `return` description for spark.mlp

## How was this patch tested?

Ran tests locally on my laptop.

Author: Xin Ren <iamshrek@126.com>

Closes #15015 from keypointt/SPARK-16445-2.
parent 6ea5055f
No related branches found
No related tags found
No related merge requests found
......@@ -720,8 +720,9 @@ setMethod("predict", signature(object = "MultilayerPerceptronClassificationModel
# Returns the summary of a Multilayer Perceptron Classification Model produced by \code{spark.mlp}
#' @param object a Multilayer Perceptron Classification Model fitted by \code{spark.mlp}
#' @return \code{summary} returns a list containing \code{layers}, the label distribution, and
#' \code{tables}, conditional probabilities given the target label.
#' @return \code{summary} returns a list containing \code{labelCount}, \code{layers}, and
#' \code{weights}. For \code{weights}, it is a numeric vector with length equal to
#' the expected given the architecture (i.e., for 8-10-2 network, 100 connection weights).
#' @rdname spark.mlp
#' @export
#' @aliases summary,MultilayerPerceptronClassificationModel-method
......@@ -732,7 +733,6 @@ setMethod("summary", signature(object = "MultilayerPerceptronClassificationModel
labelCount <- callJMethod(jobj, "labelCount")
layers <- unlist(callJMethod(jobj, "layers"))
weights <- callJMethod(jobj, "weights")
weights <- matrix(weights, nrow = length(weights))
list(labelCount = labelCount, layers = layers, weights = weights)
})
......
......@@ -369,6 +369,8 @@ test_that("spark.mlp", {
expect_equal(summary$labelCount, 3)
expect_equal(summary$layers, c(4, 5, 4, 3))
expect_equal(length(summary$weights), 64)
expect_equal(head(summary$weights, 5), list(-0.878743, 0.2154151, -1.16304, -0.6583214, 1.009825),
tolerance = 1e-6)
# Test predict method
mlpTestDF <- df
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment