-
- Downloads
[SPARK-4102] Remove unused ShuffleReader.stop() method.
This method is not implemented by the only subclass (HashShuffleReader), nor is it ever called. While the use of Scala's fancy "???" was pretty exciting, the method's existence can only lead to confusion and it therefore should be deleted. mateiz was there a reason for adding this that I'm missing? Author: Kay Ousterhout <kayousterhout@gmail.com> Closes #2966 from kayousterhout/SPARK-4102 and squashes the following commits: 532c564 [Kay Ousterhout] Added back commented-out method, as per Matei's request 904655e [Kay Ousterhout] [SPARK-4102] Remove unused ShuffleReader.stop() method.
Showing
- core/src/main/scala/org/apache/spark/shuffle/ShuffleReader.scala 6 additions, 2 deletions...c/main/scala/org/apache/spark/shuffle/ShuffleReader.scala
- core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala 0 additions, 3 deletions...ala/org/apache/spark/shuffle/hash/HashShuffleReader.scala
Please register or sign in to comment