-
- Downloads
Replace use of .size with .length for Arrays
Invoking .size on arrays is valid, but requires an implicit conversion to SeqLike. This incurs a compile time overhead and more importantly a runtime overhead, as the Array must be wrapped before the method can be invoked. For example, the difference in generated byte code is: public int withSize(); Code: 0: getstatic #23 // Field scala/Predef$.MODULE$:Lscala/Predef$; 3: aload_0 4: invokevirtual #25 // Method array:()[I 7: invokevirtual #29 // Method scala/Predef$.intArrayOps:([I)Lscala/collection/mutable/ArrayOps; 10: invokeinterface #34, 1 // InterfaceMethod scala/collection/mutable/ArrayOps.size:()I 15: ireturn public int withLength(); Code: 0: aload_0 1: invokevirtual #25 // Method array:()[I 4: arraylength 5: ireturn Author: sksamuel <sam@sksamuel.com> Closes #5376 from sksamuel/master and squashes the following commits: 77ec261 [sksamuel] Replace use of .size with .length for Arrays.
Showing
- core/src/main/scala/org/apache/spark/network/nio/Connection.scala 1 addition, 1 deletion.../main/scala/org/apache/spark/network/nio/Connection.scala
- core/src/main/scala/org/apache/spark/rdd/AsyncRDDActions.scala 5 additions, 5 deletions...src/main/scala/org/apache/spark/rdd/AsyncRDDActions.scala
- core/src/main/scala/org/apache/spark/rdd/BlockRDD.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/rdd/BlockRDD.scala
- core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala 2 additions, 2 deletionscore/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala
- core/src/main/scala/org/apache/spark/rdd/CheckpointRDD.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/rdd/CheckpointRDD.scala
- core/src/main/scala/org/apache/spark/rdd/CoGroupedRDD.scala 2 additions, 2 deletionscore/src/main/scala/org/apache/spark/rdd/CoGroupedRDD.scala
- core/src/main/scala/org/apache/spark/rdd/CoalescedRDD.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/rdd/CoalescedRDD.scala
- core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala 2 additions, 2 deletions.../main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
- core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala 1 addition, 1 deletion...main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala
- core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala 1 addition, 1 deletion...rc/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
- core/src/main/scala/org/apache/spark/rdd/RDD.scala 11 additions, 11 deletionscore/src/main/scala/org/apache/spark/rdd/RDD.scala
- core/src/main/scala/org/apache/spark/rdd/RDDCheckpointData.scala 3 additions, 3 deletions...c/main/scala/org/apache/spark/rdd/RDDCheckpointData.scala
- core/src/main/scala/org/apache/spark/rdd/SubtractedRDD.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/rdd/SubtractedRDD.scala
- core/src/main/scala/org/apache/spark/rdd/UnionRDD.scala 3 additions, 3 deletionscore/src/main/scala/org/apache/spark/rdd/UnionRDD.scala
- core/src/main/scala/org/apache/spark/rdd/ZippedPartitionsRDD.scala 2 additions, 2 deletions...main/scala/org/apache/spark/rdd/ZippedPartitionsRDD.scala
- core/src/main/scala/org/apache/spark/rdd/ZippedWithIndexRDD.scala 1 addition, 1 deletion.../main/scala/org/apache/spark/rdd/ZippedWithIndexRDD.scala
- core/src/main/scala/org/apache/spark/storage/RDDInfo.scala 1 addition, 1 deletioncore/src/main/scala/org/apache/spark/storage/RDDInfo.scala
- core/src/main/scala/org/apache/spark/ui/ConsoleProgressBar.scala 2 additions, 2 deletions...c/main/scala/org/apache/spark/ui/ConsoleProgressBar.scala
- core/src/main/scala/org/apache/spark/util/collection/BitSet.scala 1 addition, 1 deletion.../main/scala/org/apache/spark/util/collection/BitSet.scala
Loading
Please register or sign in to comment